Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kshitiz Varshney <kshitiz.varshney@nxp.com>
To:     Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>,
        Vabhav Sharma <vabhav.sharma@nxp.com>,
        Sahil Malhotra <sahil.malhotra@nxp.com>,
        Matt Mackall <mpm@selenic.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
        Martin Kaiser <martin@kaiser.cx>
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
        Kshitiz Varshney <kshitiz.varshney@nxp.com>
Subject: [PATCH v1] Moving IRQ handler registering after imx_rngc_irq_mask_clear()
Date:   Mon, 22 Aug 2022 13:19:03 +0200
Message-Id: <20220822111903.328957-1-kshitiz.varshney@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+wHp3n3MnLpZtSR6jF7YwzDL7HuijguWK1xdpAIICbegBLRcRAQpLNHr2+Ek?=
 =?us-ascii?Q?CKfGllgbLaRklu61bjbrnedxDOBy1iqhOtmKc+58c80B13F2jCCXpPtBLudZ?=
 =?us-ascii?Q?dBWvyiicxC/i4CaMZmtsfvPN4nxPHM8YUGUVeTe0xwR7FbnFcibJQnjPi3W6?=
 =?us-ascii?Q?rXw/7KMm33Jc6pzIBs9fatp9egPe/mnLT5hagrmekXLTLhaaU4aXEpcbtkfR?=
 =?us-ascii?Q?peZrEKK1QYsnNRyGG2T6sDTINrA9k9bSh8hJvRaRdglkQMy3d9DGHu/Kn/CJ?=
 =?us-ascii?Q?s2QOCrAy09BU8T4zvxbRjapfqeBskA3USNab7MH+EerWlBTtW6VV4IC4GyFf?=
 =?us-ascii?Q?dOYLSvMXbrdq8JA3VgU5ok4z/tD4w1hVaj7Hbh14BCOftcGH669K0wpHyLNx?=
 =?us-ascii?Q?ew39ogeH0RBH3LlCUBo2I83ocSC9txAIDSSyvigPDnujNuoxiEPbMRuoTvHy?=
 =?us-ascii?Q?DCCwqGJuEqBoQvd9/bmuHa6na9w78B6xTWZT3JmQ+Cj7crEuLSd3csYTAZDo?=
 =?us-ascii?Q?ioMcCx+S7huz27dLHIIcKDPw8RQhxOWEKV835X5AsJHb7mTtXQeWUht3Wmiu?=
 =?us-ascii?Q?R/pAFvYeOFDNGlLX96NXPqIArXF/zrKvbiUe82rsYe8HjM7wcM3tfm5ecHv2?=
 =?us-ascii?Q?gu54+5zEpCLjtyD+JvgEYGXqIyz9DxuWy/8032s0aKccca5i/V+rtvptbit9?=
 =?us-ascii?Q?mRB8IgPCeY6eAochyWkTZzoPFN2OYcHBWcDgyUqcY6RTJFn9l4RyIsQVU0FC?=
 =?us-ascii?Q?f2ZVPahse0K+Udd0exnsH0QmB38kjk1XBkzrQp+XuwIWszKGxPbxudg9FqX7?=
 =?us-ascii?Q?1iseM4iDvUc4S9dYhd4rK/loXGdglsnk0q9EIN4Jr3dCsJskgoGDcuHHHAfR?=
 =?us-ascii?Q?Q+uNpFC59nPhvs7cdpvF0WDAyh/vAF8VsFdC9pwWU/X7pp8Hr6euWJXx0nAp?=
 =?us-ascii?Q?XUZBNgJrtnVkMaG6zMwgM7h8tfd0XyiUS+uexWJObBTDfF5vHWK3jBSWO1Iv?=
 =?us-ascii?Q?Kcq/FOgjgditrt36xNKCHFfGOVqhzsJNhvBqDLRAz3wC4+mGdZvNgrINDyXa?=
 =?us-ascii?Q?Bp8ZQBmw8zoDoRF/uGwolc3i2NMO+7f62TSnhxvd31T/N+t+MGvu50DAbYdx?=
 =?us-ascii?Q?b3LKkLv97BvT9OxauZaJZFw4ZvE6jwhYCvyC/xtgOow4Hx24YrHrMYeVbR+C?=
 =?us-ascii?Q?xAdnPuWNSzuBovhE9WtuzOmZUf3Rq0mS4IZdapUMQ1GAsuwSP3p+vtEaU24A?=
 =?us-ascii?Q?7NVMdMiJqwS0+6mGSfHRIzUwq2vNcVEd1DwLA/NFsGP3AkIHJYWEgN+tIzU/?=
 =?us-ascii?Q?76K1M6A73Nh9vQJLSePHdnaQETc+i4swBebRKNQgq4Q51eIjf4FdxJvue0Cm?=
 =?us-ascii?Q?pUzoj4MjY60qksral9CNCxiRHl1D8mh97BhVkcd7yy2Sck+UM5n688PlZbLh?=
 =?us-ascii?Q?VugpaShFHOjAv1gQo3or5vu5TsMAevihnbwobfg1Ikf2TS6ZKHbFwGjwj0au?=
 =?us-ascii?Q?8GGBGisY34k2vESd/7buWr5llKDsUZe9AwQg89nkLZGmEsHLDpPwU/uGZzya?=
 =?us-ascii?Q?cjWL+5ajL3xQAdJ6UxoXQFAYFQ1DIpkNXhfOaP1EjqRkSj7TMtIhn0zfH3Ol?=
 =?us-ascii?Q?zw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29edbe54-5513-4b1d-205f-08da8430314f
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8296.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 11:19:34.8318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UKaBwvMUsiDHkKe2TERVKG2I3TfKfAlFLMdzlALVKlVDM4nv77mLX7Jucq119MQO123K3cGAvV9fxI6Ec17lZVKS8NARxPAgjhhyZ8pNed0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9594
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Issue:
While servicing interrupt, if the IRQ happens to be because of a SEED_DONE
due to a previous boot stage, you end up completing the completion
prematurely, hence causing kernel to crash while booting.

Fix:
Moving IRQ handler registering after imx_rngc_irq_mask_clear()

Fixes: 1d5449445bd0 (hwrng: mx-rngc - add a driver for Freescale RNGC)
Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
---
 drivers/char/hw_random/imx-rngc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 53e571c4f283..0b71ed850809 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -272,14 +272,6 @@ static int imx_rngc_probe(struct platform_device *pdev)
 
 	init_completion(&rngc->rng_op_done);
 
-	ret = devm_request_irq(&pdev->dev,
-			irq, imx_rngc_irq, 0, pdev->name, (void *)rngc);
-	if (ret) {
-		dev_err(rngc->dev, "Can't get interrupt working.\n");
-		goto err;
-	}
-
-
 	rngc->rng.name = pdev->name;
 	rngc->rng.init = imx_rngc_init;
 	rngc->rng.read = imx_rngc_read;
@@ -291,6 +283,14 @@ static int imx_rngc_probe(struct platform_device *pdev)
 
 	imx_rngc_irq_mask_clear(rngc);
 
+
+	ret = devm_request_irq(&pdev->dev,
+			irq, imx_rngc_irq, 0, pdev->name, (void *)rngc);
+
+	if (ret) {
+		dev_err(rngc->dev, "Can't get interrupt working.\n");
+		goto err;
+	}
 	if (self_test) {
 		ret = imx_rngc_self_test(rngc);
 		if (ret) {
-- 
2.25.1