Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 12:23:16 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     <linux-kernel@vger.kernel.org>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Arnaud Ebalard <arno@natisbad.org>,
        Srujana Challa <schalla@marvell.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>
Subject: Re: [PATCH] crypto: move from strlcpy with unused retval to strscpy
Message-ID: <YwNnJJuQdpTo4y7Q@gcabiddu-mobl1.ger.corp.intel.com>
References: <20220818210003.6649-1-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220818210003.6649-1-wsa+renesas@sang-engineering.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pliyEhdFGCzNCkxvyeLtTZNLscy/wfJrOv0H7+Vb5MkplvyDHYI4U7a/Sv/t?=
 =?us-ascii?Q?Lk2NNziacci9/uXokmneOErUUDe/XPHEi0g2ynxmCAu/NVPZOzLZNMesn9xm?=
 =?us-ascii?Q?bNC0EV/rDifXL1+EalRZyDD9R3m9hhL0yru7hbiLxNvjf8LTaq1A6/8tOv/D?=
 =?us-ascii?Q?MCDALrNIQazD62Dq6VoMKJUZpwTKtwigVQDWKd71qKhbH7oQaN7v/pjV73x2?=
 =?us-ascii?Q?RnRJl/XhNkAXGyxNBb9UeNygeb3Tv6Lpn5U5wAz7qFgORejx+5ze91SgkbPp?=
 =?us-ascii?Q?ESDSH3+d9UGnoqKcw+zlF4FjK/9QHp63m/SMywMq8sSNruLCVQnU7SobDjH6?=
 =?us-ascii?Q?9VqmmBnRdU4YpsJh2seCo6ABLrB8Ftj1qXV3lotgBPImOH9lBOGTK7jz4Hx/?=
 =?us-ascii?Q?c2olwSuq9CDaaZUvCpyg/S9LujqHa+sfQ5nCoYmEG0C85q3xkqQCAjtcvQri?=
 =?us-ascii?Q?/NsT4TUJV/MAgpyOf6nOenD7zc7fTxcjuhLv30WYZknemY7LLagwO8gcDFfu?=
 =?us-ascii?Q?T6OXbPxFDqrx/rVP+H5LAoZo3BzmPOr+R0KwvMR20APZiHM5tY7dFYU8WKdM?=
 =?us-ascii?Q?unikn7S+ENr1gALQAUUicqo1K799TGTiBuaxAJzaf0k0HQKCYOBoRz61wW5V?=
 =?us-ascii?Q?80X0bcxK66n0e6uer/afFOUqS/yI9sJPKNYhuFFWMlCCZJVMSCuFA5N0StyU?=
 =?us-ascii?Q?qqlVAy6SDFRyttfWmf+iaOUUlsVupVCyhIBVlZmZAXJV2mjjwKkHGvl53SnR?=
 =?us-ascii?Q?k1sZGk/DYRt4vfms80hehI/l1fX+hvFfG3Z71hynhIVv0+xiAw5Go+pLtShF?=
 =?us-ascii?Q?u25r5XjYCnk7FU2oGqRkch8TnYQycaF8oZe7QVqTTyV/YRQXE2ibSJAegIFP?=
 =?us-ascii?Q?cEAj6676kvK8uK8HPH1Wvul33oMweosYe5ImV/Bb9AHxiUac4R/thw38SsBv?=
 =?us-ascii?Q?DswFl44mZtcPz5dg1QaP47Ny8m7OMG9ABgcYJY1BrqWDzj0HyQJJiDm/Y7sJ?=
 =?us-ascii?Q?de3mJ8FivlpOevJD4yQC5pmAwv5rTguEsfjQueeFZl76w4QmbKaJn5N/1v4A?=
 =?us-ascii?Q?gmXcy6ZnzUItLmEekCF1gcf58xUkcaZMa/ksDg7tGbyfqjkr8a7VGwKmYtbp?=
 =?us-ascii?Q?wPEEzV2+0szGHbzBB7y5V3opbP2pB0q6BplNLR5C9tOQh719udCtWiXvDHo9?=
 =?us-ascii?Q?IY5zlQjLsAyLvDf9872E/JYC5Iu9CSK1vr+x6YjZYY3PRlKzB8J3JMyTjaS3?=
 =?us-ascii?Q?3MJtYlivWfetOVw7v2BV+Fg6/STv/w7nUz9f69VrIh9FcfK5icxDJaG1n7NR?=
 =?us-ascii?Q?DxS8mTGzmtd9e8VazO0hRkMVLX7OI3SGH7cZBxaj0b/t1QVg0oOnRIALvG3G?=
 =?us-ascii?Q?QjyTTRWOznmHlYUS9oKwoN8faiSNSoF/dA9a2n6LV0ibc8Yld94A9Q3aDF3j?=
 =?us-ascii?Q?c9hkb+ys/PxTrjf+9/AG3yhO6om6BQ1Ioow1iUQ0zI29M19fekWamB0sdP5o?=
 =?us-ascii?Q?JCBQwUATOIznpw8M82mafDLM+vDFBEhiNfdFBDYHTwDUcOTndC8X2vP93jO3?=
 =?us-ascii?Q?VE+w4YPOJP1rLS0ubZ7ij0+m6Z3CbP2qV6gQJK7osE7nf/L/nVRzRuu1TW69?=
 =?us-ascii?Q?Ag=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c595f64-5ae5-4664-9315-08da8430bc3b
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 11:23:27.9213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wiNT6ekiN3vhogKOjhxlWI5i2zHR3ppKLqg3cva/yEwILXakRR03w4aRdt95ad7cxBTVfvIq63Qj+Mp08dqfjhZZGPbJXq5VdRw2xr4p4Bw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2582
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Thu, Aug 18, 2022 at 11:00:03PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
For the QAT portion of this patch:
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

BTW, should the patch be split between qat and marvell/octeontx?

Regards,

-- 
Giovanni