Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     'Guanjun' <guanjun@linux.alibaba.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
CC:     "zelin.deng@linux.alibaba.com" <zelin.deng@linux.alibaba.com>,
        "xuchun.shang@linux.alibaba.com" <xuchun.shang@linux.alibaba.com>,
        "artie.ding@linux.alibaba.com" <artie.ding@linux.alibaba.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex)
 accelerator driver
Thread-Topic: [PATCH v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex)
 accelerator driver
Thread-Index: AQHYt6DIoYTZkmXG+US+1DA83fb3r62+IYQw
Date:   Wed, 24 Aug 2022 14:57:49 +0000
Message-ID: <MW5PR84MB184271E7C3085CB1004ED6A6AB739@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <1661334621-44413-1-git-send-email-guanjun@linux.alibaba.com>
 <1661334621-44413-2-git-send-email-guanjun@linux.alibaba.com>
In-Reply-To: <1661334621-44413-2-git-send-email-guanjun@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jrryLsnjGhgX6i16V2oF66pdF92WtJ7GDAc+zQf2cLtt9LjknV1uyPX1nKxZ?=
 =?us-ascii?Q?gGLjSztUuCeKGiEotGDChnCZiEs3QaD7A4aklyHKaX5Exn0Q9uYYsBk0QIpI?=
 =?us-ascii?Q?7khss27ZTUmp56epYUUzsyUFEBS8JPzOvrbBxJjPaSB79/QdrN15HOhX71IV?=
 =?us-ascii?Q?EYNKE8ca9XRKauPqST5dHMeEI7+oxQFb21djdN54byk1Lz/bNgXZIeebAK86?=
 =?us-ascii?Q?iWZP+wbkh4qP3ykkR9XA/m5psjU670HTwwNec1F0dwHSPWyUESnNMexVnzYB?=
 =?us-ascii?Q?dsib1JPcMvNLxM2zc6KuNin0aal83hQ0JO3dlTOkHiBgrlXH/woGy9WjPjz2?=
 =?us-ascii?Q?fXR7AIibC3rKIuFKXQH6SNk0bPFMjClg/vvOavAFUXFKd7F6BAPdPRcKebyh?=
 =?us-ascii?Q?iDnWDK0GMy+1HnCErtetDFCXguZKWKRc8WOnSN/+l726xh8Py+/RikKTSxCA?=
 =?us-ascii?Q?ip+td9AtRfKlt3FZkyCYWbpU3rGsLsUMGWsKzoFLDDZKc8zM6oCx95ol1WLv?=
 =?us-ascii?Q?LCHVJPo9j3YNVo+oYIg/3SZT4hZRwtFq0p+OUrtdfYOg9XRDIh3mvzgXoL3B?=
 =?us-ascii?Q?dkWYC/vTqlVjfUUNUjsLC6kdXRbGQtX3207wjBslzLPHg51ivZFnIvjiGYFU?=
 =?us-ascii?Q?pJ4eIfCmggI6bx0swPRCw+9msMCCdwLFPn8L9R2h1E4UFJ5Ku51K5sHR78nD?=
 =?us-ascii?Q?5g9oMZk0VtiQbh8WaXz9whFuo2R+vmGF2ULJ4H8qU9wkbEzioC8nvEODIiAN?=
 =?us-ascii?Q?7DbhBPYmwAJI+7GsG650VwjB/D/PyuVtVfFLwyQfTEs0NDLZlX5pIkLgAUZO?=
 =?us-ascii?Q?dP5fg+tw9JnVL+LbBabwq1ymF3Knkc49r3d2DXl4PBBKjtxkwbAeD9KbOchS?=
 =?us-ascii?Q?kbvc6bvLdkcNNkE7k+AGMFcCRa9s3LaT8XWBazhgqXnOL81nWrTJjYpq74fV?=
 =?us-ascii?Q?oxXTYbG58TRE5PSceRNOFbFamzqlriqxPSaJ+OF+uarNIKD0MIDL+WZsoS4O?=
 =?us-ascii?Q?Cpe4S5f+Xjlmkt2YMs8hGArUHe6YEOUxXfpjdX6v9NcJDdIbXyRBTLzpVe9w?=
 =?us-ascii?Q?//yLagWUhAD0CEu4TMEBWNjrF6BnCL5SzNJ/yc3sjMPy7ZhRSPeGK3dflJOm?=
 =?us-ascii?Q?zoE7AvjA1FcCC+mFUg0r7Oj4Pn3JYZ5yGRzgFQm8JFYZzOTug1JyszngZHea?=
 =?us-ascii?Q?snEazwaHw7sVcIOIZMRs3BIsxV27zD6B7evbsPHbv4RN0ETZLVM3OSsQ7M26?=
 =?us-ascii?Q?pcPWCvPI2rZVNCdSxOasE3CdUuEpcWU2aJA8wjRHHoIi6w78N281X1FF2NRN?=
 =?us-ascii?Q?TUkfjC5tYEvQc2o1bbaIy2mY2hCTphAbHldyQSA89mMQ/VIovqtUtr+KBJLU?=
 =?us-ascii?Q?bUjp465VEoxW15Yt7iqDHFA+1OWg4pyZLDZfkFzWzE9BLCnoK8VtEzej6AyV?=
 =?us-ascii?Q?oCACZ9ToAtwMDejWU62BjayRatl3oaxNkHgRwfB3+ndODFOyN2Z01DJ/1e3U?=
 =?us-ascii?Q?z/bFrhpAkA87CQw/YdiXxkw3xgKEEO6bJd2WmBe1Zcwk8wNzdpl4Us6VqDU3?=
 =?us-ascii?Q?nTm5RMz3Tqfpw/neOIs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 17e14311-7d89-4169-c3d0-08da85e1031f
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2022 14:57:49.2739
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IbRP8so/hcqTdgVVp46hHAsB8BHcXwKQo/VY6F7nmFWlvhivPEfq9kQxYF9R6iFB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB1680
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: 8Kn2qjEsHbhWPtVeIIqZ9XMd29S7RM7O
X-Proofpoint-ORIG-GUID: 8Kn2qjEsHbhWPtVeIIqZ9XMd29S7RM7O
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-24_08,2022-08-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011
 phishscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0
 spamscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208240057
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: 'Guanjun' <guanjun@linux.alibaba.com>
> Sent: Wednesday, August 24, 2022 4:50 AM
> To: herbert@gondor.apana.org.au
> Subject: [PATCH v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex)
> accelerator driver
>=20
...
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 3e6aa31..d739354 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -799,6 +799,8 @@ source "drivers/crypto/hisilicon/Kconfig"
>=20
>  source "drivers/crypto/amlogic/Kconfig"
>=20
> +source "drivers/crypto/ycc/Kconfig"
> +
>  config CRYPTO_DEV_SA2UL
>  	tristate "Support for TI security accelerator"
>  	depends on ARCH_K3 || COMPILE_TEST

This menu isn't perfectly sorted, but since the new entry is for
"Alibaba YCC", putting this at the top of the file would be
better positioned for eventual sorting.

Naming the directory alibaba/ rather than ycc/ might be more
welcoming for future drivers, too.

...
> diff --git a/drivers/crypto/ycc/Kconfig b/drivers/crypto/ycc/Kconfig
> +++ b/drivers/crypto/ycc/Kconfig
> @@ -0,0 +1,8 @@
> +config CRYPTO_DEV_YCC
> +	tristate "Support for Alibaba YCC cryptographic accelerator"
> +	depends on CRYPTO && CRYPTO_HW && PCI
> +	default n
> +	help
> +	  Enables the driver for the on-chip cryptographic accelerator of
> +	  Alibaba Yitian SoCs which is based on ARMv9 architecture.
> +	  If unsure say N.