Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     'Guanjun' <guanjun@linux.alibaba.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
CC:     "zelin.deng@linux.alibaba.com" <zelin.deng@linux.alibaba.com>,
        "xuchun.shang@linux.alibaba.com" <xuchun.shang@linux.alibaba.com>,
        "artie.ding@linux.alibaba.com" <artie.ding@linux.alibaba.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
Thread-Topic: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
Thread-Index: AQHYt592LeYGvN6dxkWzbHNUpEGlNa2+OPpw
Date:   Wed, 24 Aug 2022 16:24:35 +0000
Message-ID: <MW5PR84MB1842B41754897B029B6949E5AB739@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <1661334621-44413-1-git-send-email-guanjun@linux.alibaba.com>
 <1661334621-44413-6-git-send-email-guanjun@linux.alibaba.com>
In-Reply-To: <1661334621-44413-6-git-send-email-guanjun@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o6IVN6eAzggXqwdfMHKrvow2GbJtimMzWd3g/hdTG9QBJhROBr9kIPorlMcs?=
 =?us-ascii?Q?4qt14AVOf42Z751kvi/nvtJzK+W5RdWFIm3UixntnebfObI1ZSi/Wwexp3YO?=
 =?us-ascii?Q?bUnNVafYXkXhPE8I3TMWfYLKMTn779eNGOfYvFcshnU69inojJjrIxhj4lFw?=
 =?us-ascii?Q?zfMlVQBvPtPB7ggtQTilI6JikaPa7KpZCyhh+ic5AXbt7YHTA0d/Fnf1H+cf?=
 =?us-ascii?Q?OL3rn3fLMYPGorxJ0hBF2zk5wvm5oh5NmxwDZZWOZbAaxNQwZ3itenvrHkgE?=
 =?us-ascii?Q?SUOO6gJ4eGC5Z/zcCVqhvtRF0b/n/aRgADD4AsasYb8H2QLdmihXS5x47diG?=
 =?us-ascii?Q?0kOe4mZCQfaUiyg6x8BshZj7mbwIiHFRpL7fW9dQV831/pS2WOSIl/2Z9GzR?=
 =?us-ascii?Q?ewSFtzZMvlTcTzjLG4VbMuY9boNjlfEfv74dJEZEUjjT1IWI8jElQdyFQ/Nl?=
 =?us-ascii?Q?GB3ncgcpZ1mx3GgpkctcTVcdujixvRM/m4g+yb7ZrOJSZk9EFDIWd+cp6zJ3?=
 =?us-ascii?Q?8N//5sbINwHWQBrhyoEMwZe/I7VCJFJCOuhkiYXo8JZ9bfVwFpvxikSXkoGM?=
 =?us-ascii?Q?XBwFtBvi6pfNfhB79YyBhrBTCpliLKaqRcSECRXAt6tl8ZyknyU2clsHprBt?=
 =?us-ascii?Q?Z1zk1ilQjlIgruywbHOO/YdO68V5KBDoi4pr4UgWj8V4tcvF5eSj/JzzF7Zc?=
 =?us-ascii?Q?CJKRg0tLUmtCuiFOdrG47I9EWTzYF5bHwcarrMh0Wdn52AG3txICTvF8LH24?=
 =?us-ascii?Q?z7BMPiBQU6KZ9L0wMdzEzQqSgJbZ3cFnemDALFpTquGYVE6/3KFLTZBxHzmS?=
 =?us-ascii?Q?VWWk7lJkoewCCUgGZbCd9rRbiYUwcVOrGNLVGT5pBo7hTcdq5GAGsq4yXpEw?=
 =?us-ascii?Q?mFsSCwf6PmvisZDrTqnqaownmr+EAMNeS3lvtoNpL6T6epZs82rhwAVZo/jo?=
 =?us-ascii?Q?iL0gVrAISUbgZFl/R50i8OpkM84fCvKh0kmRjf5MjDxkZPr2QoZemIY7XH75?=
 =?us-ascii?Q?1H5GzMplzRzrzFyz//U9eypWPOtTHhVUoNMRbtV/1bykBhMz5ZNXfXwajNPR?=
 =?us-ascii?Q?aoSdJpqN1yIvy54Fkf+ILIc9SqSQwEdscuPhgeblrQfQIxwcsOH/TLL9DyQP?=
 =?us-ascii?Q?DiO7oF03te0SIzGuUvzi1M5JcMORCw6ckb2KFYmvWzQJ1YBKA5FtGpDegZn6?=
 =?us-ascii?Q?5l/a0Fqm5gbD2r4D9+ex1JRYikXEkR/jgZwFxxM2dMUOzKM2pepIH0/xDLi8?=
 =?us-ascii?Q?tdi7zB3Ogi+T928iwvsxbgUTD+DH7MPPT676Co3GnGPDgc7ONOe7h8pl0akR?=
 =?us-ascii?Q?2isZ+lMDRjuP3aWdr1PdLbNCPvhWC4A2DBwsQzDPZulAd1+n7I3T7QWLAoqi?=
 =?us-ascii?Q?hCf78V5K5KpKd41V9nAZPUGQTl5+cJmxoyC+kJFFvtkpwB1W0CjuRj6Wqv5P?=
 =?us-ascii?Q?kHG+dmYJjwhGEPaIW2MWkw2E3jXtf9fhbJS1BZtnxbpduE3IE+Q7wxy1Vkc5?=
 =?us-ascii?Q?llQpUamTJNHgAR1nqj2RuFv2ncXI2vSQAeMckVifu+ca3LXALerrFe+Q5hiV?=
 =?us-ascii?Q?1Cc7kz4l4gU3qP0Oplo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 742d481a-6c7b-4140-d99a-08da85ed2296
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2022 16:24:35.9933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DrX+z068LTJqxoZWrpxP3lLacCeDhhOF1HdT/7YDifihJ5e9ptUbzpxkobu3h4Fu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1716
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: z6TuYAqT4rigk7sxHR-QKHq9rS4GjaeA
X-Proofpoint-ORIG-GUID: z6TuYAqT4rigk7sxHR-QKHq9rS4GjaeA
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-24_09,2022-08-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0
 mlxlogscore=909 clxscore=1015 impostorscore=0 priorityscore=1501
 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208240061
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: 'Guanjun' <guanjun@linux.alibaba.com>
> Sent: Wednesday, August 24, 2022 4:50 AM
> Subject: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
>=20
...

> +static struct skcipher_alg ycc_skciphers[] =3D {
> +	{
> +		.base =3D {
> +			.cra_name =3D "cbc(aes)",
> +			.cra_driver_name =3D "ycc_cbc(aes)",

In comparison, the aead driver puts the hardware driver name as a suffix,
not a prefix, and uses dashes rather than underscores and parenthesis:
> +			.cra_name =3D "gcm(aes)",
> +			.cra_driver_name =3D "gcm-aes-ycc",

and the pk driver uses a prefix with a dash:
> +		.cra_name =3D "rsa",
> +		.cra_driver_name =3D "ycc-rsa",

Although the existing drivers are wildly inconsistent, it would be nice
if this driver was at least consistent with itself. Suffixes with dashes
seem to be the most popular, so consider these formats:
  cbc-aes-ycc
  gcm-aes-ycc
  rsa-ycc