Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f2dcc0c-99a2-8698-13ae-d5cbea9945b0@intel.com>
Date:   Wed, 24 Aug 2022 18:06:27 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH v5 07/12] x86/cpu/keylocker: Load an internal wrapping key
 at boot-time
Content-Language: en-CA
To:     Evan Green <evgreen@chromium.org>
CC:     <linux-crypto@vger.kernel.org>, <dm-devel@redhat.com>,
        <herbert@gondor.apana.org.au>, Eric Biggers <ebiggers@kernel.org>,
        "Ard Biesheuvel" <ardb@kernel.org>, <x86@kernel.org>,
        <luto@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>,
        <bp@suse.de>, <dave.hansen@linux.intel.com>, <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        <charishma1.gairuboyina@intel.com>,
        <kumar.n.dwarakanath@intel.com>, <ravi.v.shankar@intel.com>
References: <20220112211258.21115-1-chang.seok.bae@intel.com>
 <20220112211258.21115-8-chang.seok.bae@intel.com>
 <CAE=gft4P2iGJDiYJccZFR1VnNomQB7Uo522r2gvrfNY9oKz5jg@mail.gmail.com>
 <763bddd2-2fc3-a857-0dff-a5ae4ae1f298@intel.com>
 <CAE=gft5VajfoAT6hVxiCzAMYiDV+pHRbC-F7s4+qK94qa0og5w@mail.gmail.com>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <CAE=gft5VajfoAT6hVxiCzAMYiDV+pHRbC-F7s4+qK94qa0og5w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDF2cjNHSmhMNUV1eHo5RnR5dUlTNDBYZzRUUlRYQ1NIOTZHN1RJMnlFRDJ5?=
 =?utf-8?B?eTNQKzIxUVg0a2Z3bzlwUEgvNllUd3NvS1JLOElUd1Zhckc5M3pQT3IyNmFQ?=
 =?utf-8?B?dDhpSTkwaHE3QmtlZFlRT1JHV3h3czBnWUpIRmxCOW1wVDlNUUVYZzFueGZZ?=
 =?utf-8?B?VnMwZ2FoKzZ0SWhKR3p2T09LeENLMDRsUzNjcXBWZnBjUFJxZzFzYnRFRTVG?=
 =?utf-8?B?aUcycnZHS2VPTlk2aWQ0TEtEYVhZUkJCMWRGQ3RvVlBVRyt2NkVyS3ZxaVVt?=
 =?utf-8?B?QkUrSFY5VEluSFI4Yy8ySDdSUENFU2VoS3huaUc4aFVGU1dOc1RjZHRiOXgw?=
 =?utf-8?B?NFlvTDlXdXBjWEpvM2pkTzlSTjZaZ0tVUGlzNEFjZWpueE5IWXZJZXVQa0dH?=
 =?utf-8?B?SjIvT2tLK2JnT05JV1Q4bWZGNVNid05HUExKQXJ1MW03eVg3VjJBM2k2QjRX?=
 =?utf-8?B?K3c5bk1BeTlkak5jbUdjbUFoUHNBaEFyUlFHYU1kV0M5NnFDQXBtS1dQeUR2?=
 =?utf-8?B?eHZReG5KN0NLdTVFaHhpdVAxcXpROEdBNmhCaSt6MmMrYmR4SUxFNVBoejJk?=
 =?utf-8?B?Ti9NTU1lakI3aSsvWmdzYk8rbnQzNTZUZWZudnljRDN5MWo2bzhwRTd2ZWlK?=
 =?utf-8?B?MUVLdTgvVWJ4bUwzaGpnWE14b1loRVpyQ2NHNnhOTmZYMGZKU1dPYnJFZjMx?=
 =?utf-8?B?S3JESGcyN2FCV2NtZHhYMzJQTG1MYWlmR2VkUlZMWk41SG9XdmdRcWpUbmRr?=
 =?utf-8?B?RDcwRTF5U3d2ZVJXY1E4RGhEbEZLMUEvRU5Wb3dkOWpnSzFRWERqVW42Qmx2?=
 =?utf-8?B?ZzMzVDdqTmsrSjVrNUFIWmtQV0svN1JwNVVCeGdrOTU4czVzODNsQ3NwYUlT?=
 =?utf-8?B?RnlVcTQ1Wjh1SmEyT2oyNzA3YUpwblREdTlsSEZjWmZBM2FFT1BTZ2Y4UFhO?=
 =?utf-8?B?b3hXaUFQajRCdWFTMVpoekdHcDEwTVowa0VDZDYzRlBucXlEV3laRjZaT2pD?=
 =?utf-8?B?WG9pd2lTSG5mTHpIRzZOcVJHVHA1cDROdnUySXF3ajVrUG10MGV2M2s4WnJx?=
 =?utf-8?B?bnRHUkRRNnR1SExvSHZsUTAzdWU4M0NVSTI2cDFMcWpOTEZUT3NCRFROajNq?=
 =?utf-8?B?MXpZTGMrL0RXcGg3NCtwMG5jOUZ0YmZoZkh4RGhKK1c2Y1FQdit5aTgxSDRk?=
 =?utf-8?B?QlpYdUlHbk5ZTXBFZzFzd21QSVVacUY4Q2Rrc2NYSXZKWnlHeC9oNU9xZWFX?=
 =?utf-8?B?YkR3cHhWQXdrRDhmdVRKTk4vRWhuZDE1b1ZiM0p2K0tENktTeVBpVEMwdlUx?=
 =?utf-8?B?TVN1RFdwd1pTL2RkNmNUWXVLZmo2SWZlenF6dEd5OWtudnpWOStMdnlVSVFy?=
 =?utf-8?B?dWhNOUpyS1NpSUpqaXdrNS9iZ1kwSVhRbHcyckxNcUpwK0lFV1orRUZCcVpn?=
 =?utf-8?B?MFQ0UkZjZnVIUjZ6eCtRa3hzd3FiNkRXbmFOKzFFNUlHY3dwekd4U20xb2o0?=
 =?utf-8?B?dDFjaXBxWkVYdXpyNmFTRWRUUm8zWm8yTTFqUmlVZ1RqUW1TUE1HbU1kMnFn?=
 =?utf-8?B?ZEc1ZG8zbnp3RFl0NjJMTi9FQjNKNDVWanJSbDBDaDdrWkJNZEdHZGpxNlNR?=
 =?utf-8?B?YzFQcG9nS3FQUVRlM3JRQjRzQnEzYjRObzNOTDdibE9VQU53OU1QSzFqOFE2?=
 =?utf-8?B?U0dZSnJtcUE1ZWc4YlF1RDM1czByZG8wM2tkNDdxcHZUbjllRlY2MWdPWXhP?=
 =?utf-8?B?c0xuQVRmN1RpS0VBZklpeVhheW1OUlczdXUxa1AxQllPZTlGa25VTGJDcjNt?=
 =?utf-8?B?VmlXUlBTd3ppZTBDS3VQSmowUUtkRXgyTUNOdFlRQnVBcmNld1p6UkFsdE9V?=
 =?utf-8?B?V0dEUWdwYjhJV2ZlSWVVL216a0VOR3o4NXpLRmNGeWs0QUhKNlZBUVQzRktV?=
 =?utf-8?B?SjMvUlVDZjhpV3RLZ0ZuWkU4WFFCOGJjVkttczR0UHM1cVRhN3NQT0tTRmR3?=
 =?utf-8?B?Tmhzb2FuQ1VFcW5PN3hTd0luNDN0OXpyRlFHZlhkYSsyZThHMVlEOWVTTzEy?=
 =?utf-8?B?czBQOHY4OGRiNEJoSkpsWlRQMFprdU11dHA3Q1ZWTzQ2ZjdmWE4yVDdudzBo?=
 =?utf-8?B?eUgrYmtIaGpFZGlkSGtUK0RSWVRDc3hYWm5qZTlESm5GZ01nRmkwbzdtTEln?=
 =?utf-8?B?VlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f96f7b0-5bfa-4162-54d3-08da86360b53
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 01:06:30.4587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LeO/lCNBsW2YSUVizqURadh3IgDTmDdwJvI5uoM8dBvOAKupN0rC8+JyypexN2TrVaepwM57IwjGbkGpcAWQzcRyY3Bo3dgVNpYh7KxtLN0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5053
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 8/24/2022 3:52 PM, Evan Green wrote:
> 
> Whatever we ended up landing in the ChromeOS tree (which I think was
> v4 of this series) actively hit this bug in hibernation, which is how
> I found it. I couldn't get a full backtrace because the backtracing
> code tripped over itself as well for some reason. If the next patch in
> this series is different from what we landed in ChromeOS, then maybe
> your description is correct, but I haven't dug in to understand the
> delta.

So the change from v4 is simply dropping CBC mode. Marvin who reported 
another issue told me that he pushed the fix to some Chrome repository. 
But I don't know that's the same repo that you mentioned. Are you able 
to locate that tree if possible?

Also, it would be nice to have more detail about that hibernation bug.

Thanks,
Chang