Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 23:35:46 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Taehee Yoo <ap420073@gmail.com>
Cc:     linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
        davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, elliott@hpe.com
Subject: Re: [PATCH v2 2/3] crypto: aria-avx: add AES-NI/AVX/x86_64 assembler
 implementation of aria cipher
Message-ID: <Ywm7QrJqsil3XoKY@sol.localdomain>
References: <20220826053131.24792-1-ap420073@gmail.com>
 <20220826053131.24792-3-ap420073@gmail.com>
 <YwmFouIyIlOMqKb4@sol.localdomain>
 <d19470f9-7aa7-e4e2-5a45-bd8e2839e109@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d19470f9-7aa7-e4e2-5a45-bd8e2839e109@gmail.com>
Precedence: bulk

On Sat, Aug 27, 2022 at 03:30:55PM +0900, Taehee Yoo wrote:
> Hi Eric,
> Thanks for your review!
> 
> 2022. 8. 27. 오전 11:46에 Eric Biggers 이(가) 쓴 글:
> > On Fri, Aug 26, 2022 at 05:31:30AM +0000, Taehee Yoo wrote:
> >> +static struct skcipher_alg aria_algs[] = {
> >> +	{
> >> +		.base.cra_name		= "__ecb(aria)",
> >> +		.base.cra_driver_name	= "__ecb-aria-avx",
> >> +		.base.cra_priority	= 400,
> >> +		.base.cra_flags		= CRYPTO_ALG_INTERNAL,
> >> +		.base.cra_blocksize	= ARIA_BLOCK_SIZE,
> >> +		.base.cra_ctxsize	= sizeof(struct aria_ctx),
> >> +		.base.cra_module	= THIS_MODULE,
> >> +		.min_keysize		= ARIA_MIN_KEY_SIZE,
> >> +		.max_keysize		= ARIA_MAX_KEY_SIZE,
> >> +		.setkey			= aria_avx_set_key,
> >> +		.encrypt		= aria_avx_ecb_encrypt,
> >> +		.decrypt		= aria_avx_ecb_decrypt,
> >> +	}
> >> +};
> >
> > Why do you want ECB mode and nothing else?  At
> > https://lore.kernel.org/r/51ce6519-9f03-81b6-78b0-43c313705e74@gmail.com
> > you claimed that the use case for ARIA support in the kernel is kTLS.
> >
> > So you are using ECB mode in TLS?
> >
> 
> aria-ktls only uses GCM mode.
> So, ECB will not be used by ktls.
> 
> My plan is to implement the GCM aria-avx eventually.
> ECB implementation will be a basic block of aria-avx.
> I think it can be used by gcm(aria).
> So, I will implement gcm mode of aria with this implementation.
> 
> If this plan is not good, please let me know.
> If so, I will change my plan :)

GCM uses CTR mode, not ECB mode.

- Eric