Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 28 Aug 2022 06:35:24 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc:     David Howells <dhowells@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Ben Boeckel <me@benboeckel.net>,
        Randy Dunlap <rdunlap@infradead.org>,
        Malte Gell <malte.gell@gmx.de>,
        Varad Gautam <varad.gautam@suse.com>,
        Mimi Zohar <zohar@linux.ibm.com>, keyrings@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH v9,4/4] Documentation/admin-guide/module-signing.rst: add
 openssl command option example for CodeSign EKU
Message-ID: <YwrifCrlJceNG5He@kernel.org>
References: <20220825142314.8406-1-jlee@suse.com>
 <20220825142314.8406-5-jlee@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220825142314.8406-5-jlee@suse.com>
Precedence: bulk

On Thu, Aug 25, 2022 at 10:23:14PM +0800, Lee, Chun-Yi wrote:
> Add an openssl command option example for generating CodeSign extended
> key usage in X.509 when CONFIG_CHECK_CODESIGN_EKU is enabled.
> 
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> ---
>  Documentation/admin-guide/module-signing.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/admin-guide/module-signing.rst b/Documentation/admin-guide/module-signing.rst
> index 7d7c7c8a545c..ca3b8f19466c 100644
> --- a/Documentation/admin-guide/module-signing.rst
> +++ b/Documentation/admin-guide/module-signing.rst
> @@ -170,6 +170,12 @@ generate the public/private key files::
>  	   -config x509.genkey -outform PEM -out kernel_key.pem \
>  	   -keyout kernel_key.pem
>  
> +When ``CONFIG_CHECK_CODESIGN_EKU`` option is enabled, the following openssl
> +command option should be added where for generating CodeSign extended key usage

You have:

1. codeSign
2. CodeSign
3. CodeSigning

Why this ambiguity?

> +in X.509::
> +
> +        -addext "extendedKeyUsage=codeSigning"
> +
>  The full pathname for the resulting kernel_key.pem file can then be specified
>  in the ``CONFIG_MODULE_SIG_KEY`` option, and the certificate and key therein will
>  be used instead of an autogenerated keypair.
> -- 
> 2.26.2
> 

BR, Jarkko