Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Sun Ke <sunke32@huawei.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "joel@jms.id.au" <joel@jms.id.au>
CC:     "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] crypto: aspeed: fix return value check in
 aspeed_hace_probe()
Thread-Topic: [PATCH] crypto: aspeed: fix return value check in
 aspeed_hace_probe()
Thread-Index: AQHYvBzz+s4SK0W+PkG7juKv7paqKK3G0b0w
Date:   Tue, 30 Aug 2022 04:01:22 +0000
Message-ID: <TY2PR06MB3213B139F88D72C3EEED7A0780799@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <20220830031347.810217-1-sunke32@huawei.com>
In-Reply-To: <20220830031347.810217-1-sunke32@huawei.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rCb5mQA9B3A9l1P0FK0zIwRnloVWk9Zmn1ik7Z3QvEJwP10RRj/Ir7cvcMIp?=
 =?us-ascii?Q?Q9nTe02uu6+rUNQlVdrpnlPf+5SnfMnnp+WNYWJpr/PgugMnU+u2mw3GnLQa?=
 =?us-ascii?Q?eZxsn9SR2nKF+QNW0U9KEw6XLJeB0BkR/p0tuv+dYCqWUyCtizzyFPAWFSZ2?=
 =?us-ascii?Q?r/Ij7WEEGO1hKqyuKq0UGTsmC9blCt2rgg0accTtp78EABh5MmO/vbtHL9Hx?=
 =?us-ascii?Q?9l71jNUXmV2HWNJPG1ep+KlCdpIaNSCQ2OnrzSsrJhW2bUuq2WvE0jSOV/jv?=
 =?us-ascii?Q?8gA2f9u770s1JCKVORbShNfyRsMsvAY+ycVD74EV57SwJ+blt5yJemQp4/zM?=
 =?us-ascii?Q?Jrb0eNC+lZHV18IOs/3slt92/pd/NOapJ5H8hJ6/3Y73M1r+wbHxMjaG+Hrs?=
 =?us-ascii?Q?74XLHz+JFpYzHeBSk/0ZobuYB0N8PaFLUqx0eZjxvyeBOkoRGcHid+7HahOj?=
 =?us-ascii?Q?0pkvingFCeKoUFzNXJTFrm6mSEZijFSXR9wnygb3su4bpFSxZeMkP8hVCwoU?=
 =?us-ascii?Q?fTwC7ejWqUCD6p6ehU6RPznq+I+ib7+/nHbkV7VTkSHmrUCiYGY2iyJ5Tt4I?=
 =?us-ascii?Q?Ex3gQhxBbGj4HlzPwiZX7XwTwuEkgQOwTNvEUrhZIZS1RUJ4pC+2upNWWPN8?=
 =?us-ascii?Q?3ITLODD/RStwx4KiOJVZyeMP2lVUOTnDUUTIWAJekGZdsng7ucaEsvEydJ4N?=
 =?us-ascii?Q?hHHUDTKbqjbU2/7So7Y2BcqA+s0A/L0lypJaVBxU8Q3RzEMIOK2626LqENZP?=
 =?us-ascii?Q?BbTfZEq6iFYUp7YkEcn7TtagsEmWM/kV/abhAzQCXvvRun7biVtOBDnERBaC?=
 =?us-ascii?Q?cJ88jYQ1PTKb/QO3r9tiXydS+lvARFjkrNSZn+N9spjawmSnOTsP44dr4RVg?=
 =?us-ascii?Q?Wz3nqq0MOHKHRE3bInhieHkxHVjq2C5CzMGtwOrs0TBmjxfcW0QYM5msW/4F?=
 =?us-ascii?Q?OOP97uCA3LJfCM7TrCe7DhMvHvp3E3FkHAFVKFhqAfFiyccuRCZ03PECrbLI?=
 =?us-ascii?Q?joVLnG/L6wHTKWIQOf2LMTk0JRWEb8zsFho1PQK8vX1LpocTXxy4GaaeHI/l?=
 =?us-ascii?Q?FtNyNvtU9GKXJ+dXQeYM20KAgqRXxqjDkZxo9bodeMxrfIjHlWQDjNEwWX1R?=
 =?us-ascii?Q?zKkRuvS7d853U1Wopk8u+VGCumKYAlJMydugQ29GEiTE3w25/rejC3NkRsv9?=
 =?us-ascii?Q?8WN8NW/c7l2xtQ7UdVp9Sa7p3z30908ZhNIU+cWipa6Vz9R2Phd1JvjiLL7t?=
 =?us-ascii?Q?qJfCdQ/msvhmE/B4NOLSijkMcZGFYPVWCz207UmGYgDXOzE3ihbxTt4u25hW?=
 =?us-ascii?Q?CVnQCdq1vrOvOVXza1d0Umh4Md/TP9tla/kZJ4vViA2kYAL2EIZZXdbvt7MD?=
 =?us-ascii?Q?QOhc2RlljzHG8hlfCokCfBn6sBwhPDQ1r5b4H6d6L0rdxLhYXkypXlii667+?=
 =?us-ascii?Q?PNNcNEqNtu778G5282Xp40ovzdgj7Z+RZqsPWc9vcUrtSdLkhOrxDptMj+CU?=
 =?us-ascii?Q?Ax/2kNKVPxkr3hn6WIXMp4Ww7sXgLTS250ikYfMQn0jb9VJs1POut5sZal9N?=
 =?us-ascii?Q?LgdGGd0zl/GB+l2rqmW7aaSK+nJ1yb3o7OymcPW1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62b67c13-bdca-4d32-43bc-08da8a3c4d7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 04:01:22.8381
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lifj2HHsEEdg3iJdObD9+Q8YDeU54lve2fwvtyrcFKxtMyrn4i8zu7E0T4GfwI/rrZmZc0gUZSTu0OInHDmHYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4355
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: Sun Ke <sunke32@huawei.com>
> Sent: Tuesday, August 30, 2022 11:14 AM
> To: Neal Liu <neal_liu@aspeedtech.com>; herbert@gondor.apana.org.au;
> davem@davemloft.net; joel@jms.id.au
> Cc: linux-aspeed@lists.ozlabs.org; linux-crypto@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; kernel-janitors@vger.kernel.org;
> sunke32@huawei.com
> Subject: [PATCH] crypto: aspeed: fix return value check in aspeed_hace_pr=
obe()
>=20
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() not NULL. The NULL test in the return value check must be repla=
ced
> with IS_ERR().
>=20
> Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver")
> Signed-off-by: Sun Ke <sunke32@huawei.com>

Thanks for the fix.
Reviewed-by: Neal Liu<neal_liu@aspeedtech.com>

> ---
>  drivers/crypto/aspeed/aspeed-hace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> b/drivers/crypto/aspeed/aspeed-hace.c
> index 4fefc9e69d72..3f880aafb6a2 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.c
> +++ b/drivers/crypto/aspeed/aspeed-hace.c
> @@ -123,9 +123,9 @@ static int aspeed_hace_probe(struct platform_device
> *pdev)
>  	platform_set_drvdata(pdev, hace_dev);
>=20
>  	hace_dev->regs =3D devm_ioremap_resource(&pdev->dev, res);
> -	if (!hace_dev->regs) {
> +	if (IS_ERR(hace_dev->regs)) {
>  		dev_err(&pdev->dev, "Failed to map resources\n");
> -		return -ENOMEM;
> +		return PTR_ERR(hace_dev->regs);
>  	}
>=20
>  	/* Get irq number and register it */
> --
> 2.31.1