Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ec9cdab-db5b-ab28-c92d-79c3812dd369@intel.com>
Date:   Tue, 30 Aug 2022 07:25:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: Should Linux set the new constant-time mode CPU flags?
Content-Language: en-US
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Eric Biggers <ebiggers@kernel.org>
Cc:     x86@kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        Adam Langley <agl@google.com>, Ard Biesheuvel <ardb@kernel.org>
References: <YwgCrqutxmX0W72r@gmail.com> <Ywzr2d52ixYXUDWR@zx2c4.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <Ywzr2d52ixYXUDWR@zx2c4.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/29/22 09:39, Jason A. Donenfeld wrote:
> On Thu, Aug 25, 2022 at 11:15:58PM +0000, Eric Biggers wrote:
>> I'm wondering if people are aware of this issue, and whether anyone has any
>> thoughts on whether/where the kernel should be setting these new CPU flags.
>> There don't appear to have been any prior discussions about this.  (Thanks to
> Maybe it should be set unconditionally now, until we figure out how to
> make it more granular.

Personally, I'm in this camp as well.  Let's be safe and set it by
default.  There's also this tidbit in the Intel docs (and chopping out a
bunch of the noise):

	(On) processors based on microarchitectures before Ice Lake ...
	the instructions listed here operate as if DOITM is enabled.

IOW, setting DOITM=0 isn't going back to the stone age.  At worst, I'd
guess that you're giving up some optimization that only shows up in very
recent CPUs in the first place.

If folks want DOITM=1 on their snazzy new CPUs, then they came come with
performance data to demonstrate the gain they'll get from adding kernel
code to get DOITM=1.  There are a range of ways we could handle it, all
the way from adding a command-line parameter to per-task management.

Anybody disagree?