Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
From:   guanjun <guanjun@linux.alibaba.com>
In-Reply-To: <MW5PR84MB1842B41754897B029B6949E5AB739@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Wed, 31 Aug 2022 10:52:34 +0800
Cc:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "zelin.deng@linux.alibaba.com" <zelin.deng@linux.alibaba.com>,
        "xuchun.shang@linux.alibaba.com" <xuchun.shang@linux.alibaba.com>,
        "artie.ding@linux.alibaba.com" <artie.ding@linux.alibaba.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <037A82F1-7C15-44E2-96B9-57CFEC936D38@linux.alibaba.com>
References: <1661334621-44413-1-git-send-email-guanjun@linux.alibaba.com>
 <1661334621-44413-6-git-send-email-guanjun@linux.alibaba.com>
 <MW5PR84MB1842B41754897B029B6949E5AB739@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
To:     "Elliott, Robert (Servers)" <elliott@hpe.com>
Precedence: bulk

Hi Elliott,

> 2022年8月25日 上午12:24，Elliott, Robert (Servers) <elliott@hpe.com> 写道：
> 
> 
> 
>> -----Original Message-----
>> From: 'Guanjun' <guanjun@linux.alibaba.com>
>> Sent: Wednesday, August 24, 2022 4:50 AM
>> Subject: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
>> 
> ...
> 
>> +static struct skcipher_alg ycc_skciphers[] = {
>> +	{
>> +		.base = {
>> +			.cra_name = "cbc(aes)",
>> +			.cra_driver_name = "ycc_cbc(aes)",
> 
> In comparison, the aead driver puts the hardware driver name as a suffix,
> not a prefix, and uses dashes rather than underscores and parenthesis:
>> +			.cra_name = "gcm(aes)",
>> +			.cra_driver_name = "gcm-aes-ycc",
> 
> and the pk driver uses a prefix with a dash:
>> +		.cra_name = "rsa",
>> +		.cra_driver_name = "ycc-rsa",
> 
> Although the existing drivers are wildly inconsistent, it would be nice
> if this driver was at least consistent with itself. Suffixes with dashes
> seem to be the most popular, so consider these formats:
>  cbc-aes-ycc
>  gcm-aes-ycc
>  rsa-ycc
> 


Thanks for your comments. I will change these names as your suggestion in next version.

Best regards,
Guanjun