Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 09:18:18 -0700
From:   Breno Leitao <leitao@debian.org>
To:     cgel.zte@gmail.com
Cc:     nayna@linux.ibm.com, pfsmorigo@gmail.com, mpe@ellerman.id.au,
        npiggin@gmail.com, christophe.leroy@csgroup.eu,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org,
        Jinpeng Cui <cui.jinpeng2@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] crypto: nx: remove redundant variable rc
Message-ID: <Yw+JysFvbmW0yJL8@gmail.com>
References: <20220831140248.303940-1-cui.jinpeng2@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220831140248.303940-1-cui.jinpeng2@zte.com.cn>
Precedence: bulk

On Wed, Aug 31, 2022 at 02:02:48PM +0000, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> Return value directly from set_msg_len() instead of
> getting value from redundant variable rc.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Reviewed-by: Breno Leitao <leitao@debian.org>

> ---
>  drivers/crypto/nx/nx-aes-ccm.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c
> index 3793885f928d..c843f4c6f684 100644
> --- a/drivers/crypto/nx/nx-aes-ccm.c
> +++ b/drivers/crypto/nx/nx-aes-ccm.c
> @@ -134,7 +134,6 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
>  		       unsigned int cryptlen, u8 *b0)
>  {
>  	unsigned int l, lp, m = authsize;
> -	int rc;
>  
>  	memcpy(b0, iv, 16);
>  
> @@ -148,9 +147,7 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
>  	if (assoclen)
>  		*b0 |= 64;
>  
> -	rc = set_msg_len(b0 + 16 - l, cryptlen, l);
> -
> -	return rc;
> +	return set_msg_len(b0 + 16 - l, cryptlen, l);
>  }
>  
>  static int generate_pat(u8                   *iv,
> -- 
> 2.25.1
>