Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp659387rwe; Thu, 1 Sep 2022 05:58:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR5DIHRql1waUeEHl5KjIzXm0qQAlQH/9dMG6qSLJdlyEO6bV2g08B3jPYlT9njPyj3juj7f X-Received: by 2002:a17:90b:19d8:b0:1fb:c116:a1e8 with SMTP id nm24-20020a17090b19d800b001fbc116a1e8mr8456785pjb.109.1662037116692; Thu, 01 Sep 2022 05:58:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662037116; cv=none; d=google.com; s=arc-20160816; b=cC8gnt754HFFTQkZxSFleSDccElyjuziq7Ev9p3NBnaGTcv7y2DTsGlaXqAiEueEv8 Sh8SBI+dlQdH9laQUM+FVl7T4kfSb8jXyJ1jeAL/vgqqMv5dAu995+KqJmTknleHs8RR Q+5WYGY+3BP6u2O6q/pcCRBu5LTR238tpsZKseVFQg8XIFUjLKLNZ9Fb5pmSoM0FGMV/ YCNGC4ad7szBRmS3uvg8C3f+TdUXU6cJMePP1eD2a2HfaYBelBwEo6XkVYIbtxwmIcTK NJHdkguOcBZL9sxu0lagpDrOluPVtoJbWXyohoiB1iV90pE+92LXphDqZAbhI/PRPGpV 5dPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2nwWkT4441Zvq5igIAOKA8C0HAjPPXDmTRADPlAyhok=; b=SFYTAoYU/wo+8UDELscj0fMHs0U7c785J3T/l9uToQXxA2OBoNTM5Aj7bFTF5Ymu53 up0Us+f93z4kvaVLyH4xibN6fQhufaB1y93+bbALQ+Ih0UAfa8+oY8mcYdZQCrRJjaMr 78M9+zGzrmYOJPd5NEDyZirqFM4ELHpUyv7dkSCW2TFCx13ClqQKitEhqLttL6wwEeCm 3Cs+G5qX5ICc8fYNysDKFz+bP8nACSjtWU9AlbakJM4fgVLdZbOfMIQ1l+Ndcjgj7T9Q 1tUWwOB8hCMKY8+mvnKptkrTUCTkI5Ef/7sR1FIlmd5oBcW5NA76v9i4mcnzuWsibzuD iWSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b="basRl/C6"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n3-20020aa79043000000b005303194bf1bsi17171226pfo.111.2022.09.01.05.58.16; Thu, 01 Sep 2022 05:58:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b="basRl/C6"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233545AbiIAM5Z (ORCPT + 99 others); Thu, 1 Sep 2022 08:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233392AbiIAM5X (ORCPT ); Thu, 1 Sep 2022 08:57:23 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6170061702 for ; Thu, 1 Sep 2022 05:57:19 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id v16so19520280wrm.8 for ; Thu, 01 Sep 2022 05:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=2nwWkT4441Zvq5igIAOKA8C0HAjPPXDmTRADPlAyhok=; b=basRl/C6QptrvQbTpk+LkAHZh/MQJacL+ZAGvkDnh7vGFvFVx3cZ7eoHvSXNXOEMVW A4/IH1a11cZI4vc/n4x/VucSGHK99YV85DWyCtXisj+J/mQ6xmVjDBUuHl/Kco27tSwI nqblv1KDC35mISIbMzGoWcfd96GO8QAzNAwZg0QExhm6WokwnnSBXXpqXkhFPx1ekAfG fcqmxQdL3+pJETQVLfLTg76nse9tFnjPYwwdXKyxU0pZne2j5YF/m22/3GUTt/+uLpBl MyenoYaM3m+G+t6Nkho53sd12AD2vB8eOCRsV0hceISDDgdaEDPogkiYeqSNAODuzdbo aalA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=2nwWkT4441Zvq5igIAOKA8C0HAjPPXDmTRADPlAyhok=; b=j7X+/HCCoIQ7CqnwEYA1Keq2/BTOFx33bVHLAbfpyxpyCgK7QmHwyTojHpnPD5g7pO B3fuPOt3cwha7dKa66VEV/xHw7BhYywwL8T+lNIWS8QRRRDuTuS5Wk1lP3W5rRjLWRsf Vomeg436vKk8k0EsqbEwZz0lpe045tBonRoLhqZ8GNNIBlXCpYy9yHuQYlFDGv97+gIA DeYMLP2YSDmq9s6r3ibhyzseRBL31CpeamAa0JcA4va1m6Z9lTmzaluwvlQ7PnUOZ6mY QUUIZf7cP4cVoU39Ra8B13uGEijikFH26TjoDYpUEiG6l1c+wCoHNDy/iiNuIHDKMTI9 J/Hw== X-Gm-Message-State: ACgBeo3rSKBCWMK0rWv4Fgt2GFwNNhUTfZDeEn4Hv0pngUCT+gigy3u3 1sb5a3koaLXxXlISUtnCFSPjgg== X-Received: by 2002:a5d:6b09:0:b0:225:37cf:fb8b with SMTP id v9-20020a5d6b09000000b0022537cffb8bmr14603530wrw.179.1662037037975; Thu, 01 Sep 2022 05:57:17 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id v5-20020a5d59c5000000b002257fd37877sm15556709wry.6.2022.09.01.05.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 05:57:17 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, ardb@kernel.org, davem@davemloft.net, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Corentin Labbe , John Keeping Subject: [PATCH v9 01/33] crypto: rockchip: use dev_err for error message about interrupt Date: Thu, 1 Sep 2022 12:56:38 +0000 Message-Id: <20220901125710.3733083-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220901125710.3733083-1-clabbe@baylibre.com> References: <20220901125710.3733083-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Interrupt is mandatory so the message should be printed as error. Reviewed-by: John Keeping Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 35d73061d156..45cc5f766788 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -371,8 +371,7 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_warn(crypto_info->dev, - "control Interrupt is not available.\n"); + dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; } -- 2.35.1