Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a15ab3e6-249d-af48-b4d5-25840b72a933@amd.com>
Date:   Thu, 1 Sep 2022 08:42:31 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2] crypto: ccp - Release dma channels before dmaengine
 unrgister
Content-Language: en-US
To:     Koba Ko <koba.ko@canonical.com>, John Allen <john.allen@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220901021628.1130985-1-koba.ko@canonical.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20220901021628.1130985-1-koba.ko@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3NIZGxSdUhUSjlGcy9TdGRmS2RGS1cwcFFyRkxMeG5BeDBnamIrMjljclZw?=
 =?utf-8?B?YmE0K24wSU5GRjZiaC8rK242Q3hPWVg4MlYybVM1d3VMYVZxVEovaHNiVnh5?=
 =?utf-8?B?MTA0L1djWHBsSFdNMTBUc205NGhSU3NGa2FNRWVOQ1E2eTd5RVZFaGV2SzdE?=
 =?utf-8?B?OFBhQml0VlhOVTVobjQ4SlJzaW1VQWg4L1JRSnhLS1JXeU9LSFFpRVVvaHRL?=
 =?utf-8?B?RlluTktQTks3aVc0RklMeE4ybyszQWt1Q2tYdHRCVFlrNUtvZktGcnZ1Wmlz?=
 =?utf-8?B?WHhNeFlqbzZhT2I1Wk1zK2U2ODA0QzlEQzdSQktUYzlYVldZTjVYRVZmcTFa?=
 =?utf-8?B?ZFptQlkrNmRxa2tiMmU3Vno4ME90aG9rV0luSlZwbHZjUXkxVFBBS1lDVGo3?=
 =?utf-8?B?SDYvV3pqazdnMDRkOVFZVlRLVTJGQTF2bkx1QTlhdTdRVG12eEtmc1NmekJz?=
 =?utf-8?B?K1pWeC8wTGl0eEdHaGtBbWJxMVh1eFFnc1BlZ3U3ZTBEL2k5MmIvV3ZsRUxN?=
 =?utf-8?B?MW1rNyt6dXo5ODlEUGdtcGtySEJ6eGU5NTZNNEEyekZBVVRtSDdZSFUvNjM2?=
 =?utf-8?B?dzlLYWxaU04zL280M1RPb21WQ1dZUVZ1Uk5pR2taWjIrRmpVWmgzbWtRMitO?=
 =?utf-8?B?T2drbmlWRE9FWlB4MWhKMzBqVEYxYU1pOUtSMzhKL3g5RmhHdEpHVEFlSlBW?=
 =?utf-8?B?Z0lMUVcxcU1vMFBnY2dsRkhMOEVyMnkvaTMyL3JRUVFNbVVXSzJIdTVKNTZh?=
 =?utf-8?B?VUNsQktVVGJlcHY3RVhiZ0R1NzRuUnZMQnZneHZ6QkszRXQ1eFczVm5ENVhi?=
 =?utf-8?B?MlZZMVVnZVNPWXRnWThlREdPb0c3ZUNQMWxJaGNuQndhU1kwVk11Q0Y4TEdk?=
 =?utf-8?B?ZWY2UmdENEpyOFBjRFdLd2t2T2FjY0toT2dUeDd3NG5KN0M2SWdhbWl4Mzhu?=
 =?utf-8?B?ZHA5aU91QXBjc3hoYXZHU2RJcEtpTEpQbXFVUXNIQmIrRHgxanJjOXBHU2FY?=
 =?utf-8?B?ME0vZnp1RC9VeS9lV3oxWmlCNVhTYXBVaXVSZnVtYjFQeUVuRkFoWURrajQ5?=
 =?utf-8?B?L00yWW1TVklEbVFZeHlOT1BYYU4rYTdzNmdXT0JBMmdIekV4eThaTnhkcEc0?=
 =?utf-8?B?WWFCOEFtTktYcTFpdnl6Z1RmamNaZXZwTWtCL09USXJTTnZHekNFbzZlMHVG?=
 =?utf-8?B?T2tRZ252RHByODk0bUJhRzduaWNLVFI5eFFlOXNNaVRtNGJSYyt1d2ZHOS9j?=
 =?utf-8?B?Rk9kcXBMZWJGL3RmQ1Jwc25KQTFad2FwRzlOdGR2K3lXa1FNUW9RUmUvSVlS?=
 =?utf-8?B?Vi9PSk9UVWprVUtYNjdVQklOZFR4WC9ST3hFcmVBS0wyN2JLRWhCamdOZzZS?=
 =?utf-8?B?dk9ITDVBOS9ZWjM3UWoxOUFIZHJJb2NUcDF3QkdGVXBLVWxCeWJLdFFqd3py?=
 =?utf-8?B?WnlKZ282bnZWT1YzRWpkaHFNWi96QnVrWFFNdFVYNW1YdnJjcS8xNEpTRmVz?=
 =?utf-8?B?QkR4bU1UZi9zbVNGbTB4NUdoR0RkNC9kMU9RQVFEUTFEc050amdWTElDYUlz?=
 =?utf-8?B?SkYya25udTd0cjRtVlFSMzZuS1dnSmtBMnZxUG0yMjVMWExPZk5PQzg2eUZr?=
 =?utf-8?B?bEs3a3lJTGZNb3orVlNvamppb2FmK2w5Z1F1NDhzM1BKY0JKSTdoaFhvcFpi?=
 =?utf-8?B?aUtWRVh4WEQyUHdHeFh3NStOcmlweVE5enNvNG9SMTZCQ0hNSC94c05USGtS?=
 =?utf-8?B?UEdpR1FFYzlVM3MxZHlFREorTzlDSmRTTnk1TTJDZlFZd25HYXl4MVdnWE84?=
 =?utf-8?B?RVpVWTFXc29CdTVKcUxMT1pVdWtmRkZtK2xDSmtzV2hoeDlwWTZrV2w1aGpv?=
 =?utf-8?B?SnN5M21ENWZSWkQwWTVFVjFaMExKL3g4SmZSMWU5di9sc3E2bGNjcEpxS2Jl?=
 =?utf-8?B?czNiWG5Eb2w2Q3ZrNU1USy9TVUxDMkhOSCtqdjR2UmlYazBBeDhqaXE3VUVB?=
 =?utf-8?B?TnR3WitYNEFlZlA3QTE2NjY3MDdJd3BQUHErd3Q2U1VQdk9LN2RUQmRCVFho?=
 =?utf-8?B?SEdaOE13NWF5S1pXTE00VHNjTmZkS3Fid2N3VTZkM1lLcFFOR2V0ZWFwdlBT?=
 =?utf-8?Q?C8pTdsiqZKHcu2c5I3zeuW5/4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee78bd8e-1bb7-4817-8994-08da8c1fd2da
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 13:42:33.7945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 74fXldM0xgNtU5/bcAmD5/Mjs3T6aEnxM4Mi4SZDeMvMwqdo6OtYsEwcHoT8x2sYh3PT1zz1KyW8fQiyCa8yNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6464
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 8/31/22 21:16, Koba Ko wrote:
> A warning is shown during shutdown,
> 
> __dma_async_device_channel_unregister called while 2 clients hold a reference
> WARNING: CPU: 15 PID: 1 at drivers/dma/dmaengine.c:1110 __dma_async_device_channel_unregister+0xb7/0xc0
> 
> Call dma_release_channel for occupied channles before dma_async_device_unregister.
> 
> Fixes: 4cbe9bc34ed0 ("crypto: ccp - ccp_dmaengine_unregister release dma channels")

I can't find this Fixes: tag. I did find:

54cce8ecb925 ("crypto: ccp - ccp_dmaengine_unregister release dma channels")

Not sure if Herbert can take care of that or if you'll need a v3.

With the change to the Fixes: tag

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Koba Ko <koba.ko@canonical.com>
> ---
> V2: Fix the unused warning
> ---
>   drivers/crypto/ccp/ccp-dmaengine.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index 7d4b4ad1db1f3..9f753cb4f5f18 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -641,6 +641,10 @@ static void ccp_dma_release(struct ccp_device *ccp)
>   	for (i = 0; i < ccp->cmd_q_count; i++) {
>   		chan = ccp->ccp_dma_chan + i;
>   		dma_chan = &chan->dma_chan;
> +
> +		if (dma_chan->client_count)
> +			dma_release_channel(dma_chan);
> +
>   		tasklet_kill(&chan->cleanup_tasklet);
>   		list_del_rcu(&dma_chan->device_node);
>   	}
> @@ -766,8 +770,8 @@ void ccp_dmaengine_unregister(struct ccp_device *ccp)
>   	if (!dmaengine)
>   		return;
>   
> -	dma_async_device_unregister(dma_dev);
>   	ccp_dma_release(ccp);
> +	dma_async_device_unregister(dma_dev);
>   
>   	kmem_cache_destroy(ccp->dma_desc_cache);
>   	kmem_cache_destroy(ccp->dma_cmd_cache);