Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 20:09:51 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Kai Ye <yekai13@huawei.com>, herbert@gondor.apana.org.au,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        wangzhou1@hisilicon.com, liulongfang@huawei.com
Subject: Re: [PATCH v7 2/3] Documentation: add a isolation strategy sysfs
 node for uacce
Message-ID: <YxD1byMGE03R8YWT@kroah.com>
References: <20220806022943.47292-1-yekai13@huawei.com>
 <20220806022943.47292-3-yekai13@huawei.com>
 <YxDJ6PEWd/3c1jPd@kroah.com>
 <YxDlOFYih5tQ37Av@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxDlOFYih5tQ37Av@sol.localdomain>
Precedence: bulk

On Thu, Sep 01, 2022 at 10:00:40AM -0700, Eric Biggers wrote:
> On Thu, Sep 01, 2022 at 05:04:08PM +0200, Greg KH wrote:
> > On Sat, Aug 06, 2022 at 10:29:42AM +0800, Kai Ye wrote:
> > > Update documentation describing sysfs node that could help to
> > > configure isolation strategy for users in the user space. And
> > > describing sysfs node that could read the device isolated state.
> > > 
> > > Signed-off-by: Kai Ye <yekai13@huawei.com>
> > > ---
> > >  Documentation/ABI/testing/sysfs-driver-uacce | 26 ++++++++++++++++++++
> > >  1 file changed, 26 insertions(+)
> > > 
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce
> > > index 08f2591138af..e09fd160d3fa 100644
> > > --- a/Documentation/ABI/testing/sysfs-driver-uacce
> > > +++ b/Documentation/ABI/testing/sysfs-driver-uacce
> > > @@ -19,6 +19,32 @@ Contact:        linux-accelerators@lists.ozlabs.org
> > >  Description:    Available instances left of the device
> > >                  Return -ENODEV if uacce_ops get_available_instances is not provided
> > >  
> > > +What:           /sys/class/uacce/<dev_name>/isolate_strategy
> > > +Date:           Jul 2022
> > 
> > July was a while ago, you sent this patch in August :(
> > 
> 
> Does the date in the sysfs documentation files serve any purpose besides making
> people have to update their patchsets every month?
> 
> The kernel version number would be more useful to readers of the documentation,
> and it wouldn't have to be updated quite as often.

True, I have seen people use that instead, or no date at all, I don't
require it.  But if you do put the field in there, it should at least be
correct :)

thanks,

greg k-h