Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1765136rwe; Fri, 2 Sep 2022 03:33:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR62Y9fbQfmMDJ7p6tTHB82ch/7K9LmSSuEuPI3gtikAu5TKh50lJdrW3GaRrjLD6upjtyX6 X-Received: by 2002:a05:6402:f0a:b0:449:6181:e1b3 with SMTP id i10-20020a0564020f0a00b004496181e1b3mr8201750eda.241.1662114797005; Fri, 02 Sep 2022 03:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662114797; cv=none; d=google.com; s=arc-20160816; b=rzanNhnDSKiAHn0ayN6UEHyVajO0EMSSEi5wvrFumsS09B2yP96NMQB4HJKvuvJXKb CPG5gRyFqfL7s80/Bphg5GWLgqrFsGtRsMMlDrD705Y7+bVmivG1hK9fVvuS8ABw+MzW qd6B6csYVb7mJ5pSW72+nc51Y6Z3wztrEuBcog5jMiAnr0NLMwMunmceB7vndtTPzmzk Oq9Vb6UVZ47hECe4lo1sHDgyqawrXOHrgaNAMG8ZGRZD7MlmJRsvfMq3QmX0AB04kOf1 ZB+xQnSejU+nta99yD4296WlZqff22rW4zEOcmsRLuWINAoVz9UKGjPVJCxaLQVb1LIs 2KXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wjsVClF/yH7Pso7ODJIztks639Bw22lNAK9Keww8XbU=; b=W3GE8qEqK58BMgrlWiOk0EFjycAvj7zsQhenKQBMXfOUBnimzZHpnkvlPQoLELqreQ Ya29NXvDB6osu2g++XJ5dqeDzF4rDjf3ByNHXYC2Pws7bvnnvXwLX9OsoKuxihcsS1hU vFwhV+tB9hEH/OOupc961fAlnp+T40Pdu753N2V2UECD7m5bVagtdK6iatq05gj8+rLA zuy/VaXcJ4rTEV8uGdpGR4jo+zHcnU1vGf3Ht/kc5iScP6qj+sfSQwodGQ5wYMiOJE8h 2GI+fbMPZpa/xEAzoNjTfgPUfa6xN1Qn/wo5kOgjv/bqIBnUTSP4c0E23Cfrzv1/wA2h Jrbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a22-20020aa7d756000000b0044660f40ed5si1420558eds.256.2022.09.02.03.32.52; Fri, 02 Sep 2022 03:33:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235758AbiIBKXW (ORCPT + 99 others); Fri, 2 Sep 2022 06:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbiIBKXW (ORCPT ); Fri, 2 Sep 2022 06:23:22 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA78BA5725; Fri, 2 Sep 2022 03:23:20 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oU3pT-000KkZ-Ek; Fri, 02 Sep 2022 20:23:16 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Sep 2022 18:23:15 +0800 Date: Fri, 2 Sep 2022 18:23:15 +0800 From: Herbert Xu To: cuigaosheng Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select Message-ID: References: <20220825084138.1881954-1-cuigaosheng1@huawei.com> <20220825084138.1881954-3-cuigaosheng1@huawei.com> <35ec0aed-ee54-b6ea-1d34-06839b20befb@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <35ec0aed-ee54-b6ea-1d34-06839b20befb@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Aug 25, 2022 at 08:55:12PM +0800, cuigaosheng wrote: > Thanks for your reply. > > While I was debugging the kernel code of linux-next, I start the kernel > with qemu-system-arm with following commands: > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- vexpress_defconfig > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- -j32 > qemu-system-arm -M vexpress-a9 -m 1024M -s -nographic -kernel arch/arm/boot/zImage \ >   -dtb arch/arm/boot/dts/vexpress-v2p-ca9.dtb -sd /home/rootfs.sd \ >  -append "root=/dev/mmcblk0 rw console=ttyAMA0" > > But it failed, so I tried to locate the cause of the failure and finally found that > it failed from this patch(cad439fc040e crypto: api - Do not create test larvals if manager is disabled), > logs as follows: > > EXT4-fs (mmcblk0): Cannot load crc32c driver. VFS: Cannot open root > > device "mmcblk0" or unknown-block(179,0): error -80 Please append a > > correct "root=" boot option; here are the available partitions: 1f00 > > 131072 mtdblock0 (driver?) 1f01 32768 mtdblock1 (driver?) b300 32768 > > mmcblk0 driver: mmcblk Kernel panic - not syncing: VFS: Unable to mount > > root fs on unknown-block(179,0) CPU: 0 PID: 1 Comm: swapper/0 Not > > tainted 5.15.0-rc1+ #1 Hardware name: ARM-Versatile Express [<8010f334>] > > (unwind_backtrace) from [<8010b08c>] (show_stack+0x10/0x14) [<8010b08c>] > > (show_stack) from [<8083f2a4>] (dump_stack_lvl+0x40/0x4c) [<8083f2a4>] > > (dump_stack_lvl) from [<8083b210>] (panic+0xf8/0x2f4) [<8083b210>] > > (panic) from [<80b0175c>] (mount_block_root+0x178/0x200) [<80b0175c>] > > (mount_block_root) from [<80b01bac>] (prepare_namespace+0x150/0x18c) > > [<80b01bac>] (prepare_namespace) from [<8084384c>] > > (kernel_init+0x10/0x124) [<8084384c>] (kernel_init) from [<80100130>] > > (ret_from_fork+0x14/0x24) Exception stack(0x8108bfb0 to 0x8108bff8) > > bfa0: ???????? ???????? ???????? ???????? bfc0: ???????? ???????? > > ???????? ???????? ???????? ???????? ???????? ???????? bfe0: ???????? > > ???????? ???????? ???????? ???????? ???????? ---[ end Kernel panic - not > > syncing: VFS: Unable to mount root fs on unknown-block(179,0) ]--- > > In the patch, crypto_alloc_test_larval will return NULL if CONFIG_CRYPTO_MANAGER disabled, so > I checked to see if this change was the cause "EXT4-fs (mmcblk0): Cannot load crc32c driver > ", the success logs does not have this error. > > When I enabled CONFIG_CRYPTO_MANAGER, kernel can be boot successfully. > > Could that be the reason? I would be very grateful if you could give me some advice. Can you please provide the whole .config file? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt