Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1789226rwe; Fri, 2 Sep 2022 04:01:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR5/48Pd3miWwnLN3GZQB48Li9E2XD8kMIMyXahxL4dw1QrGtndEypV4NzwR/dl5uOthjlec X-Received: by 2002:a17:906:c153:b0:741:78ac:853e with SMTP id dp19-20020a170906c15300b0074178ac853emr17923870ejc.191.1662116507596; Fri, 02 Sep 2022 04:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662116507; cv=none; d=google.com; s=arc-20160816; b=ERBYBrtfoKbUfR4rACFvjBLKWX46uqF9E6rK0Q3s+IGXvd5Wq0kv7IMjl4rM9Y3OP9 Hi8SZvLEzm0xqrepMxo+KyQEZ0b/5eiMFAKhsAsARIfDOHyuAq5PFKSFluaRfkoJL+Nj 99WkUoPxxy7PDurtTJ/G66BZvUyv/PqbrMqFY3CJ8WIBXA7CRxDjs+Jv+pu02WuBz1OF u84OhEM42uvftgapoAwgUOwGAkstGbH1O8pmMZjVC0sNIftxi2IVmx2AnzL340A61KMm xsDyToDIORzp0AMU8QS6QyqeK3uYaY12ZC2Fak2GboibW5jVN3/2aM7DqzSHwcx1BGKn 1yoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wolWGJcW0POzW02ouqRvF2aVFENXbpl97kkTBg0MrqU=; b=gxR5h89hv6uMSiXz49S2A3NGpVELPwG7lQwoyXOI4ySS/0rsZZ2Fcdq+pY9kFXJlk9 BoeaPRG6fSZ6zEFtVylMN7XezCpzOEy6Z41otTJmFcgA8VSZdwKeiRlr3YWOPdA4wX7J mGKzkEAlVtS6UeKnxR2OmGO/sae7qYvXxDsQHDZ2bd82WE3tJ/PWs2g/dFb5uDJPdY+F kZ2TtFdiSdVWAJ1K6sE3sAw1/SH9PaN0ishN87xwT9sJk1pxkWPT6zD54Kl1HLIx8gZB uvKRPeQcQxU5Fyugn6Jm+EdpgE3mEVq1GNna4wjMFadRsdz+qo/ryvtAVl20+nmMuXaC uqOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z6-20020a50cd06000000b00447259a7d6csi1449781edi.318.2022.09.02.04.01.21; Fri, 02 Sep 2022 04:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235538AbiIBLAp (ORCPT + 99 others); Fri, 2 Sep 2022 07:00:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235529AbiIBLAm (ORCPT ); Fri, 2 Sep 2022 07:00:42 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA7066A55; Fri, 2 Sep 2022 04:00:40 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oU4PH-000LKk-Nv; Fri, 02 Sep 2022 21:00:16 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Sep 2022 19:00:15 +0800 Date: Fri, 2 Sep 2022 19:00:15 +0800 From: Herbert Xu To: Kshitiz Varshney Cc: Horia Geanta , Pankaj Gupta , Varun Sethi , "David S . Miller" , Iuliana Prodan , Gaurav Jain , Rahul Kumar Yadav , Vabhav Sharma , Sahil Malhotra , Matt Mackall , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Steffen Trumtrar , PrasannaKumar Muralidharan , Martin Kaiser , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] Moving IRQ handler registering after imx_rngc_irq_mask_clear() Message-ID: References: <20220822111903.328957-1-kshitiz.varshney@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220822111903.328957-1-kshitiz.varshney@nxp.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Aug 22, 2022 at 01:19:03PM +0200, Kshitiz Varshney wrote: > Issue: > While servicing interrupt, if the IRQ happens to be because of a SEED_DONE > due to a previous boot stage, you end up completing the completion > prematurely, hence causing kernel to crash while booting. > > Fix: > Moving IRQ handler registering after imx_rngc_irq_mask_clear() > > Fixes: 1d5449445bd0 (hwrng: mx-rngc - add a driver for Freescale RNGC) > Signed-off-by: Kshitiz Varshney > --- > drivers/char/hw_random/imx-rngc.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt