Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1793023rwe; Fri, 2 Sep 2022 04:04:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ktLWKVdd8AulGdvewjimabfRh5UazP58lIk3Cu87qk3VSVQZ9B3GePi6lD3uYaYJdjvt/ X-Received: by 2002:a63:81c1:0:b0:42b:7aca:ddeb with SMTP id t184-20020a6381c1000000b0042b7acaddebmr28544267pgd.201.1662116673766; Fri, 02 Sep 2022 04:04:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662116673; cv=none; d=google.com; s=arc-20160816; b=zV8F5QVszeIo5+O+mIyBHh3jVTLbhpHb2k+iHrcDixmd9u1FD1xMDCjrCySqrKZKDN W6CDXeYQIqyb4zSc5ikhdO2bfWoBH3kYsAk9Hu/ToYQZeOD2HcuGLWGjei3wiNx7IZjL kneZwoab2GjtNBUzSL6PJo6EEh4qgUKqHWEPBitpwd8otKamGgw3TVl85g0Y+mZrl6AD 9tdJ1IgQFYpGZLtJw5ra6O6a5uaDSoJNBPQUaSI1hYeAanaiLY+HfTDkqrdyxjqUuDbX GufjkZd4oGjXyVcdttdqiFvk6JvaGutdtVuZFJvtPm7N2Q7SgQoQsaZDpLI7d5foPQsk U+xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=uNeqgHxsW7NJ7wnAuDcG1Ug65ndPY7GTT1CFeqvXFyc=; b=ql/yPctAYKCMK77U8N0DbMhpphMvG2/ksfZQl0dmjZRM8rmKLZ83eVUOB4Aep8nz4H +Rmb0fXjkO5GiVUzhwDSFw5/rGmTJEIQdqKDlEvgp2sfu7l20/GjhbH5xLJ83o3AdTQR MV5V4as5yyMqcMFXRQ/piU9Ej1QrOnE3pS/rBKWrhu/DkAfQHAqEdkAaaA7i3TaLwOo+ OBCXOwIySfOHc46EdhblwlaBb/9VGc0+6d94Kpsy/+qofZHO8IEqC6AGegu3RS9BGy88 WdRff/KCfoppuTn6xTYGcymp2FzZzuWFRLqxC3IrZAxrlXzs5efvscc/AYrAQpC9Vetr xK6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c14-20020a63ea0e000000b0042986045f4fsi1532931pgi.402.2022.09.02.04.04.20; Fri, 02 Sep 2022 04:04:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235653AbiIBLCI (ORCPT + 99 others); Fri, 2 Sep 2022 07:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235834AbiIBLCH (ORCPT ); Fri, 2 Sep 2022 07:02:07 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1EB2A2DB6; Fri, 2 Sep 2022 04:02:06 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oU4R1-000LQZ-Od; Fri, 02 Sep 2022 21:02:04 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Sep 2022 19:02:03 +0800 Date: Fri, 2 Sep 2022 19:02:03 +0800 From: Herbert Xu To: Weili Qian Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com, liulongfang@huawei.com Subject: Re: [PATCH] crypto: hisilicon/qm - fix missing put dfx access Message-ID: References: <20220827102737.8634-1-qianweili@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220827102737.8634-1-qianweili@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Aug 27, 2022 at 06:27:37PM +0800, Weili Qian wrote: > In function qm_cmd_write(), if function returns from > branch 'atomic_read(&qm->status.flags) == QM_STOP', > the got dfx access is forgotten to put. > > Fixes: 607c191b371d ("crypto: hisilicon - support runtime PM for accelerator device") > Signed-off-by: Weili Qian > --- > drivers/crypto/hisilicon/qm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt