Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2591655rwb; Sun, 4 Sep 2022 20:13:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR52xGEx888SQ+DdKPz2Toja/CMMdvRvjMbOVVo12QkClDdonKBJAbwARqcaJZtIzhyuiTQy X-Received: by 2002:a62:1616:0:b0:537:ab37:fe90 with SMTP id 22-20020a621616000000b00537ab37fe90mr47374369pfw.24.1662347629630; Sun, 04 Sep 2022 20:13:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662347629; cv=none; d=google.com; s=arc-20160816; b=tSjS3Pti1SMHabPlZVc6O5DLRsOP/F58C9KXI/NaT9LhBsmYnDD3v6KaGWg3Ob4+yC mW0mC8nIPNhcER5uojh7rIevEm73jKplEUSUlL6PzfpAYTJuLUal/YOWiIYd7VkbQLL3 SXgCASe7/fgagpP/l4SrZTxGrF16kL36Edcx6YIKeTe0Lf6TZDY6sATtR8kfMbNUMq1l MZGRAUrojei+R6HrBPmTHLOPSkcgGPN54k4W2VuAOPHJRjKGzSVnmUxfxqrJq+O7rD/L IBksfc5dfb0n5pk1kFe0LNf67CFEL09QMRprxAgFG678W7XiVoGhEZCzOMwpl7e9CXtU rr1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=WKrML+bc0Oq0B8AiLXDlRM58wO8I9Wh3CXVXvpVA7sY=; b=c4wNK2hy/pSTTczHKISItNZFuFu2OAC10HaYye5r3VjxG/NQFOlaeQqkAf24z0pmiW lGk3ZTzeGiln/371sIOPVIB/aAMV1hToEmMQYnqLtVNZFcrwUMyDRCn1ALg+tmo4PrF6 ytSumdYfu7kwOaMd+Wc1rO9Tfx7ZKIORQu7FTUmpATkdnKva8J3q7S/D2ijJryOXKsdr uCSqASNm2NSKWcuBNd0WxUrm9YrbbhY6R5diHGbSrXMksaeQrEbB/dVclNYultyAIsko Z//CLX2Q0BsYHToWp1bwbfztHf9Y5Fc48GYR8LdHXjDlj2MpS72U+dw6nbPKdWvfBJ0v AsrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w24-20020aa79558000000b0053a9fee3b21si8819174pfq.325.2022.09.04.20.13.30; Sun, 04 Sep 2022 20:13:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbiIEC4e (ORCPT + 99 others); Sun, 4 Sep 2022 22:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234382AbiIEC4d (ORCPT ); Sun, 4 Sep 2022 22:56:33 -0400 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F04CB183AE for ; Sun, 4 Sep 2022 19:56:25 -0700 (PDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 2852YhcH045911; Mon, 5 Sep 2022 10:34:43 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 5 Sep 2022 10:54:37 +0800 From: Neal Liu To: Herbert Xu , "David S . Miller" , Joel Stanley , Andrew Jeffery CC: , , , , , kernel test robot , Sudip Mukherjee Subject: [PATCH v2] crypto: aspeed: fix build module error Date: Mon, 5 Sep 2022 10:54:33 +0800 Message-ID: <20220905025433.1610696-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 2852YhcH045911 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_HELO_TEMPERROR autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org If CONFIG_MODULES=y and CONFIG_CRYPTO_DEV_ASPEED=m, build modpost would be failed. Error messages: ERROR: modpost: "aspeed_register_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! ERROR: modpost: "aspeed_unregister_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! Change build sequence to fix this. Reported-by: kernel test robot Signed-off-by: Neal Liu Tested-by: Sudip Mukherjee --- v2: Remove redundant obj- lines. drivers/crypto/aspeed/Makefile | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makefile index 421e2ca9c53e..3be78cec0ecb 100644 --- a/drivers/crypto/aspeed/Makefile +++ b/drivers/crypto/aspeed/Makefile @@ -1,9 +1,6 @@ +hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace.o aspeed-hace-hash.o +hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace.o aspeed-hace-crypto.o + obj-$(CONFIG_CRYPTO_DEV_ASPEED) += aspeed_crypto.o -aspeed_crypto-objs := aspeed-hace.o \ - $(hace-hash-y) \ +aspeed_crypto-objs := $(hace-hash-y) \ $(hace-crypto-y) - -obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) += aspeed-hace-hash.o -hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace-hash.o -obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) += aspeed-hace-crypto.o -hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace-crypto.o -- 2.25.1