Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ba011c14c0467c094afb062c3fe2cafe16c2b6b0.1662351087.git.pliem@maxlinear.com>
References: <b08e76c7ff0e46e25e21ee0827fcf3b0e94556bf.1662351087.git.pliem@maxlinear.com> <ba011c14c0467c094afb062c3fe2cafe16c2b6b0.1662351087.git.pliem@maxlinear.com>
To:     Peter Harliman Liem <pliem@maxlinear.com>,
        herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] crypto: inside-secure - Select CRYPTO_AES config
Cc:     linux-crypto@vger.kernel.org, linux-lgm-soc@maxlinear.com,
        Peter Harliman Liem <pliem@maxlinear.com>
From:   Antoine Tenart <atenart@kernel.org>
Message-ID: <166236789651.3222.3650490724066850314@kwain>
Date:   Mon, 05 Sep 2022 10:51:36 +0200
Precedence: bulk

Hello,

Quoting Peter Harliman Liem (2022-09-05 06:14:44)
> CRYPTO_AES is needed for aes-related algo (e.g.
> safexcel-gcm-aes, safexcel-xcbc-aes, safexcel-cmac-aes).
> Without it, we observe failures when allocating transform
> for those algo.
>=20
> Signed-off-by: Peter Harliman Liem <pliem@maxlinear.com>

This looks like a fix, can you add a Fixes: tag?

Thanks!

> ---
>  drivers/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 3e6aa319920b..b12d222e49a1 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -740,6 +740,7 @@ config CRYPTO_DEV_SAFEXCEL
>         select CRYPTO_SHA512
>         select CRYPTO_CHACHA20POLY1305
>         select CRYPTO_SHA3
> +       select CRYPTO_AES
>         help
>           This driver interfaces with the SafeXcel EIP-97 and EIP-197 cry=
ptographic
>           engines designed by Inside Secure. It currently accelerates DES=
, 3DES and
> --=20
> 2.17.1
>=20