Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Harliman Liem <pliem@maxlinear.com>
To:     Antoine Tenart <atenart@kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        linux-lgm-soc <linux-lgm-soc@maxlinear.com>
Subject: Re: [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is
 zero
Thread-Topic: [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is
 zero
Thread-Index: AQHYwZuhWToE3i/+MkuyVhPHlEoUrQ==
Date:   Wed, 7 Sep 2022 06:43:51 +0000
Message-ID: <DM6PR19MB31635CCFF3A6306FFB950701A1419@DM6PR19MB3163.namprd19.prod.outlook.com>
References: <de6de430fd9bbc2d38ff2d5a1ce89983421b9dda.1662432407.git.pliem@maxlinear.com>
 <166247285388.3585.6290053542530090542@kwain>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uYWZymrie8+R+Uci9M1gyzNM7V2XnhtZoYHbn9dnXcUBZ27uJPnhNJ6J55/Q?=
 =?us-ascii?Q?sSCypYKfEWfycbdmvvWNTGSI7GDRSprQ2JCYJ29evDTarg7wFgPWo1pIkrYF?=
 =?us-ascii?Q?YzLsTZTG9yiUrtuHkfcjL1ZwnWBlFClW6wv2WsqNwhPKQ0iZZa2DqX7zhKTe?=
 =?us-ascii?Q?S5Fv1cIXGt9OOW8daOU4wRQaD4bcui4kX2JDIS1bMu1+hdLN6L9RD5RKbSPi?=
 =?us-ascii?Q?t6vff8qdqeNqwaPnmg3+cthv33FB5z2zcYCMHlF4BEeEV3Jercr41QB6sWX9?=
 =?us-ascii?Q?RtZph8vVLQw880zRrU0E4yQUWBiBzxvTYof/upS+jdb56Rfsze5PdMfR3LS9?=
 =?us-ascii?Q?hqXDeJJS0qHTO0o+n17PkyjKmZu0Yv02WmR8VOtmZs8FcKq78pudBpOgARHe?=
 =?us-ascii?Q?NJQGBzt6Wy49J6M5zepVYe2fO6VWLbw9/C+GmkW2j9qM3r2xAKDeQQqg7T42?=
 =?us-ascii?Q?uvWSYCL1acAxTTGvCRK/fQ1bXlhZD497EPXwKgr/JqoFuhft3WSD/fF4GZIa?=
 =?us-ascii?Q?oTRgAxPTq4JJjqz6mUnjbg+POyu1DdQe9lFmw54/H9hc2bWThvpzpVNgtbSl?=
 =?us-ascii?Q?0+9lvrKSejs9uIqwv1tfeBTe8aBxAfnLYB1jKADux78JXxLH3MRT9yZHOZKb?=
 =?us-ascii?Q?p3lj8tWHj5+ZOfRpkiy4+5LHCYCWdizXENjwj/0wCdgG6U/IG3rervJCx2qq?=
 =?us-ascii?Q?UEAP3RqHNW8ALCVpeMvJdDKe1HnzeBvn5a+Suv1eUXwaM/UUzJNnWByxwT/0?=
 =?us-ascii?Q?5Pt0k2SBX48PXeJ+g30Ai0T6P+gVwRF6s/76aCF7gjS47DmzmTvzCAt4PBeJ?=
 =?us-ascii?Q?MU25QsasH+4RLRlniS+MLhNOfXLqoHgZ3o6tIcE52kbdnFH5pX0ywRkjTeGZ?=
 =?us-ascii?Q?iX8LrEKHOUaqCAIY3xQGFnhLDptQosNrucex6nAJI7rCxB7Ib+/en/QJ9H3Z?=
 =?us-ascii?Q?tf4x2u41HRVT26bL9HOvyjq4d7TlKCpz9ZkBQXfOD1sTMto5+vBfjMa/FWrA?=
 =?us-ascii?Q?//3ji6c/V7r1ZKXy/cBzs0s/YXEUg3asnU4fsDSsBHK3Y9/0saxocUUiVAtQ?=
 =?us-ascii?Q?N+IrnAC4a1SWVEnFAIXTSPuTTlu3I3gK8DILgmKacb/FtJDEpd1BNERozrbi?=
 =?us-ascii?Q?qGQpmURRPmU1QjYzIq8F+A9kGPlmemWeA+2j98dJ1GFejEjTUJil7s8QW+YR?=
 =?us-ascii?Q?Nfl2moupQaS9JjUbquy7XN0ae8ZbYVxKL961u4KiJxqOwa7x4Z7wcYdjFCSw?=
 =?us-ascii?Q?AsAOJe0mnFbeOJ54nZZ/0wA2DjSN9W8DLUv4RcSIKzWwVXPokwAlIVLOxeuD?=
 =?us-ascii?Q?Npb61rP4K5uZctTWrYEUbc+4W1IO3A24bwxPew7fp94/9qwWDAgc7xYL/orM?=
 =?us-ascii?Q?WOJqcv3IUXW0bYfUnNc2Zy0EuBhFBg0a0hb6MEz3gcZ+oWUQYq7w0x8BxKeQ?=
 =?us-ascii?Q?zsVvRGL4x4gvnWBdVejK2iBcprm5IEMaXlTvUy/NSapMotQ681Rm74eJzsKj?=
 =?us-ascii?Q?obAbn6zi1DHtY/YZxmjnsyiR9YvpBjclut8WEC/zmkeXB5mRTFhZfdexJrzm?=
 =?us-ascii?Q?VN1yyUQb1DXfnkV6qN4msFpmbT5qJm5/fC6ejy3ANu7oMgQu+77bftEbLBik?=
 =?us-ascii?Q?wg=3D=3D?=
MIME-Version: 1.0
X-OriginatorOrg: maxlinear.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB3163.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85a0101f-2b8b-47a2-d0f0-08da909c53b7
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 06:43:51.9574
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dac28005-13e0-41b8-8280-7663835f2b1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wiXieM8V7PnAHJ3jmrQieEzRixUjzYMtEEMw9QhTXJo7ZZWxIUSO4YV9GpJNhvfVegG9HQuYpbos0EKuq0nQVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR19MB4769
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: maxlinear.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 6/9/2022 10:01 pm, Antoine Tenart wrote:=0A> Quoting Peter Harliman Liem=
 (2022-09-06 04:51:49)=0A>> From commit d03c54419274 ("dma-mapping: disallo=
w .map_sg=0A>> operations from returning zero on error"), dma_map_sg()=0A>>=
 produces warning if size is 0. This results in visible=0A>> warnings if cr=
ypto length is zero.=0A>> To avoid that, we avoid calling dma_map_sg if siz=
e is zero.=0A>>=0A>> Fixes: d03c54419274 ("dma-mapping: disallow .map_sg op=
erations from returning zero on error")=0A>=20=0A> You can't reference the =
commit above, it's not introducing the issue but=0A> the warning itself. Th=
e actual commit introducing the below logic should=0A> be referenced.=0A>=
=20=0A> Alternatively since the warning was introduced latter than the logi=
c and=0A> this is not a huge issue, you might resend it w/o the Fixes tag a=
s well.=0ANoted.=0AI will remove the tag in v3.=0A=0AThanks!=0A=0A