Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Harliman Liem <pliem@maxlinear.com>
To:     Antoine Tenart <atenart@kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        linux-lgm-soc <linux-lgm-soc@maxlinear.com>
Subject: Re: [PATCH v2 2/2] crypto: inside-secure - Select CRYPTO_AES config
Thread-Topic: [PATCH v2 2/2] crypto: inside-secure - Select CRYPTO_AES config
Thread-Index: AQHYwZuhJOtFv92MlU2QoKo8a0Nwig==
Date:   Wed, 7 Sep 2022 06:46:32 +0000
Message-ID: <DM6PR19MB31633BFB6AD885E0EAF68F14A1419@DM6PR19MB3163.namprd19.prod.outlook.com>
References: <de6de430fd9bbc2d38ff2d5a1ce89983421b9dda.1662432407.git.pliem@maxlinear.com>
 <60cb9b954bb079b1f12379821a64faff00bb368e.1662432407.git.pliem@maxlinear.com>
 <166247313358.3585.5988889047992659412@kwain>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5mD2TplFvjA4o6gbYXVt766Nia1LtIaQnq8MkMhG17ys+v3xE/xvQ5JuNEVy?=
 =?us-ascii?Q?zHV5jlTSDCYnOgS0iJ2N5vtk1sg2vtUAEHj2xmYjTDnik0MIERtsFnpOsxen?=
 =?us-ascii?Q?KqBSEo8IWumUjV1G1ZevBZ8U/3vNJHA6otHaGCbhqO8mb5KX3Sn+LUWvtKxn?=
 =?us-ascii?Q?YTJUdI96gv88t5oVqnV4hXrKMsyTQ6m9G9mEKkcC9zGen/pnmW1WS4uggjlU?=
 =?us-ascii?Q?VMhRklMWDkY6Ois5dYJOhGk3Pg2G0tFU9NdiezGDthpMGmJWNqh3GkgHXSvP?=
 =?us-ascii?Q?LkB7rKjfdDEZHG/usHZcY/3/SxRrknm2wbAI49VzJylC4dFcF2WK3IpQeKsd?=
 =?us-ascii?Q?W27O0mToMlpkBNYb5Oce+KGmqfL/QWjn4THQRiIphToBQoCeqdwmmVC2dxwx?=
 =?us-ascii?Q?XbpPXbqtBJJctpHIpiTI4V5WOVg2sBGXwOX0l3B6tarlvsDBF4mLyIpqvpIv?=
 =?us-ascii?Q?TobaG9mDlELv2puEr6rgub5Sk6rcOl6xXqWd5ccOd2eFJ4CMiH/zwX+PFVNr?=
 =?us-ascii?Q?wsVMkBO3WyQf8tVk+djIEf5+6mX6lNjrWKY7onhagHHnT6BVezFTLOS35RU3?=
 =?us-ascii?Q?JP0gzlMW74T0K958tmfiX41nnr0R15/vpgs58H/M4ixYppHtuaG9W91bDGuF?=
 =?us-ascii?Q?SeR5ShTzR4MSFiA2lJc61TtAxmBOLYe+p/tHNaSU3yVXGPWDxbE/yDUdFUXl?=
 =?us-ascii?Q?90Wd0aNf/lgJGx5Gtr+nudoRNUAvYxEYkU5AqvfgxB7jknh1F1bwi/DWw1bF?=
 =?us-ascii?Q?SLkfoTAHcmElpGPeB4Bd2zK5kq0zGdXKVPW0U+xMUAFIv3dB743dE3lprusq?=
 =?us-ascii?Q?gSjM+nstU2QAxcngthH7N5ryBCe1SChig4oStD+vc41t5PNsx4CjrdOIuT10?=
 =?us-ascii?Q?U77R2RlAcM4mTvEaNlZ6dOk8Y5GI3NTk8EroF19tJwkvzpHGElbMej/gXqZ1?=
 =?us-ascii?Q?H/VnptNQvyhHwtlUguHOk4J7yWTwLU5o34H284EPlbWXAxXv1JYIHPB4G2ls?=
 =?us-ascii?Q?qhznqRY7sYjvSbLKsEgw+t03kmOqlxpHi79dwGkIGYGXnDrEUajLwbSrLwJP?=
 =?us-ascii?Q?DA78r6OJrCbp8bFY2hFMm8awH7zBoPXoYfyrhks5C/TD7atJf3IWVe6jOCPi?=
 =?us-ascii?Q?ICaDrVzpJTdeG27EtyMNE31/7l+xQBXA4cLBMIWtmzN6vQX50T8BznSzy9lf?=
 =?us-ascii?Q?sXKMT1lISPLPZLJZku+qpAKy/9RdOAAP7dvxwI6yo+Vh5ABBY3w1Om7UO5vD?=
 =?us-ascii?Q?XWU43lGS2Z/22VWyHSQfbEZvFlV/HtO0Ha02MGUy/XUXnbUt/ef0x2dWX6ly?=
 =?us-ascii?Q?8nKsxpsyNnTCJ0aaR8teL5X6RoNj59xkvcsSP+FIIXavMutbUQ/HelDMSG0r?=
 =?us-ascii?Q?HqfTHfREm6LQjbAwNdCfhYeTWNZYNquzMGANChNljQ14y7aeT+r1nbVHasQ1?=
 =?us-ascii?Q?/v6W28lj+rv6WlaBK0ePXkzhpYnweKVF670TZfls8uT5kN+0O5XMaXta8gll?=
 =?us-ascii?Q?4y9XdN8/TINpToYeCy057/H4BGyDkLLJNWE9HbvIMg5qhl9R9nI2ClZ7/GCK?=
 =?us-ascii?Q?29Ta+NkA9UG/UUGgsAfQOnn+WqWN14BK/y5Ok0rNXYDppXV4phlGKVTXQ6wf?=
 =?us-ascii?Q?mw=3D=3D?=
MIME-Version: 1.0
X-OriginatorOrg: maxlinear.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB3163.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1419a4f3-b718-4de2-f872-08da909cb33e
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 06:46:32.2580
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dac28005-13e0-41b8-8280-7663835f2b1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3M+q+861D9yYj3DuvWkwbsgc9bon6Ao0/4lfXoriTJ4tovse/1LEYynbMVs84mnKo4ZR+pntWVOGizsmJ+n/cA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR19MB3933
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: maxlinear.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 6/9/2022 10:05 pm, Antoine Tenart wrote:=0A>> CRYPTO_AES is needed for a=
es-related algo (e.g.=0A>> safexcel-gcm-aes, safexcel-xcbc-aes, safexcel-cm=
ac-aes).=0A>> Without it, we observe failures when allocating transform=0A>=
> for those algo.=0A>>=0A>> Fixes: 363a90c2d517 ("crypto: safexcel/aes - sw=
itch to library version of key expansion routine")=0A>=20=0A> The above com=
mit explicitly switched crypto drivers to use the AES=0A> library instead o=
f the generic AES cipher one, which seems like a good=0A> move. What are th=
e issues you're encountering and why the AES lib makes=0A> the driver to fa=
il?=0A=0AIf I load the kernel module (CONFIG_CRYPTO_MANAGER_DISABLE_TESTS i=
s not=0Aset), I am getting failure messages below.=0AIMHO this happens beca=
use some functions in the driver still rely on=0Ageneric AES cipher (e.g. r=
efer to safexcel_aead_gcm_cra_init() or=0Asafexcel_xcbcmac_cra_init()), the=
refore CONFIG_CRYPTO_AES is still needed.=0A=0AMaybe the alternative is to =
switch all of them to use AES lib instead?=0ALet me know if you prefer this=
.=0A=0AThanks!=0A=0A[  157.683462] alg: aead: failed to allocate transform =
for=0Asafexcel-gcm-aes: -2=0A[  157.689054] ------------[ cut here ]-------=
-----=0A[  157.693650] alg: self-tests for safexcel-gcm-aes (gcm(aes)) fail=
ed=0A(rc=3D-2)=0A[  157.693696] WARNING: CPU: 3 PID: 164 at crypto/testmgr.=
c:5804=0Aalg_test.part.0+0xd1/0x2f0 [cryptomgr]=0A[  157.709505] Modules li=
nked in: crypto_safexcel(+) md5 sha512_generic=0Alibdes sha256_generic libs=
ha256 sha1_gene=0Aric libsha1 libaes authenc cryptomgr akcipher crypto_acom=
press kpp rng=0Acrypto_null crypto_hash skcipher aead cryp=0Ato_algapi=0A[ =
 157.729991] CPU: 3 PID: 164 Comm: cryptomgr_test Not tainted=0A6.0.0-rc3+ =
#42=0A[  157.736900] RIP: 0010:alg_test.part.0+0xd1/0x2f0 [cryptomgr]=0A[  =
157.742512] Code: 6c 85 db 0f 84 89 00 00 00 80 3d 59 6c 05 00 00 0f=0A85 0=
8 40 00 00 89 d9 4c 89 f2 48 89 ee 48=0A c7 c7 40 1c 09 a0 e8 cc 17 28 e2 <=
0f> 0b 48 8b 84 24 90 00 00 00 65 48=0A33 04 25 28 00 00 00 0f 85 eb=0A[  1=
57.761177] RSP: 0018:ffffc90000557e40 EFLAGS: 00010246=0A[  157.766359] RAX=
: 0000000000000000 RBX: 00000000fffffffe RCX:=0A0000000000000000=0A[  157.7=
73440] RDX: 0000000000000001 RSI: 00000000ffffdfff RDI:=0A00000000ffffffff=
=0A[  157.780528] RBP: ffff8880046ed200 R08: 0000000000000000 R09:=0Affffc9=
0000557ce8=0A[  157.787610] R10: 0000000000000001 R11: 0000000000000003 R12=
:=0A0000000000011083=0A[  157.794699] R13: 0000000000000400 R14: ffff888004=
6ed280 R15:=0Affffffffffffffff=0A[  157.801780] FS:  0000000000000000(0000)=
 GS:ffff88807a580000(0000)=0AknlGS:0000000000000000=0A[  157.809818] CS:  0=
010 DS: 0000 ES: 0000 CR0: 0000000080050033=0A[  157.815516] CR2: 0000560ce=
ce6c0d8 CR3: 0000000002a0a000 CR4:=0A00000000001006a0=0A[  157.822608] Call=
 Trace:=0A[  157.825018]  <TASK>=0A[  157.827104]  ? _raw_spin_unlock+0xd/0=
x30=0A[  157.830989]  ? finish_task_switch+0x8a/0x260=0A[  157.835221]  ? _=
_schedule+0x27c/0x670=0A[  157.838855]  ? 0xffffffffa004c000=0A[  157.84213=
1]  cryptomgr_test+0x22/0x50 [cryptomgr]=0A[  157.846804]  kthread+0xd0/0x1=
00=0A[  157.849908]  ? kthread_complete_and_exit+0x20/0x20=0A[  157.854664]=
  ret_from_fork+0x1f/0x30=0A[  157.858209]  </TASK>=0A[  157.860346] ---[ e=
nd trace 0000000000000000 ]---=0A[  157.908463] alg: hash: failed to alloca=
te transform for=0Asafexcel-xcbc-aes: -2=0A[  157.914132] ------------[ cut=
 here ]------------=0A=0A