Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pankaj Gupta <pankaj.gupta@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "jarkko@kernel.org" <jarkko@kernel.org>,
        "a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>,
        "Jason@zx2c4.com" <Jason@zx2c4.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "zohar@linux.ibm.com" <zohar@linux.ibm.com>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "sumit.garg@linaro.org" <sumit.garg@linaro.org>,
        "david@sigma-star.at" <david@sigma-star.at>,
        "michael@walle.cc" <michael@walle.cc>,
        "john.ernberg@actia.se" <john.ernberg@actia.se>,
        "jmorris@namei.org" <jmorris@namei.org>,
        "serge@hallyn.com" <serge@hallyn.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "j.luebbe@pengutronix.de" <j.luebbe@pengutronix.de>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "richard@nod.at" <richard@nod.at>,
        "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        Sahil Malhotra <sahil.malhotra@nxp.com>,
        Kshitiz Varshney <kshitiz.varshney@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>
Subject: RE: [EXT] Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added to
 the tfm
Thread-Topic: [EXT] Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added
 to the tfm
Thread-Index: AQHYwbSROQtM17Y3rUes00GOEj1Wxa3R9HsAgAGPkHA=
Date:   Wed, 7 Sep 2022 07:22:42 +0000
Message-ID: <DU2PR04MB86308036FB517BF8CAD3D32795419@DU2PR04MB8630.eurprd04.prod.outlook.com>
References: <20220906065157.10662-1-pankaj.gupta@nxp.com>
 <20220906065157.10662-3-pankaj.gupta@nxp.com>
 <YxbsBiCrIQT/0xz6@gondor.apana.org.au>
In-Reply-To: <YxbsBiCrIQT/0xz6@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2g8IFGBV6TelRmj4KGIKRcJkB1Kuw/UmgzxcSuk7N+2dT0spAFMVkJwsId+g?=
 =?us-ascii?Q?a77QcvUcdrBHYYqzlJECjuMMrigLo4RMHNnYh3sn8/8eDSK7wTTL4Mpl3ENH?=
 =?us-ascii?Q?EK5phmeMm+NXRdI2ACKWnNS/z1L6RAjHSd2FxPNAToCq7zW/tC+mJfBRXm4G?=
 =?us-ascii?Q?vPo5xhnEl9E5nQENl33KIeyWkWQUjl/3vuycgaRAKn/ht7yN88v3plrNo7r3?=
 =?us-ascii?Q?hLPw0NRPvHfqOniYrbgidMgKqiVHfLvAIdYePatzZdEQLTbuzGZu4LEtPB/i?=
 =?us-ascii?Q?9vfSfG18lS9Ae3mHAqWZdGLjPP8SR0EIqW7xj6piEWzPVXVE47DKV30kRbiw?=
 =?us-ascii?Q?4GFNlpi4rgT4njNk2dMV6cDfKp76hvGm3IUM+NQ0udfMPY02AL0E7jhN7X/a?=
 =?us-ascii?Q?XORt7SosTtYiQDq7DGEju3yEU24VwVh7bpjgXVlQE4KZRcCvp4ihdjCs4P7t?=
 =?us-ascii?Q?8caqSQAdWn7chA5Wb9u5IR4BPeCSqeDC6wTrFOhPjx3VRst3595y4jlh1Gj5?=
 =?us-ascii?Q?QEccLFcsppDSo/XasyMq8RwppdRahjdaGLUMF4prY1yy2B4McgTfdt7eEHN+?=
 =?us-ascii?Q?Z9psxfyw8WqGJB4EIZ+oNRORCJQ8T6GU3kZopnkpLWqYpVr7yItfKD7bQdyT?=
 =?us-ascii?Q?RFMT4ksHtMa4FrZ4SSTXsTHDooql+olfLiVbQkZsbU63TCe8y6lfj0bdQbVi?=
 =?us-ascii?Q?8NhyIveteO+ltN1CMg4xwzMaIwBZ5rpFRPNusWqIMeOQas/h+NsuuhVNOrlp?=
 =?us-ascii?Q?Xf/6TjxqgIo6Dcdxsq6+yq1t39wK1/EdTPqF+zxeMD/S8zgxRnJUl0nDq99h?=
 =?us-ascii?Q?6n0ybapqnmPsTN9IDXJZQ72lMBdvMeSf2sqVMoTpCDhfLtzheDhmZzTzwv9g?=
 =?us-ascii?Q?PLN8Yx6MWJYxN4L4YgGLYAIOJjEIMudaOrd3yj2aLMEGxByMrrD+7sPLdTvQ?=
 =?us-ascii?Q?Ghs+VjTAWnetlofMuKuFdAUeA8PlVIgHf2gbFaQ8Dt+VGFnyH/vaka6xB+jH?=
 =?us-ascii?Q?fG48hQqGPygd8hv/UNnjRJRpA3gaw4B/hnKCjRsb6ajyl5qksUBUNIsjnHFi?=
 =?us-ascii?Q?+h3QDg/BRgcWz2I6t4/J6aR8IlcvvPHVWO3oq0qoYwWBfGJhmAds1OoiZ7qQ?=
 =?us-ascii?Q?Qa3uudEZ9aowjDJa1XKdjE7Vmlat1TehgKFLqi9D6qLH5EeJxHhOMEIS70p1?=
 =?us-ascii?Q?AQwSp5UweGWhKps3D9yVi26WI86Ld7ozk/KlisDkRkLnBkwlRDSf70hPwhgD?=
 =?us-ascii?Q?YpBahrf6Uyh9SAaw6Cjuze9zwpQ+gySjvRHIF5wOB3fQSMMahHaEes1SfI78?=
 =?us-ascii?Q?j1H9C0NmkQk+e2YTulBpr9lhiMCwz2i+4jZl9bQO6JNx19SUPmu29QP4Fl4P?=
 =?us-ascii?Q?U18ZNjH6Cxp1lc1JFQp4brUmtUPrwULSlX9VnEcewpXfj9HaAHfdYd/N/qKx?=
 =?us-ascii?Q?8D8YhGMRzmuYEmJWLgDRTk0a2bUZmhXDs7UzChnPS0Z6i20b7tRokqSAzLLt?=
 =?us-ascii?Q?O2aLnCt5x5MXXrTWzlH/O/fKY5mg91LKL89WT11NRxxD4jI8i5qVzJUSAWo0?=
 =?us-ascii?Q?V95CVxNVNMX7J0YNQT4tdOb1ZBgbprcsE6sX+B4C?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d8ab84c-da1c-4a97-f19f-08da90a1c10c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 07:22:42.9019
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: io57pptt80z/M3jqjmKgCoCbFDGRW7Gmjk48Bok1dHGG84RnJj9/vc2Ns8at8PFLm5uoS9qYbGn3aYprCgbcQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7770
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Tuesday, September 6, 2022 12:13 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: jarkko@kernel.org; a.fatoum@pengutronix.de; Jason@zx2c4.com;
> jejb@linux.ibm.com; zohar@linux.ibm.com; dhowells@redhat.com;
> sumit.garg@linaro.org; david@sigma-star.at; michael@walle.cc;
> john.ernberg@actia.se; jmorris@namei.org; serge@hallyn.com;
> davem@davemloft.net; j.luebbe@pengutronix.de; ebiggers@kernel.org;
> richard@nod.at; keyrings@vger.kernel.org; linux-crypto@vger.kernel.org;
> linux-integrity@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> security-module@vger.kernel.org; Sahil Malhotra
> <sahil.malhotra@nxp.com>; Kshitiz Varshney <kshitiz.varshney@nxp.com>;
> Horia Geanta <horia.geanta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
> Subject: [EXT] Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added t=
o
> the tfm
>=20
> Caution: EXT Email
>=20
> On Tue, Sep 06, 2022 at 12:21:51PM +0530, Pankaj Gupta wrote:
> > Consumer of the kernel crypto api, after allocating the
> > transformation, sets this flag based on the basis of the type of key
> > consumer has. This helps:
> >
> > - This helps to influence the core processing logic
> >   for the encapsulated algorithm.
> > - This flag is set by the consumer after allocating
> >   the tfm and before calling the function crypto_xxx_setkey().
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > ---
> >  include/linux/crypto.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/include/linux/crypto.h b/include/linux/crypto.h index
> > 2324ab6f1846..b4fa83ca87bd 100644
> > --- a/include/linux/crypto.h
> > +++ b/include/linux/crypto.h
> > @@ -639,6 +639,8 @@ struct crypto_tfm {
> >
> >       u32 crt_flags;
> >
> > +     unsigned int is_hbk;
> > +
>=20
> We already have plenty of drivers with hardware keys in the tree.
> Plesae explain why the current support is inadequate and you need to do
> this.
>=20
Current support, does not permit the hardware to support both types of keys=
: HBK & Plain Key, at the same time.

This change is generic and permit any driver that supports both- HBK and pl=
ain-key, to differentiate and use the keys accordingly.

> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondo
> r.apana.org.au%2F~herbert%2F&amp;data=3D05%7C01%7Cpankaj.gupta%40nx
> p.com%7Cffd6105be88e4b82546c08da8fd33b6e%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C637980434686220485%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C3000%7C%7C%7C&amp;sdata=3DAErrjpwh%2FRZSCNDDbtH%2FWW
> %2B39J%2FrxPJwak2X2Fk%2BWBg%3D&amp;reserved=3D0
> PGP Key:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondo
> r.apana.org.au%2F~herbert%2Fpubkey.txt&amp;data=3D05%7C01%7Cpankaj.g
> upta%40nxp.com%7Cffd6105be88e4b82546c08da8fd33b6e%7C686ea1d3bc2
> b4c6fa92cd99c5c301635%7C0%7C0%7C637980434686220485%7CUnknown%7
> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi
> LCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3D%2F7axxa8nrYDiItrwcZi
> AfRTVc%2F25Ln5IgUzr%2F1uK%2FNk%3D&amp;reserved=3D0