Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pankaj Gupta <pankaj.gupta@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "jarkko@kernel.org" <jarkko@kernel.org>,
        "a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>,
        "Jason@zx2c4.com" <Jason@zx2c4.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "zohar@linux.ibm.com" <zohar@linux.ibm.com>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "sumit.garg@linaro.org" <sumit.garg@linaro.org>,
        "david@sigma-star.at" <david@sigma-star.at>,
        "michael@walle.cc" <michael@walle.cc>,
        "john.ernberg@actia.se" <john.ernberg@actia.se>,
        "jmorris@namei.org" <jmorris@namei.org>,
        "serge@hallyn.com" <serge@hallyn.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "j.luebbe@pengutronix.de" <j.luebbe@pengutronix.de>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "richard@nod.at" <richard@nod.at>,
        "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        Sahil Malhotra <sahil.malhotra@nxp.com>,
        Kshitiz Varshney <kshitiz.varshney@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>
Subject: RE: [EXT] Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added to
 the tfm
Thread-Topic: [EXT] Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added
 to the tfm
Thread-Index: AQHYwbSROQtM17Y3rUes00GOEj1Wxa3R9HsAgAGPkHCAAA7BgIAAHQrw
Date:   Wed, 7 Sep 2022 09:58:45 +0000
Message-ID: <DU2PR04MB86308DB7CFBC7A31CEB612D295419@DU2PR04MB8630.eurprd04.prod.outlook.com>
References: <20220906065157.10662-1-pankaj.gupta@nxp.com>
 <20220906065157.10662-3-pankaj.gupta@nxp.com>
 <YxbsBiCrIQT/0xz6@gondor.apana.org.au>
 <DU2PR04MB86308036FB517BF8CAD3D32795419@DU2PR04MB8630.eurprd04.prod.outlook.com>
 <YxhHkz+UlE9XAG/Z@gondor.apana.org.au>
In-Reply-To: <YxhHkz+UlE9XAG/Z@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Iu4bqgpIIZ8cSjS0t5FHlrY33N5WIm8OQO8aklly1yD8AIUdsFCit9ATfgTU?=
 =?us-ascii?Q?59IMszIcfjRDoxbLgnl+W5AZiZ5ESLZgfqqBobz4308N7k122L+fGYJxAqGh?=
 =?us-ascii?Q?h3d9ia1g933aIcJeoKmslzcmS1QQ2s6cNcxuftqkQZ9pqx22s9BPgHd/SS00?=
 =?us-ascii?Q?gi5st9XbGbZxpx6GjB0QAggt/SXB77bcB8mDbpF99saaoKxR/0A+XeLmrjqf?=
 =?us-ascii?Q?s/VwI24YxCMpZQzHPJZ6GmSv1pgQWKNUr5SaieUWhfrHX/kF3+IxlB5uN3vQ?=
 =?us-ascii?Q?Y+YuU9KBgaB2Us8ZaxyKIupoJ5LLXkB4YJhRgPF/ccMV36TwmrHs3WTMD/dE?=
 =?us-ascii?Q?1rYnzxnnZUqLKlJAOKxsLghfzcAy9XR9MR0N99DHUJ3YcAeVkaOpBQlYYjyP?=
 =?us-ascii?Q?afOGcjgm19375yzipWS5oC88uoYcmTzlgSTb2QxFsI4L9OXAkrHXznE0gpFZ?=
 =?us-ascii?Q?ycXihAw9ut85t+E3Ez8k/bdaBPPI1sOc4RgZ8IIhE1e5XMNfkK1tL+hQoYTV?=
 =?us-ascii?Q?PoTPfQpFD8GxQAzBEMdhnQ73eMuy+D7XBm5xW53PhVv4TdeY5v0WSsw4hkYd?=
 =?us-ascii?Q?ctolUTLICJz9rgZ2ubFADX/uAtrWYEUgVGQVVicZ3rtuMYqPOyNY5n1ufQAn?=
 =?us-ascii?Q?2vNkMOJlq/MTClR4s26jYgB/CkphuBDdjBgLmN6jdF5ALi+PyPL3uxMcYYRv?=
 =?us-ascii?Q?Uzc+hFn+UK8P3rtll7rhHp0CTr0tA/2bGrqTbxZ72479y/WCLp4oxLqTIo4a?=
 =?us-ascii?Q?2k1Rgf4cAq9LlqmhuWWu2zn14wAlHoW6dg/HrKLbo8IWAxxVNMoHfY93ON7E?=
 =?us-ascii?Q?Sv0WfVmc0QOmRwNYg7aN59xWoE57krcWMFiVBWr5/ZjS3biliz83KsfxDWD+?=
 =?us-ascii?Q?A+HXluUx8m1RBcsjshTmyBVB5DPqIoZYkdHCAY+51buMYYwtYa06R3RekGf+?=
 =?us-ascii?Q?hKlTht2QZw4D7QT0K7hn6uUfAS7HIACIdZooGTlJXBkY67OY5ukF82A6xn66?=
 =?us-ascii?Q?j/WU8zTx95hiOYQxcxDV1vG9LzvfDz1s61VTW5FsUBWuxEKfyZchCSZEJUEq?=
 =?us-ascii?Q?N6YzFnSdB8I1l6YHhf+ECCsEQdp8tDHXGkFrs6T7TklCbGi0lCx+RJs7hU91?=
 =?us-ascii?Q?zZI3i06Uf5EUtt/u3AZiH5wQQjkH5nrdRGRpNIK8kQcsSbWJQrKJgGDG3A4B?=
 =?us-ascii?Q?HDFYMDNPUUHkubB+LOYIYU3ZnF8WvL0zkFRG74aECcWjA/nxO/Vjkng3I+Iq?=
 =?us-ascii?Q?IwPGrjULrebRItIjh6IqYHpkSWHSQKtdm5cQpG0Hnhf6At+y4+1QvU8NMDJM?=
 =?us-ascii?Q?cYwaKX90G+5fMhheG5acJvL3gOkC4qTBb5ry7748qpxakjSYBOgFY1kRmhdb?=
 =?us-ascii?Q?s25zZBXM9KGh0UIfo0YnbsQrxvlTSuu6c53hqPwiICmP+79242y53XGwjqFf?=
 =?us-ascii?Q?D4kr7Oa6Q8LbVVkXLIjE+jpDZTwvQVAZelMN0bbkTEiBTLcd8se8qGb43cZ1?=
 =?us-ascii?Q?IbX7iCwO7/Bf+HyhNyKY4ymhtSc/dKDMVwfngtMqWSIo/smx6oUlOSeSOYsD?=
 =?us-ascii?Q?vKujqXFKCPxXCs6Fg4gzA0dOSYeeX2/pQZgB+Nik?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40e09fce-8c9d-48e6-77de-08da90b78dda
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 09:58:45.9041
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lUziX6y1HKjC6NP7/jj04+eiiyNtWZx49o17T0yWPZhlqEEmMxQw0vWoM5jwgINbjGd1/oIvAV2qjRS/FC5f7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4158
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Wednesday, September 7, 2022 12:56 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: jarkko@kernel.org; a.fatoum@pengutronix.de; Jason@zx2c4.com;
> jejb@linux.ibm.com; zohar@linux.ibm.com; dhowells@redhat.com;
> sumit.garg@linaro.org; david@sigma-star.at; michael@walle.cc;
> john.ernberg@actia.se; jmorris@namei.org; serge@hallyn.com;
> davem@davemloft.net; j.luebbe@pengutronix.de; ebiggers@kernel.org;
> richard@nod.at; keyrings@vger.kernel.org; linux-crypto@vger.kernel.org;
> linux-integrity@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> security-module@vger.kernel.org; Sahil Malhotra
> <sahil.malhotra@nxp.com>; Kshitiz Varshney <kshitiz.varshney@nxp.com>;
> Horia Geanta <horia.geanta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [EXT] Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk
> added to the tfm
>=20
> Caution: EXT Email
>=20
> On Wed, Sep 07, 2022 at 07:22:42AM +0000, Pankaj Gupta wrote:
> >
> > Current support, does not permit the hardware to support both types of
> keys: HBK & Plain Key, at the same time.
> >
> > This change is generic and permit any driver that supports both- HBK an=
d
> plain-key, to differentiate and use the keys accordingly.
>=20
> Existing drivers simply register hardware keys under a different algorith=
m
> name, there is no reason why they can't coexist with a plain key.
>=20

Thanks for the comments.

Intention is to only secure the key buffer, at run-time.
Not to change the working of the crypto algorithm. Algorithm would be worki=
ng exactly same for plain and HBK.

There are 3rd party IP(s), which uses kernel for crypto-algorithm's operati=
ons.
Modifying the algorithm name in these IP(s), is not always allowed or easy =
to maintain.

While, this patch-set allows to use the same algorithm name,=20
and hence prevents any changes required to the user(3rd Party IPs) of kerne=
l crypto layer.

Regards,

> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondo
> r.apana.org.au%2F~herbert%2F&amp;data=3D05%7C01%7Cpankaj.gupta%40nx
> p.com%7C9bc412605fa243702f3a08da90a2602c%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C637981324324251974%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C3000%7C%7C%7C&amp;sdata=3Db1ImbcEMa9jticFU7yrpwHXuuQEog
> KLrjuiE%2FFpcYyA%3D&amp;reserved=3D0
> PGP Key:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondo
> r.apana.org.au%2F~herbert%2Fpubkey.txt&amp;data=3D05%7C01%7Cpankaj.g
> upta%40nxp.com%7C9bc412605fa243702f3a08da90a2602c%7C686ea1d3bc2b
> 4c6fa92cd99c5c301635%7C0%7C0%7C637981324324251974%7CUnknown%7C
> TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DcP4js5Q0QPBJfvlrYDi0j6R
> IGFpqHtJOSa9C7YC2IXM%3D&amp;reserved=3D0