Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5641082rwb; Wed, 7 Sep 2022 06:04:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR7anoWnrx2Z8/mOxbr9UIfkUfXyKO4BnhQHqK5Dy3o27NjbBvdrzj5LlIypVVqIDuZQIDWW X-Received: by 2002:a17:906:9752:b0:738:364a:4ac with SMTP id o18-20020a170906975200b00738364a04acmr2290928ejy.759.1662555880908; Wed, 07 Sep 2022 06:04:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662555880; cv=none; d=google.com; s=arc-20160816; b=GBjqMQT3jSkdRsELRWK6hnStE8vCrV8cITd5hc3rTHhkMlXkHPjQk69hR+Ddqfeex2 DfpGGv8UjtQtpNMrzc0/4+QUmjJkCPu9tE/FLqlOrgx00kZCgQhZVWQvhMi3+2ZF7NrO sfw1lU1Oa5tWLtY68W5/LNh+YnmOQMa5UaaCvzHhN6O3NRqwF0aNCTqKQ+dY53fNQJOJ juGJCWhLm0+SsY0Be2aQxn8H2wo+04MpZrUW4hzLhmi96bRQtqfDFRhw7hyHmwzeP5+H 7LdYSdCmXuBxg7WZp28//Ew7aocT+WXpdJxnclf0iAyBfOOsV5IRthj/ffqSj1r7QTQ1 zVNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6JnDWPB8zPyYC1o9rOiub0T0z17IVTGKFuNGktlGb6E=; b=hjGrEh4/Tk/GFg4K1Z61ucx2QS0x8zIl61qyuHPyY1pQZrlUQYCuxbL4uDxub973Po DE2MVbv5Wd/mjlDpH2TOEGrxYnQ8wX9a8Hm5y/LvALRd2GZ9FOiIzgL+U7pfeYMuAvXa mQ/BMqAAaJq0JxtO7B9ASpdHgW5YP1p0IErQPdfTUJoTLj9w5DBanxSAExGVBrzreMiC gY3/by8V7p0TPCX91sXxkaS6peOTubqp2tn2C9svcisPZRW4T3TKAstBGGVJN8enjhO3 brxjgLLQ12BrWKrfstTFOI5Qc4AdGPB9aij6pbkowIQGa5ODGLX3Rdj0Bd2Tc8SWrUEC e/3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=JiTLGNM9; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a170906268300b00770d9e664f8si375820ejc.152.2022.09.07.06.03.44; Wed, 07 Sep 2022 06:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=JiTLGNM9; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229513AbiIGNCt (ORCPT + 99 others); Wed, 7 Sep 2022 09:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiIGNCs (ORCPT ); Wed, 7 Sep 2022 09:02:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A13FC66A6D; Wed, 7 Sep 2022 06:02:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2434AB81CB9; Wed, 7 Sep 2022 13:02:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B20FC433C1; Wed, 7 Sep 2022 13:02:44 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="JiTLGNM9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1662555762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6JnDWPB8zPyYC1o9rOiub0T0z17IVTGKFuNGktlGb6E=; b=JiTLGNM9yFxC+uSqY9TSUolPey46SAPlKdXUh1Jlw4KXJx10ckJLg/RgnEeaeOFXdFmU/8 QXSDvt3HBY/GNCtvuA2Gp+CINuuH90zfiqlhMDWrVRS9KPAEqhlQSRr0dhvz4JxadMTnGN BLX8JDcPy7imp+VNqa0D33ELJIYyfZs= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 937252bf (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 7 Sep 2022 13:02:41 +0000 (UTC) Date: Wed, 7 Sep 2022 15:02:34 +0200 From: "Jason A. Donenfeld" To: Dominik Brodowski Cc: linux-kernel@vger.kernel.org, Herbert Xu , linux-crypto@vger.kernel.org Subject: Re: [PATCH] random: use hwgenerator randomness more frequently at early boot Message-ID: References: <20220904101753.3050-1-linux@dominikbrodowski.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220904101753.3050-1-linux@dominikbrodowski.net> X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Dominik, On Sun, Sep 04, 2022 at 12:17:53PM +0200, Dominik Brodowski wrote: > Mix in randomness from hw-rng sources more frequently during early > boot, approximately once for every rng reseed. Nice idea. > Jason, if you prefer that this patch can be applied first (as it > makes sense also independently of the other patch), this ordering > should be trivial to change. I'll apply this patch first, yea, since it's independent. > -static bool crng_has_old_seed(void) > +static unsigned int crng_interval(void) crng_reseed_interval() instead? Jason