Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 15:04:53 +0200
From:   Dominik Brodowski <linux@dominikbrodowski.net>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-kernel@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] random: use hwgenerator randomness more frequently at
 early boot
Message-ID: <YxiW9doIXhbZBd+V@shine.dominikbrodowski.net>
References: <20220904101753.3050-1-linux@dominikbrodowski.net>
 <YxiWajR2FEW6YRud@zx2c4.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxiWajR2FEW6YRud@zx2c4.com>
Precedence: bulk

Hi Jason,

Am Wed, Sep 07, 2022 at 03:02:34PM +0200 schrieb Jason A. Donenfeld:
> Hi Dominik,
> 
> On Sun, Sep 04, 2022 at 12:17:53PM +0200, Dominik Brodowski wrote:
> > Mix in randomness from hw-rng sources more frequently during early
> > boot, approximately once for every rng reseed.
> 
> Nice idea.
> 
> > Jason, if you prefer that this patch can be applied first (as it
> > makes sense also independently of the other patch), this ordering
> > should be trivial to change.
> 
> I'll apply this patch first, yea, since it's independent.
> 
> > -static bool crng_has_old_seed(void)
> > +static unsigned int crng_interval(void)
> 
> crng_reseed_interval() instead?

Sounds good. Thanks!

	Dominik