Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1673872rwn; Fri, 9 Sep 2022 02:09:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR7T4NwF+54d9zZ3AYoEPZVRYUKovHUGqSisQopsO6eGOloMTscofpmRyzZDl6T/1U1167jT X-Received: by 2002:a2e:9d0a:0:b0:261:85c6:efa8 with SMTP id t10-20020a2e9d0a000000b0026185c6efa8mr3897787lji.477.1662714543559; Fri, 09 Sep 2022 02:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662714543; cv=none; d=google.com; s=arc-20160816; b=ajCK1TYH+nnBq9CmQQpUIFVKvDo5ADEBS2TdDDRlt/BVdiyuPcFmr6P5tCwlD1ayfW bbidVtWI704QTXkVU87OPt7lHsve1+V6ACv0drwDS/hD4X2DaogoigbQIjFWVbmsSzh7 pfiLZIO1r7CrbyDPH9CR2dHmwCjxlQGU/qnD1p5uGYDpMcP6b4HW4Nak5cDRkEZyrq45 qJZMgqXWZ+KxabEt7vH1xTAShZpcyWaycfvVfTe7WBck/hehz7cNygd9xJbbVy0SBHSr AhdyKbDKHXIiwL+1QqCo9CnZkQJBj/AaCWpV4XUlmhmkBBjDcGcG5+EYUc/E2O7B/PAr /Uvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=eFHfea9ilM7oVY6T0q6/Wwx7OMGU1Zza/sonXD/VBr4=; b=V4mJPtxCwZ5OkY+XetXLVXNoAookyf/ts4cea6+IP99wB8aSeLtYgoPjyWyqX2CNwF E15ssAAuCklucdqdp2koRexILFh6yUZ/hYd2mqkvTymFg+bh6DiOdYueFUiJPK10131h b9OTWydt9SXODsiMwTutJ+WI9+qNObIl5ZELlFDarFP3jny00PRJoMsgcXKYCFqGAGs9 naP35+ZaXE9KpS6Wi0kdZgJ0IHnhhkWodM6t3pCnwe0TlTxlMJ5dXFbkqoMx5KdbPW6o Uteh0amvqbm3ELdizkwjubWf8adXmJpzTCJOn4Wf1wNP0uH2lOW+iAvjZkHV9tKk27a/ Q4ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y30-20020a05651c221e00b0026aa4eef498si599287ljq.543.2022.09.09.02.08.31; Fri, 09 Sep 2022 02:09:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231796AbiIIJHu (ORCPT + 99 others); Fri, 9 Sep 2022 05:07:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbiIIJHi (ORCPT ); Fri, 9 Sep 2022 05:07:38 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75714B9F8D; Fri, 9 Sep 2022 02:07:33 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oWZyY-002oCL-6i; Fri, 09 Sep 2022 19:07:03 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Sep 2022 17:07:02 +0800 Date: Fri, 9 Sep 2022 17:07:02 +0800 From: Herbert Xu To: Sun Ke Cc: neal_liu@aspeedtech.com, davem@davemloft.net, joel@jms.id.au, linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] crypto: aspeed: fix return value check in aspeed_hace_probe() Message-ID: References: <20220830031347.810217-1-sunke32@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830031347.810217-1-sunke32@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Aug 30, 2022 at 11:13:47AM +0800, Sun Ke wrote: > In case of error, the function devm_ioremap_resource() returns > ERR_PTR() not NULL. The NULL test in the return value check must be > replaced with IS_ERR(). > > Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver") > Signed-off-by: Sun Ke > --- > drivers/crypto/aspeed/aspeed-hace.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt