Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1674587rwn; Fri, 9 Sep 2022 02:09:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR7u8x8q0aOozcQglNtHjmYrYeNHPywyGAWDzjthSBYxRVwCQJSwwJXhpRbjY45Nr68lzOv2 X-Received: by 2002:a05:651c:224:b0:263:d040:9d91 with SMTP id z4-20020a05651c022400b00263d0409d91mr3464929ljn.419.1662714595244; Fri, 09 Sep 2022 02:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662714595; cv=none; d=google.com; s=arc-20160816; b=TFb31+yUrKGad8hnDQFIkcojeClFXeOgRKv6Oi5vpHe9L0HuzR9b8qNmyninyvm1sb yy1jNW39QqKov44+WTeto0ZibWZwXv6PMxcgNaNPRC2nTpEpKRdyx7/VSRTlYVrBh2az DfJ0s9sDpZHAZEG2A7c0FbsRQGMdPy++iiNuEPO1DfBr+s5TE8xHUo6YNg+oe9ecY2sM rk/d9OJLPJmiNqrS6mL6GVv8WXntOZoH+9IVD0wOQuRM2PfX5A07PA820/xQNOV6blJI IVCUzSN4FokViEBg/YAvWL+/zOH5hgt4ymhJ0B3f/qSj5nMb+ecOhOY7TUjP/J4db3Me q/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=OYR3ITeI+Tb1/IHZNfABu7VEPDsZPnuQl9b2ipZiz5A=; b=YYD4FHwNlogV0ODHCwqs1dDTnHi1BgrGgqvugFWet3T7spvJWqFko80zIv3F1aqLiS zmGKmXE+nmlMPOVSFjYQ0Es3UxFCBoo7afzOYllP94jhyfrEl0/WA297+OOA+6ZRII/Z OI3zkiqPwvqrXvUfwFlS5f8XoEmu+a6+jfaqLtBm/5vClELgEnBlrXcRqqY+dn4OMdrW 9jJ9lwousThGb+hQbsfsopyoYX8G4rRICXWQ6w7hT8sCVvmJ/ZRpExyein34AK5FbRZp hIKEHx+MokiC79f+q/6vpuiNY6Ur65xV71/c8BVDa8mJMytLpmli7LNS7qnR/yNen5jh 9Rgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020a2ebe13000000b00261cb628f64si16880ljq.187.2022.09.09.02.09.27; Fri, 09 Sep 2022 02:09:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231355AbiIIJIx (ORCPT + 99 others); Fri, 9 Sep 2022 05:08:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231797AbiIIJIe (ORCPT ); Fri, 9 Sep 2022 05:08:34 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5424A024B; Fri, 9 Sep 2022 02:08:31 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oWZzp-002oF4-Td; Fri, 09 Sep 2022 19:08:23 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Sep 2022 17:08:21 +0800 Date: Fri, 9 Sep 2022 17:08:21 +0800 From: Herbert Xu To: Koba Ko Cc: Tom Lendacky , John Allen , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] crypto: ccp - Release dma channels before dmaengine unrgister Message-ID: References: <20220901144712.1192698-1-koba.ko@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901144712.1192698-1-koba.ko@canonical.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Sep 01, 2022 at 10:47:12PM +0800, Koba Ko wrote: > A warning is shown during shutdown, > > __dma_async_device_channel_unregister called while 2 clients hold a reference > WARNING: CPU: 15 PID: 1 at drivers/dma/dmaengine.c:1110 __dma_async_device_channel_unregister+0xb7/0xc0 > > Call dma_release_channel for occupied channles before dma_async_device_unregister. > > Fixes: 54cce8ecb925 ("crypto: ccp - ccp_dmaengine_unregister release dma channels") > Reported-by: kernel test robot > Signed-off-by: Koba Ko > Acked-by: Tom Lendacky > > --- > V2: Fix the unused warning > V3: Fix the Fixes: tag. > --- > drivers/crypto/ccp/ccp-dmaengine.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt