Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 17:35:41 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     'Guanjun' <guanjun@linux.alibaba.com>
Cc:     elliott@hpe.com, zelin.deng@linux.alibaba.com,
        xuchun.shang@linux.alibaba.com, artie.ding@linux.alibaba.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography
 Complex) accelerator driver
Message-ID: <YyRDbT0fQQwsVpKL@gondor.apana.org.au>
References: <1662435353-114812-1-git-send-email-guanjun@linux.alibaba.com>
 <1662435353-114812-2-git-send-email-guanjun@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1662435353-114812-2-git-send-email-guanjun@linux.alibaba.com>
Precedence: bulk

On Tue, Sep 06, 2022 at 11:35:45AM +0800, 'Guanjun' wrote:
.
> +static const struct file_operations ycc_fops = {
> +	.open = ycc_cdev_open,
> +	.release = ycc_cdev_release,
> +	.unlocked_ioctl = ycc_cdev_ioctl,
> +};

What is this device for? It doesn't seem to do anything so why
not jsut drop it?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt