Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fdf50b63-2793-d0bb-04d2-aead6523ad91@gmail.com>
Date:   Fri, 16 Sep 2022 19:44:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v3 2/3] crypto: aria-avx: add AES-NI/AVX/x86_64/GFNI
 assembler implementation of aria cipher
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        jussi.kivilinna@iki.fi, elliott@hpe.com
References: <20220905094503.25651-1-ap420073@gmail.com>
 <20220905094503.25651-3-ap420073@gmail.com>
 <YyRPVxdZSAqvAXoL@gondor.apana.org.au>
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <YyRPVxdZSAqvAXoL@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Herbert,
Thanks for your review!

2022. 9. 16. 오후 7:26에 Herbert Xu 이(가) 쓴 글:

 > On Mon, Sep 05, 2022 at 09:45:02AM +0000, Taehee Yoo wrote:
 >>
 >> +struct aria_avx_ops aria_ops;
 >
 > This creates a new sparse warning:
 >
 >    CHECK   ../arch/x86/crypto/aria_aesni_avx_glue.c
 > ../arch/x86/crypto/aria_aesni_avx_glue.c:34:21: warning: symbol 
'aria_ops' was not declared. Should it be static?
 >
 > Please fix.
 >

Thanks a lot, I checked it with C=1 option.
So I will fix this in the v4 patch.

Thanks a lot!
Taehee Yoo