Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     YueHaibing <yuehaibing@huawei.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        Johnny Huang <johnny_huang@aspeedtech.com>,
        "dphadke@linux.microsoft.com" <dphadke@linux.microsoft.com>
CC:     "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] crypto: aspeed - Fix check for platform_get_irq()
 errors
Thread-Topic: [PATCH -next] crypto: aspeed - Fix check for platform_get_irq()
 errors
Thread-Index: AQHYzKASz5W956DPPkSernGxRLDZAK3nyTnQ
Date:   Tue, 20 Sep 2022 05:24:58 +0000
Message-ID: <HK0PR06MB32020D94813ECDFE5F16B900804C9@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220920032118.6440-1-yuehaibing@huawei.com>
In-Reply-To: <20220920032118.6440-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CePbIgUKEzkpz31Cd4JIWn8mp42VeV3DISLyDhe1/UFy22RNrUcVi8plxTEV?=
 =?us-ascii?Q?RzBP/vhnaPeYkSuo1//fCqrQvRIsY4xzdtU/H3InheYTsCiHCOuVY9syyITM?=
 =?us-ascii?Q?EQ4vxpbaAsJUT2iexrFuKekzSEdDRn6xyC1dB4W7b/MDdY4JeRrUAqC2MOJQ?=
 =?us-ascii?Q?OlIm+k4B5IqfEDEcZ1EL8nSmj0quYc6/hGtfGz1K+HAKeCxCZhl9hca77Edu?=
 =?us-ascii?Q?tol3WHcGls2E5wX2iyKv7iNEv/VgUfsTCq8YlEZA8ggotLwLARrWiTgaV2a4?=
 =?us-ascii?Q?29rb72ITcJIHu17n4wWWf2KzX+dxysa1JSTb007sPHeAvyScNLMe6TH01ObH?=
 =?us-ascii?Q?R6g/LSu0XP6hjLdbMgWB2kPrJOlyeHTM/IIlwc+B66Pwm67i8D+h1Y9r2LtR?=
 =?us-ascii?Q?PMb8GDsiHabm9ReP0727n6mzzf4bnZg+b8t6rR2wcC4Q1wNd/jMySSEKZBoE?=
 =?us-ascii?Q?L6K67xg6+OUFxxuVQHx9Rvc4i1Bx0L7iifZW/FE04RmUjul/6kdFfkYQP41E?=
 =?us-ascii?Q?1izX27wLasXCnDm7O4GNfkaMBpOrjOLstvl129PVjdEpBYFpFJGT4aCT1DJB?=
 =?us-ascii?Q?N/LTh47PcgFc6yw1fcIse1dgarXqbZojdb2Ft6aBDCyRmVxorr4nU8VGPCmK?=
 =?us-ascii?Q?drAB5XlRDMnXHeYuq4+zPcuDGWXht7FmBMZHcJyn6xlMXiUYQhef017EpAzM?=
 =?us-ascii?Q?CnOZl/oB2MXs2cmWcgG4vQttFwRXT7xc2j7pe3eKrVjyn8MYt8k2xKDySepb?=
 =?us-ascii?Q?7x/9/fs7daU4Fwl7udQvfb8H02/vRjepum/TDDJh8Kn3BvMdehZ6d8G+TlcS?=
 =?us-ascii?Q?3GYlO73vezebU/ikB+LjKsrojRJPpbIPrARh28MADwsQu9qGM/RZsIH2khQV?=
 =?us-ascii?Q?L+68opR2x5sYul0qUP6dVkZ+qkf1LpEGALWQJ/O4cGI7VB1R7Vcj/czv8pRZ?=
 =?us-ascii?Q?84B/DKzsieIR4cCbL031q1SHu06kM5/6S3i7jROpvtyyglzKsCj/wJFmkyCg?=
 =?us-ascii?Q?O5bHlqrLKDtZAgTVHiqFfnFSuA8Rdfl3DwlElqVi72VIL99mp4hgeNipAdRu?=
 =?us-ascii?Q?XmLDdYBH5kzsqQIIS5vXK3CGM/x7in5fzSHgyrjEw4WRGgObyuzS1rqiOQn/?=
 =?us-ascii?Q?tdxDl6+mzd7IX+PyGIVrOZdhRhOZTQMfIXvB0bK54mC8fJdPCUHDxr9cBpWt?=
 =?us-ascii?Q?pRKVYeFCYoExQ41zydvaN+39KpXy0k8UBkSgFdi4x5kymgYmZmERd+YQQL1q?=
 =?us-ascii?Q?foJ6F5Oz2as/BHgbIW60a63IpgnuVfzyBr2xBTnqlsXJEtL5ANcdwlEx1Acw?=
 =?us-ascii?Q?zyWLEHs+bWJHGB3zjRMg45Q7UuWakJHq4qNtMie8PfDhJ6o1dCH0iUbh8K0o?=
 =?us-ascii?Q?ypM7DW9YmAsGE1lREfhFsVxM9PYd220dSWBti6kLpv8+oby9OV9bSmxUxYJL?=
 =?us-ascii?Q?mn0zQ49FHtnpadBkMfAlnSbyB+96eJJ+q0fxcf8m7sEEkb5QQWlFOf6jTuY1?=
 =?us-ascii?Q?9uEC8MLwgi/FGVG4b3hLKrbpYIOCJWN0BdYKqI3Dqyt9Lt32BPxoWfAq6Gi6?=
 =?us-ascii?Q?J1BUH4q1LGy4SaRcXcidtgpa6g9sgbh2u5YyR0zj?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8424e262-ec0b-4e5d-78fd-08da9ac875e7
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 05:24:58.7962
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tYUbsqwc7l5micGCjgSEY2paiEmjJnuPbt3s9GuxbjpwAZOQsn8acLv6YR7Av5TdSany/py7euZ2/XgZWAVZbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4156
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> The platform_get_irq() function returns negative on error and positive no=
n-zero
> values on success. It never returns zero, but if it did then treat that a=
s a
> success.
>=20
> Also remove redundant dev_err() print as platform_get_irq() already print=
s an
> error.
>=20
> Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>

> ---
>  drivers/crypto/aspeed/aspeed-hace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> b/drivers/crypto/aspeed/aspeed-hace.c
> index 3f880aafb6a2..f7f1d33defb1 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.c
> +++ b/drivers/crypto/aspeed/aspeed-hace.c
> @@ -130,10 +130,8 @@ static int aspeed_hace_probe(struct platform_device
> *pdev)
>=20
>  	/* Get irq number and register it */
>  	hace_dev->irq =3D platform_get_irq(pdev, 0);
> -	if (!hace_dev->irq) {
> -		dev_err(&pdev->dev, "Failed to get interrupt\n");
> +	if (hace_dev->irq < 0)
>  		return -ENXIO;
> -	}
>=20
>  	rc =3D devm_request_irq(&pdev->dev, hace_dev->irq, aspeed_hace_irq, 0,
>  			      dev_name(&pdev->dev), hace_dev);
> --
> 2.17.1