Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3966333rwb; Tue, 20 Sep 2022 07:09:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7/eb0KmyNUPwvIBF1hGYusPPpLl0NO9VLWV3ecv9X2vKidpYCYrY3PIfGFByQgneB9NvDm X-Received: by 2002:a17:906:cc59:b0:779:f094:af3d with SMTP id mm25-20020a170906cc5900b00779f094af3dmr16641471ejb.239.1663682980627; Tue, 20 Sep 2022 07:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663682980; cv=none; d=google.com; s=arc-20160816; b=Cw41Kg3xsCiAuSDxoqAoQ9QN8DplzGBaCVztYD8oXTp2nVP9gYFKKv7UmLAoB9NNk5 buwXZajBJ4LGDH2ZRzh3X6DFgd/7EnborU4bHeLvPP8bhapRUY5/Jh/G27JGR/t+EcQN rk0ZtEY/Z6ZS70wBTvp6AthDL8ddhKuHKUMxcaK7LxMOCd6Q1bi1mW9sQ8+WCgC4w0k4 jpvEsFaORPHA7ynXtQG4TByn8jEqEpPlpsUP6IAt16qcWtmZcfYkC04QX9QirbGbvwj0 rT4oK6+6puyYJL5BwekstXjDqRCzDRBrwrBXmFyUQ3jlcVWsbmJ3BQLpt8bgFCoJi4A2 YM+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UxdIT3N09KsqckiSbe/NvyvNSdoIMMBwrOEJCizvJpo=; b=CXiA7gT+5mTTNCRwQYcv1ArX4RPtaxHLw6WiP95WKAOQk3rzk/2MDK1MPsrBLlNO3p mm3ZbAps0+cjCBSYplb2P/0Ze1d0aR1PMz+gVlHE3LsEpaTsLUI0Q570B0N9aWL64Tlh 9NwxfsKergQM0dpuDS1sXaPy0tQthGGYBGlVIMIh9g4DzFuHTsMqcUkcAgfinFy6oBQZ Ba7fRB4DbsftUJ5Z2Y5+GAK7yN8+IJUQBfmmP/AS3E1t17rZHFIwPPu/nPeEcLh1qLPh SFqW62GoJaDiFQZzDwZdncMSfOiFhmGfSgIdWGrYjaoa9jL8G7nPV86UND9xh1v4R2uM C2vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=OG8msomf; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020a056402500a00b00451489ff9e7si149247eda.204.2022.09.20.07.09.04; Tue, 20 Sep 2022 07:09:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=OG8msomf; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbiITOEM (ORCPT + 99 others); Tue, 20 Sep 2022 10:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbiITOEL (ORCPT ); Tue, 20 Sep 2022 10:04:11 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E38232DA9; Tue, 20 Sep 2022 07:04:10 -0700 (PDT) Received: from zn.tnic (p200300ea9733e791329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e791:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 42A471EC00F4; Tue, 20 Sep 2022 16:04:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1663682644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UxdIT3N09KsqckiSbe/NvyvNSdoIMMBwrOEJCizvJpo=; b=OG8msomfvFRFV9h3zLBfUDcULQo18fC9SQfmUXStEGVHnVEZfxdSTH1x+T966I7DiYxTNI zqviVHAhV/iBK8leiTrSHyB1VB7J+QX88UY2i3mug6eBVVaSVnM1xzd9XIwgSSFLkOQomr 6qM4pMYQXH7yq+Z49OOoOIov0lQVJYA= Date: Tue, 20 Sep 2022 16:04:00 +0200 From: Borislav Petkov To: "Kalra, Ashish" Cc: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "Lendacky, Thomas" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "pgonda@google.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "dovmurik@linux.ibm.com" , "tobin@ibm.com" , "Roth, Michael" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "marcorr@google.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "dgilbert@redhat.com" , "jarkko@kernel.org" Subject: Re: [PATCH Part2 v6 11/49] crypto:ccp: Define the SEV-SNP commands Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 20, 2022 at 01:46:25PM +0000, Kalra, Ashish wrote: > These are structure definitions as per SNP Firmware API > specifications, and they match the SNP Firmware commands and required > arguments. Yes, I have the spec. > Isn't it better to have 1:1 mapping between specification and > structure definitions here ? Why would it be better if you can have a single struct serving multiple purposes and thus less code to stare at and deal with? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette