Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Harliman Liem <pliem@maxlinear.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "atenart@kernel.org" <atenart@kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        linux-lgm-soc <linux-lgm-soc@maxlinear.com>
Subject: Re: [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is
 zero
Thread-Topic: [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is
 zero
Thread-Index: AQHYwZuhWToE3i/+MkuyVhPHlEoUrQ==
Date:   Fri, 23 Sep 2022 02:35:44 +0000
Message-ID: <DM6PR19MB316310D792AC2839F7A1A5DEA1519@DM6PR19MB3163.namprd19.prod.outlook.com>
References: <de6de430fd9bbc2d38ff2d5a1ce89983421b9dda.1662432407.git.pliem@maxlinear.com>
 <Yxg/lipSWadoeD6E@gondor.apana.org.au>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ej4EK3FrZpTiGNtUIl0A0zzwOr7YViq+8Bq1Ah+Kn53px3mZPAVhSLYs4wMZ?=
 =?us-ascii?Q?JGyuVf+CMSI5gDtBzKNHLgJ/66fvcMJ0A1EsELec2WnrMZwq/G7AZ46X9IKJ?=
 =?us-ascii?Q?f7co4S6mbl4U5N2+v/O2j+9okb9w3EqSzu4IQqKJMiZ2VJ/w+2fUy+Dx4yt1?=
 =?us-ascii?Q?ePCvqc2UCsCLM66//BTxWcXiJm0zfOeaMzq5RRqF1oeLBdHg51n1X2cQnV/F?=
 =?us-ascii?Q?JwXYGqrHHAcybPzN73N7h8cAzjLrlX/rSI+yk15c163ZFf1fwneaskQEPTlX?=
 =?us-ascii?Q?A7FWjWxEB2a1/3rdYdskbl2ozLvVksriyLWw0JPVxXJCot8CH5EuGLDeptk/?=
 =?us-ascii?Q?y6maWTpvF+r/w3fctiNLtHfKOYPX8QCWU287ephSK/UFZ/yuO1E+5wtDLow9?=
 =?us-ascii?Q?vjKVUcS8y3deG7eaXoNqQG6wN2/9uCNW7nuBx5JGc8n0um0SSyaPHpZMgGrG?=
 =?us-ascii?Q?TrUtBN9NFXDnCoUVmKhg778RBpy2qIXsJbGd4oX6oU0658YqjG+Xo0j9QxO9?=
 =?us-ascii?Q?vCMXI5L3cveUL+dv7LPG/vIvqKqvEOYHonpPnNEQTpkoaI9ONjaUp1Tv8ycq?=
 =?us-ascii?Q?s+qCXi1YRPB1g0h7fx/W0hhWfs6ilPnWK+bqaZVdndRG3i9XH/B/ABa5yLGj?=
 =?us-ascii?Q?RlUUN0OViBevEoLW39Xzgi3+XjU3BfM6nKXOBoUjJEkO91IXy71I6U7Eu63m?=
 =?us-ascii?Q?vXg92bcZVxBOfnNr+6u+uO89/qL2uwk2StYqDjrdoGPYi+fIrpF71UZ59md2?=
 =?us-ascii?Q?fRemL3DdnRciF83w/4CFfcFLriJ9fOeCSVbZVLOeslrFRwfwMx2PP7jfWtYV?=
 =?us-ascii?Q?ueQTMqYfOC2+vme87Epk5+gO4pp5UV/9dr8rxt2PF98Nr/2LNHqZoEpwIA3+?=
 =?us-ascii?Q?sYpCt1R72CZzI8gdlN/595+3qqkdTT6RpZnwneqF8gjXTFK4/8bVW9+Xc1/t?=
 =?us-ascii?Q?KLBvobdoxFUd+vAgujyYqhiNPAaUVqdXKnIsAbCAuGmlKra5DoCVAMnEn6u2?=
 =?us-ascii?Q?JPz2nKnZss3+I31d+1DB75dQVzih31e6KI8uO6GNuqbZgCC1FX/3og6WamVi?=
 =?us-ascii?Q?L3E7EVHfUfvM+zlG9/VK7yGe79IX+iCebOImcNTNfqk9ifmJh2ludGjtCnkp?=
 =?us-ascii?Q?9oVayK4+G18QJKIwbvQCdrLH8b7NyGnOWmNtQUbIu/TGUZtJgQA+3eL0BnBn?=
 =?us-ascii?Q?MaZbyARG2VT8+J773jbaKj9/OYuBt1dttEt11ZUqY84/dRC1HfB8AYoGarm4?=
 =?us-ascii?Q?+sEu1YvcYN38cqkryHX5ekeBj6HLmcQlJ5GXxvYZwoN4J52YKqFHCDCvFVKu?=
 =?us-ascii?Q?QGw1fm3HY9d5y2cwUOPLZCudKfYf02PNO1+F5IaWhbWOewUvmqVc/03w7sCS?=
 =?us-ascii?Q?nP0NBN2JWIHT4ntZ4neI8ChEewnAWBk2gz5rKG8AAmgSXFeZiw6vS+oHt8Pn?=
 =?us-ascii?Q?zvEX98Alnf2JF5Foi3x3ZV9mUV011TWAAEXRhRwtPslkGj+5/2z9TtUtUhwa?=
 =?us-ascii?Q?3DtAP06x5UUQICz80w5VHwyf8ypeInreW+AIi/LYJxon8HHEuqNZshahbOdD?=
 =?us-ascii?Q?vz9dP3T0v0Fp5B3xa3r9YE1/OxZ8apR+MS1Mpm3n?=
MIME-Version: 1.0
X-OriginatorOrg: maxlinear.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB3163.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70b92c64-2d4a-4ba6-1c2e-08da9d0c50d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 02:35:44.7320
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dac28005-13e0-41b8-8280-7663835f2b1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t39yUwMqs+zlOB/bz8Xc3LPLW8rzV1YQSFx/t667ZAS1NmUp6PUVGbr2pcRPB9hHumTEu0oBYTe0UdqINqezGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR19MB5668
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: maxlinear.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 7/9/2022 2:52 pm, Herbert Xu wrote:=0A> On Tue, Sep 06, 2022 at 10:51:49=
AM +0800, Peter Harliman Liem wrote:=0A>  >=0A>  > diff --git a/drivers/cry=
pto/inside-secure/safexcel_cipher.c=20=0A> b/drivers/crypto/inside-secure/s=
afexcel_cipher.c=0A>  > index d68ef16650d4..3775497775e0 100644=0A>  > --- =
a/drivers/crypto/inside-secure/safexcel_cipher.c=0A>  > +++ b/drivers/crypt=
o/inside-secure/safexcel_cipher.c=0A>  > @@ -737,14 +737,17 @@ static int s=
afexcel_send_req(struct=20=0A> crypto_async_request *base, int ring,=0A>  >=
 max(totlen_src, totlen_dst));=0A>  > return -EINVAL;=0A>  > }=0A>  > - dma=
_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRECTIONAL);=0A>  > + if (sreq=
->nr_src > 0)=0A>  > + dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIREC=
TIONAL);=0A>=20=0A> Where is the corresponding check on unmap?=0A=0AAdded i=
n v3.=0A=0AThanks!=0A=0A