Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Shang XiaoJing <shangxiaojing@huawei.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
Thread-Topic: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
Thread-Index: AQHYzy7BVRa5ZEilMki2NU7nDjE7P63sy+dg
Date:   Fri, 23 Sep 2022 10:15:23 +0000
Message-ID: <HK0PR06MB320294D6E2A61F85F4276EE780519@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220923100159.15705-1-shangxiaojing@huawei.com>
In-Reply-To: <20220923100159.15705-1-shangxiaojing@huawei.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uLKg6D+3Y6hJMNSjHjXEVD6A5NvO7hBmElxIW8yvqv7emVSEdyHgv92p0Lo/?=
 =?us-ascii?Q?Db8ZOTHS1NOrPxySeA+6C7ZkMxQQuUx/pgY0AQjeRoqCuWzUQWiAhpMUsxin?=
 =?us-ascii?Q?Ob8lRLaJeuUV+TtouBWggnvPmO3S2C7XRV6x3BsPmoO8zMA5/Y8lofvkYa8i?=
 =?us-ascii?Q?rQ7onn9fU9pGm7xH/h6gXSpIQWMS40+nAi51NWN00k80YaLa5oAK+heqQyV2?=
 =?us-ascii?Q?h+5j4D5sK+pqkAVSS7ofP+aIlob+ZQ9WtA5FXnBBdLTSkS7PZLObG1qcy656?=
 =?us-ascii?Q?tvL0+2cKAjbEwWnGjdSRg0RqUQa8w+JlSI7oOqRj+n8/Lr2NJvmBSyny1441?=
 =?us-ascii?Q?igpSNnEiW3gpMNlyFoVtjs5kQPQj0m8OoIoH0fX1OdFvSzZsCj2tq5YIASjd?=
 =?us-ascii?Q?hvcCFiWrH3+yJng5x2We0qz470gMDKnYUfO1dNoXKj3LTic3BsLU41R7MEsj?=
 =?us-ascii?Q?UiU85aDkC5Q/DHvLC/BhTgKseQf0HU6lJMD5DNCKweD7C3/Gr9Gyls0dx1xS?=
 =?us-ascii?Q?iXv75Ay/p8AjwxPGYxzi3QBnBkyfQuLPzdB6ByNJTT6rviRZP8cHhFKxSDbd?=
 =?us-ascii?Q?PV6pzsXSPu7qoj5V0o/kigWNreJhtu/DaBN5BOSTTE5f/H0d/0EPL14zH0ny?=
 =?us-ascii?Q?M8Si0qE7pMjiIZ18oKju9xm78OQVPnPxkxpSlthJybnpNJw1ZRX5BQiaX+qO?=
 =?us-ascii?Q?g8X8pPxgn2ILtgArcYsrQrpvvTO4YjAENVG59x2gAvc7CleUUV7uqH7fN3T+?=
 =?us-ascii?Q?MzwoaCR5GXG8Bi6GuCtYDpBvaX+LWnSnauQ0S5+FonkwMRcoALX0Fwvq9dqF?=
 =?us-ascii?Q?dzDMzCJGyl2c+/r1EAhcTlG0aFXSNsc6DO4tLxnb2V+rQGCTiitwxQwbd7E0?=
 =?us-ascii?Q?/hQPUEr5jO3g+v/sWs7adC+oS7w2FYzvRtNG7jHPhQe90L2eU42xHLqU8wQY?=
 =?us-ascii?Q?dHL4OzimreuPPPFgU1jtU2As1jjVNL6ade3N/Oms2hTLGjEB/3vGcKTihgUP?=
 =?us-ascii?Q?UevrMmX9CQZsN3KHWYq2sJjzSeAGHxhW8rYzHVVwmlcd1G61OpZq2yNNMRSN?=
 =?us-ascii?Q?E4rwoFJHRtCynKBKgLoLobJURhgkydRYF2++PQOQ+ZKpraqJey3cwru1pOIb?=
 =?us-ascii?Q?cU66R+WDLJuahB5HH9jXrJRVhIu4P4i6i08/jgaVujWNvMzuv/O3jUPRAFHX?=
 =?us-ascii?Q?I/09cK6PiNbvjnbTXd0PFbEq4yBCHk9jGE1lIffz0dbIzpv2YPQBjddGl+VG?=
 =?us-ascii?Q?tYXLpRy/hSh9VsYL2uXOnV0I7X1o0d1GORd02fyFUt4X+jCPu4v9deIZp20G?=
 =?us-ascii?Q?Zj9t/Z7XJy1GNGetKVWoEZdxAk9N4Lg6yaW3sDP7d//B/VOdbGZ5Vru5clvS?=
 =?us-ascii?Q?KHqykvpAzwTLJrHl2Ylisu9gmj+BtmA19j7NzWocG1O74C+0F3jZVEmKdFUB?=
 =?us-ascii?Q?rnAUb3VXfFys12j4gcTetI3X+VWc4QGWi+L5D07bUNT/N6JNKip54wccM50r?=
 =?us-ascii?Q?FhBcmyPqncfGcD1vZklX5wogUAUpLdX3NlpQ/jMLrvhS//Bk4a8Ktcma2GIg?=
 =?us-ascii?Q?XIvA1sIJ1mCAhCllF4vHNWjwOokPP7f1IB1VFaVH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3be3a671-a5cb-4469-d9db-08da9d4c8722
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 10:15:23.6161
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RN+2wepURjxceqMCuwJzFN7D8sSorT6M3HW8EK4cLtJzC6GHH74WqOUM3AXWfItE/evPc8B6SUiwuCWAQkCGYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4073
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> devm_ioremap_resource() prints error message in itself. Remove the dev_er=
r
> call to avoid redundant error message.
>=20
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> ---
>  drivers/crypto/aspeed/aspeed-hace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> b/drivers/crypto/aspeed/aspeed-hace.c
> index 3f880aafb6a2..e05c32c31842 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.c
> +++ b/drivers/crypto/aspeed/aspeed-hace.c
> @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
> *pdev)
>  	platform_set_drvdata(pdev, hace_dev);
>=20
>  	hace_dev->regs =3D devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(hace_dev->regs)) {
> -		dev_err(&pdev->dev, "Failed to map resources\n");
> +	if (IS_ERR(hace_dev->regs))
>  		return PTR_ERR(hace_dev->regs);
> -	}
>=20
>  	/* Get irq number and register it */
>  	hace_dev->irq =3D platform_get_irq(pdev, 0);
> --
> 2.17.1

Similar patch just be proposed few days ago.
https://patchwork.kernel.org/project/linux-crypto/patch/20220920032118.6440=
-1-yuehaibing@huawei.com/