Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Sep 2022 15:31:01 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     williamsukatube@163.com
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        williamsukatube@163.com
Subject: Re: [PATCH -next] hwrng: Remove duplicate include
Message-ID: <Yy6yNaTVnwvHaN8U@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220917095505.5646-1-williamsukatube@163.com>
Precedence: bulk

williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@163.com>
> 
> In file: drivers/char/hw_random/core.c,
> '#include <linux/random.h>' has included at line: 18,
> now it is duplicated include at line: 24, so delete duplicated include.
> 
> Signed-off-by: William Dean <williamsukatube@163.com>
> ---
> drivers/char/hw_random/core.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 16f227b995e8..56d171cd2fc6 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -21,7 +21,6 @@
> #include <linux/sched/signal.h>
> #include <linux/miscdevice.h>
> #include <linux/module.h>
> -#include <linux/random.h>
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>

This is supposed to be sorted so please remove the other inclusion
instead.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt