Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp81369rwb; Mon, 26 Sep 2022 15:07:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM54d8AstuloQ+M4zJKR6xU9sOWe6cylGYDGva1oDgXCqE9bOF6yJK4+TrMpltHQS5Bs/k6b X-Received: by 2002:a17:903:130f:b0:178:b6fd:7eb3 with SMTP id iy15-20020a170903130f00b00178b6fd7eb3mr24000929plb.82.1664230064541; Mon, 26 Sep 2022 15:07:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664230064; cv=none; d=google.com; s=arc-20160816; b=ruMIpDBnDYHIvCCYz+ShmAh2QnVdYYO7iywqDe+XdN4htkHYwni/JldqYHujX7z6bB cu3YZ04O8ohQMUSJqZ7X5rSDw162NQEFlAwv3150JadUnYiwddip3GXQ5WuM5YpJ7w9b y3BhhWBb4FkkAb+EmlM+hIMNzRk1JBNLDklTS39pUyrlpKFY7pi13vJucBDCF2aQRyBN HNwgvS7djlioUb/LGLZHDHk5YBzBDKFbjhbRVeXAWKPWbb4Sn4a1F6RuaKSAq8C7qYVb fDmSXwu2yx4I3I2myagxp7smsG2P/ojGzKGaxuxaDejYtgF2SJUQVAnd14OAvkNHC6oL DPLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jyUZYtxAtN1iTCX6RvQjDGcCuH9kvS5eYzROcFEThqY=; b=BtX+k0ACKCOwdNp3ID2N8eI7UwUWecZWw40g9/gMpGderVrWD0CljtKCeXhmTCFF9N /CocesJ0P7O/qYZQcfnoHjdO8TqXWeZr+nLq4vazRmpxBk7t/TE/x0TZ8tzyd1KkTL87 OLwXwE0JzO9NhDBFmOHKCMT4VFLvS0Xut6h5VhKCI21kiBqfkLtZmMbybBaADfiXVByY HGi5mWn8FL+gHaToDp+/40Z7x+ItKKk4IO1R7p6J6k/2WteGCHHU/jevAfj1vYnFy2yn BSwvzQiEGAJgmLYlzKFk9XK1JPUBAf/lTZQwmSmN00OTn5mFxgjlMkTj2Jqv84EELniG /PKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MzGhAq5O; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a056a00238700b00554245aac47si18959752pfc.283.2022.09.26.15.07.25; Mon, 26 Sep 2022 15:07:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MzGhAq5O; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231223AbiIZWCA (ORCPT + 99 others); Mon, 26 Sep 2022 18:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231231AbiIZWBr (ORCPT ); Mon, 26 Sep 2022 18:01:47 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46BD8E3EDF for ; Mon, 26 Sep 2022 15:01:43 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id q9so7744301pgq.8 for ; Mon, 26 Sep 2022 15:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=jyUZYtxAtN1iTCX6RvQjDGcCuH9kvS5eYzROcFEThqY=; b=MzGhAq5OFEs2Jw3eI9RLQ+YxWhJkO64hQtgKbJilL0PzjLuQEVe9C+/uRy4PdTG8tz bG/i1MUi6O6fNF6xlb8WrrVfZWKq91jRdsDITIW/6qF8KZWGb0TzYKKhR/KIZDGttILa jSjcZeLBLVxe8wgx2SPAqVZWq/GXhl8HuDA9A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jyUZYtxAtN1iTCX6RvQjDGcCuH9kvS5eYzROcFEThqY=; b=clsZ5i3RmJv6ERC//3LA1KlMR4VFommvBpbC7q/GBhZtb5WuHvGE/iWaEq8fnTtxsa w24mJnMDmd3iQ/r7OGHN99F4lkRw2/Ukgliq5nkBEl3hKF3dsXjvvqgtKTiOzuSXiDOg otVvjlpB4WuYhGx2lDO96gZulf8e0oOf7WoeBKvrNWytXh7l3rObb0MejqOybBdDFoZN nr8410vQb7naQxgC3f+Iwhru0hFFxI3+IOvywHfRbQ3lgJMTfvBKvrexr5eN3YUuKzfA 7Rvmf9Ttpfnc+Ne9PliZx9vvMugH7Khv6eXju8B+WkOe+JliLZ462l7TBVtb65fvHsBL 5n0Q== X-Gm-Message-State: ACrzQf1drJCWdudiLA5dMBJe2OOyqgP9m0WSwGmsdlJRjp6qZwtOwSzZ Lo7q1h+QiJzfM4fgEa4QkSbmc3Avicu96g== X-Received: by 2002:a63:91c8:0:b0:438:d55c:4484 with SMTP id l191-20020a6391c8000000b00438d55c4484mr21974518pge.157.1664229702792; Mon, 26 Sep 2022 15:01:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f1-20020a170902684100b00173cfb184c0sm11728552pln.32.2022.09.26.15.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 15:01:42 -0700 (PDT) Date: Mon, 26 Sep 2022 15:01:41 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] crypto: talitos - Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261501.D540C881@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Sep 26, 2022 at 04:45:45PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/216 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook