Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Harliman Liem <pliem@maxlinear.com>
To:     Antoine Tenart <atenart@kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        linux-lgm-soc <linux-lgm-soc@maxlinear.com>
Subject: Re: [PATCH 1/3] crypto: inside-secure - Expand soc data structure
Thread-Topic: [PATCH 1/3] crypto: inside-secure - Expand soc data structure
Thread-Index: AQHYzMc6iqtdBZ+VvU+yV/J0URY7ZQ==
Date:   Tue, 27 Sep 2022 03:16:57 +0000
Message-ID: <DM6PR19MB3163C89AA7963DFA66DB08C4A1559@DM6PR19MB3163.namprd19.prod.outlook.com>
References: <cover.1663660578.git.pliem@maxlinear.com>
 <131f0d802d4e251dd8f98672260a04c2f649440c.1663660578.git.pliem@maxlinear.com>
 <166392414185.3511.12102278740497366855@kwain>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FuHjUBCG1rOr9Xc9oQRXeVm1uHmSUFEcN5Ydm2qVRwn+JpxmdTqZ0kIJcw2N?=
 =?us-ascii?Q?ylLKLKBEUkz5IJySE3z/j9rQdWdbb2JHy31IrhnhirBCBx8ohiyS7t5wY842?=
 =?us-ascii?Q?SfQijdLgsLoc2Wbqlb+mCccKzSOx1jyYdg19ohLbwgDNLMoj+pMM7jL9N11g?=
 =?us-ascii?Q?dI51s0hex58kdCzVouKGiBCKqntFBZ4MZba8gmQgjct8GFEhyGfX26GbnOvZ?=
 =?us-ascii?Q?UN6KffbJwhsmvofYGJc+AofY0vtcKiWLb+95pYhFVAWuLFlX6vJMt2ghb3Qz?=
 =?us-ascii?Q?iJJ0YSjvWcZ15+f7yi6XrdT2IsCLI4CKMVpPrTpbW7xRUoweBe8fzIQT6WKk?=
 =?us-ascii?Q?HQ4uZ/jHosdnFgOr1/MxBOYSuBKQQlGbcO0Qdl3iogIFwhp6/MHEJPEL9TGG?=
 =?us-ascii?Q?C8gvums6EJnAeXe8g+0Wwe0jawUFqmZi1OLxonf5dWMiHQhyMYOCUtvvfAeJ?=
 =?us-ascii?Q?IXoPKXuWNS7PEZAVbysFOghXrzijkC+ZfnGhhsSSmxO3o5jPIQA99fXSLDVx?=
 =?us-ascii?Q?fUflwRddhfk3V5bUa0dSq85qSu9wxg/Ks2mBtEzRTX0Dx8REiMtPQSVvXMeP?=
 =?us-ascii?Q?3HVdFSEvL5hSAWWwBzYrVBf+9FZCap+k4/vL3ZnWb0gS2d/oPw676xgi7HFm?=
 =?us-ascii?Q?v84v7q1zLtrkMzp+klx+lKsb4FdhJFU31CEqytHSFHTrXjJSYnyRq35Fq7JP?=
 =?us-ascii?Q?LOMH1CnSMTsdYzODnkDFy60t3Um1z0d78SuVHOJdF2XZlKMJEEAL1JO7B8Pe?=
 =?us-ascii?Q?26XFyaXCMZ+mY3ELHp79GocccGfAoDNrVQgaHkWT/hjVR+ie+D2VeoHVGGA5?=
 =?us-ascii?Q?WqH9sxVB58fKlwGQrysC97khDM8f85D62zRf0d7XMNALNIn+yJWkDzy8NvOa?=
 =?us-ascii?Q?7NbTJb4uMf3NetIA6jXrVlZGQ9ZQpvZi4M77wy9rTpYxe13gpQ1TzPyoktzY?=
 =?us-ascii?Q?/Jkv8QuQjdMu7CEjImCc8vDXRlhN/IJdn4B2kxRXoQ2M9tREYFAdbdVCtoyi?=
 =?us-ascii?Q?UqKEKV/u6+4NjlgiSnJEqaTVBUavKT/S8wEp/+8zJoawx+pNkYfxExYPPwkg?=
 =?us-ascii?Q?UCFWGiXZMa51YmIuwFMIABO9rYW9YIdtBYeK9iEjUPGyJ6yhIuYTSKbz8DbC?=
 =?us-ascii?Q?4G2/QbFZ2IoN3XHGlGFdnKREAtWbUiL4PurmQFgzEJqn9YiSrusAojk3zGA7?=
 =?us-ascii?Q?60TtXq+xsfQkE/w6bEgSIufcUiaJr1EWpUC3LPkfaS4tcujMlSoK2chO/9F+?=
 =?us-ascii?Q?0QbMjvPlEn2fiNuUbcqQOD4AGbFS/FV+NJbISHz/iJFlnQ03UsH/mxswcY7T?=
 =?us-ascii?Q?igPGq/cku7l1/B0RqYkecYoaYEHXigyjrQrit8mNHQXXFl+8O15g7rYw9cbb?=
 =?us-ascii?Q?xL5LxsS6EcA/H3mtsuitBLjtp1L8QAqfegkyZm0sChthUupDZguEnds4GgY8?=
 =?us-ascii?Q?Y1ljEfx7Bxi8ggBW3tVKIslu7dGrSpEK1kDrUySzsuVYZZFRq1zyq9B+U7jm?=
 =?us-ascii?Q?fe7sd/1tv2zD6DJLlVYTikcK4cbJWunkNjVr9m6GqMTQWnNiecHAU27MwBzC?=
 =?us-ascii?Q?hnNW2fJC7i9vTYyElNYhqiBbktpUDVGvt5NCdIFsUyJePrzMTe+Om+F9mYB9?=
 =?us-ascii?Q?Fw=3D=3D?=
MIME-Version: 1.0
X-OriginatorOrg: maxlinear.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB3163.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee55ffc5-2300-4b4c-e011-08daa036bc3e
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 03:16:57.2949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dac28005-13e0-41b8-8280-7663835f2b1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1u3sEXBWbpWX1tTF6bBv72xNDvpF3KwJZZry2hB1NCkPxhKPRROZsE/4tmOzzzJBu75fEOeTYnPCZoYtWqd+hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR19MB5346
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: maxlinear.com
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 23/9/2022 5:09 pm, Antoine Tenart wrote:=0A> Quoting Peter Harliman Liem=
 (2022-09-20 10:01:37)=0A>> +       default:=0A>> +               /* generi=
c case */=0A>> +               dir =3D "";=0A>> +       }=0A>=20=0A> Why "g=
eneric case"? We shouldn't end up in this case and the logic=0A> changed af=
ter this patch: an error was returned before.=0A>=20=0A> The if vs switch i=
s mostly a question of taste here, I don't have=0A> anything against it but=
 it's also not necessary as we're not supporting=0A> lots of versions. So y=
ou could keep it as-is and keep the patch=0A> restricted to its topic.=0A=
=0AThis change has been removed in v2.=0A=0A>>         {=0A>>              =
   .compatible =3D "inside-secure,safexcel-eip197",=0A>> -               .d=
ata =3D (void *)EIP197B_MRVL,=0A>> +               .data =3D &eip197b_mrvl_=
data,=0A>>         },=0A>>         {},=0A>>  };=0A>=20=0A> The pci_device_i=
d counterpart update is missing.=0A=0AI missed that. Thanks for catching.=
=0AUpdated in v2.=0A=0A>> +struct safexcel_of_data {=0A>> +       enum safe=
xcel_eip_version version;=0A>> +};=0A>=20=0A> The driver supports both of a=
nd PCI ids, you can rename this to=0A> safexcel_priv_data.=0A=0AUpdated in =
v2.=0A=0AThanks!=0A=0A-Peter-=0A