Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3f7b7ed-4dc0-c880-79aa-5e84b71a615f@amd.com>
Date:   Tue, 27 Sep 2022 10:47:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] crypto: ccp - Remove unused struct ccp_crypto_cpu
Content-Language: en-US
To:     Yuan Can <yuancan@huawei.com>, thomas.lendacky@amd.com,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-crypto@vger.kernel.org
References: <20220927133955.104353-1-yuancan@huawei.com>
From:   John Allen <john.allen@amd.com>
In-Reply-To: <20220927133955.104353-1-yuancan@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ek1oRWEzdFFwcG0wZ1dqWEx4MStSSlBrQmtwQ3B3Z2tuYW16cHRJUFBMc0hm?=
 =?utf-8?B?dXQrZEI3Y3E5QzRSd3FIcUNmZkQ4T1BXTGNhakwrdHI1OFZ4MTZEMmxXYUVF?=
 =?utf-8?B?bXVoaVdzaEhNZUoydURmSFBxZFpFSTYyVmI4ZHZ3ejl6M2JZdzIrcFVleWFk?=
 =?utf-8?B?dURsYzY2Rnhkd0tDZnlNbHQxNWVhdHhwNDNObG1RTHlmcDczVHVZSXBrOEdl?=
 =?utf-8?B?WTJrV2crOWdqSk1SS1UxWlg2eDhqNnpVeDFlVkxsNlBZQkF3aUZYejJPTFha?=
 =?utf-8?B?aTBLdi9oUS9tUHpRN3NvdlU4cVFUemVuZWNIcmg2Qk84RTVvbHJFa0NndzFk?=
 =?utf-8?B?WlYyVXlob3FyUEt4Z0FLeVo0ODBMKzFmQWRYdTZwMU9RVVdiajMyQ05wL1JI?=
 =?utf-8?B?L0dUenhnT3RubEd6emtYZks1Y2FSVVFOeGxvSm1sYW9HYWQ1VERNNHdPMWlV?=
 =?utf-8?B?RjNhVzNxdWwwVlJDVnhCOXlWQ2J6Sy9mMTdkMmNvREJkenYrbE1uQ0ltZnNF?=
 =?utf-8?B?Snl5WDlRY3gyVm84bWZsSC9DKzhSeVFMMVhIc2l6RjV0ZE5kYVhCenU4VTli?=
 =?utf-8?B?dm94RVo5Y0lyTS9sZkdHMUc3VkRmUTltMGZGNkZlRnpvWGl3c0lSR3FXQ29u?=
 =?utf-8?B?ZEhEWklFMUZOUnp1d0daejRSV093M0gyVUltdnI1MGRFODFrVk8waUZNc3A4?=
 =?utf-8?B?WVZhMFlid3gwQTVUWkdVNTFYQTJjMzUwdEI4ck00TVM5dlVKdjN6VmU1c3VM?=
 =?utf-8?B?UTliZzhocTFMMHZpQ3VRYTFFODg0QUMwdzNoTTE3bFY2c1V4WW5oam1NMG5p?=
 =?utf-8?B?QjJsQlE1RUxyUFRNb3NidnNzT2duUWdVb0daRHpYOUVuM0gvbGNTOEkxM1RV?=
 =?utf-8?B?Mm1Eb05kS3I4VHdUNEgwcEx6YW9mTEZnUGhCZVB1dG9oOTBlQ3poMzdpNnFG?=
 =?utf-8?B?a1BkL1FsWTFTZFd6TEllTkVvajNuOEhiUDFXQTkzb2haNnE3WW1TUlZHa3JD?=
 =?utf-8?B?d2tOc0I0TTZpQXQvM2tFaXdNN3RSbEo5UzZqNTVydE0xZ3RRc0JXWURYRVR5?=
 =?utf-8?B?Y0FEdDdmT3BaeE9Ua29tRXFRVUF2dVp3V0IwdnNFWmVSME9NaEFWN3lCYnlx?=
 =?utf-8?B?R00vc3oxYURRMUwwbXVsSnhvSWw0QVg0c2sxZGpPZFlUcmw1ekVhQzRvNUtx?=
 =?utf-8?B?SzVYWjg5YTI1bU9PbWZQanhWQlR5ck4rM2lyNm9SdkIrNk8xMmVNNzVJTlpD?=
 =?utf-8?B?MERidUx0MFh6T0g4Yk1lSGpNOUNUUDFVWDhVVmNWcFhpOUp3NDgvanpUbWNW?=
 =?utf-8?B?NDZFSkpUN3QxNFNMaVVNTW95dG5oaFljaEVqYlhYR2Q1RmdKSnkyS3prMFpa?=
 =?utf-8?B?OTZkWjdaclYwUUhuR3lOaTdoaEw1WGFJbjQzMmR6RUprSENpTmg1WFFmMUxW?=
 =?utf-8?B?UmJlUGlxcHpyUHVEZHowdC9STlRRc1lrdVVKNGFWRzhCaFZXSFA5NGNZZkpN?=
 =?utf-8?B?T3hTbEdDTEpxaUFWaHJYSzUzbjhHejlwMmQwRHdWUnc0bk14VW9ZS0hXYUZl?=
 =?utf-8?B?aktObE01S1R2aVRkUy9zakx6Z3NRb3RlYmkySlhXQmhGS3JyTDJiYXBYUWxn?=
 =?utf-8?B?M2I0ODhZNUNDUkprR09NVkxrVEdmWElZQk9SRHVmdlVFVm55Y2VNTmpsTENj?=
 =?utf-8?B?S1N0NjU0U2F2RnNaOUc5c0hlbS8wWlcrRktqdUNQOGtJZGlwd2FoTzJBbW1y?=
 =?utf-8?B?bUo4aFh0VHVpczVGTHFPc2lNaUtOTWwxUXc3RGVsSEJmOFgvcmtlQVlTbk5u?=
 =?utf-8?B?clhleTFzTzgvYU5lR2pvYjFLeGR4T2duZWdQY1NqZElDdnFQOUFkcktiZGJh?=
 =?utf-8?B?SWN4OS9tZDBVMmozWkFtUmdjRW15dnVINUtEalRUY0hwdm9KNmc3cU1FL2RH?=
 =?utf-8?B?SHdIcmVha01vYUhvNG1Db292alNkcHovaTc4dlNnNldQWUU2aWVxSHhPd1NI?=
 =?utf-8?B?N1E5UmUrWVN6RDhrUzMwMDljUHNGeWRXdE5sc2hSVEtPL3ViQjJmRTdOV2hT?=
 =?utf-8?B?cDBoYWhTYWhlODdjcnJpd1QyNmtrb2dUWUN6MHdWNWNWOGZ1RmkxMk9VTWkx?=
 =?utf-8?Q?LGFlRC79ZXxf8PvMTD59XE43k?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ee5d53a-266c-4593-1cc1-08daa09fb8a0
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 15:48:28.5810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: odQnehhPpyEPPvupekZR4PNevxIDUAH2K61BzAXoVTviJjF+skJ5vUNTD2V5ASvkk4hVM0cW1ZQXNf/D5JvL1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5079
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 9/27/22 8:39 AM, Yuan Can wrote:
> After commit bc3854476f36("crypto: ccp - Use a single queue for proper ordering
> of tfm requests"), no one use struct ccp_crypto_cpu, so remove it.
> 
> Signed-off-by: Yuan Can <yuancan@huawei.com>

Acked-by: John Allen <john.allen@amd.com>

> ---
>   drivers/crypto/ccp/ccp-crypto-main.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
> index 5976530c00a8..c8f3345c66e2 100644
> --- a/drivers/crypto/ccp/ccp-crypto-main.c
> +++ b/drivers/crypto/ccp/ccp-crypto-main.c
> @@ -78,13 +78,6 @@ struct ccp_crypto_cmd {
>   	int ret;
>   };
>   
> -struct ccp_crypto_cpu {
> -	struct work_struct work;
> -	struct completion completion;
> -	struct ccp_crypto_cmd *crypto_cmd;
> -	int err;
> -};
> -
>   static inline bool ccp_crypto_success(int err)
>   {
>   	if (err && (err != -EINPROGRESS) && (err != -EBUSY))