Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dee9b106-cb0a-32d6-2795-da46912332b9@amd.com>
Date:   Tue, 27 Sep 2022 11:11:55 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH -next] crypto: ccp: Add __init/__exit annotations to
 module init/exit funcs
Content-Language: en-US
To:     ruanjinjie <ruanjinjie@huawei.com>, thomas.lendacky@amd.com,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220926092711.1192679-1-ruanjinjie@huawei.com>
From:   John Allen <john.allen@amd.com>
In-Reply-To: <20220926092711.1192679-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG9Qbmdod3dEbzFSblFTV1V1TitmMnEwQi93M1B6OEVjVGlWdGpBd2hwNG1q?=
 =?utf-8?B?d0gycmdJcStoSWRScU1qN3p1M3Jpam9BNWdLNFYrZEFVeHZVUjk0SDBLVjhW?=
 =?utf-8?B?NTNmY041YjFBWVVpcjh2NkFEQ0FyNVRxZUJ3WTY2WXRDNk5Fak0vcUZSZkNx?=
 =?utf-8?B?akVqZVRPZ01yRjlKZGVkc01BOEJHVGNtZExKWktXR3RtaUlrWVJrZGhxYjc2?=
 =?utf-8?B?VjZYWlZxZ1VDbW12cHhhMlp0RHJ3d1JwQllRMitqcVJUb3pnMTVDOHR4MDFI?=
 =?utf-8?B?UkRrdmsybE5RbmF4WHljVGdjMnpOWW5TVjhUaEZLWi9CQmdUa1hCYnFFQ3Fk?=
 =?utf-8?B?bXlXRnRYQS9lb3ZqUkJnbkZEOXIwQ3VwUXl3dFB1eHNEamlQYU44ZTFSWXZ1?=
 =?utf-8?B?MUNyK04zbXlWQm9CSW9maTlRY05maFlqd0dJWi9MNXBvZjBER2NHZU90RWpj?=
 =?utf-8?B?SW8rNDF1VkNzY2VweVlNVmxWcGNPZ1hsTnVidngxVitzQTlnbTJWYTdvSkZn?=
 =?utf-8?B?eHRsMWFEbHczcjJ4b3dRamp0UnFEL1QvS2QwQldEL3dtZlFsLzc3VXpoR1Nq?=
 =?utf-8?B?OG11cXV0OGNsWTdac1IreExZTHhGa2ErKzNkVnhDVVpoeVJkUEY3ZjRTSWhR?=
 =?utf-8?B?RlQxVnJpZ2NLK05ldE96VWN5azdSbnFtOEJWVjFhakVOOWYwbDhlUGdscEtv?=
 =?utf-8?B?N2puczdjR3NkSm9qM2xLT29CdkQrN2d6YU1OdzF5REwrdlFrNXlQazBKTDEz?=
 =?utf-8?B?S3VuZmxWRTlITHA0eEdvNnBTWGQ0OGVOYjUrT01WcGt3cUtlTDhzb1B3Q2JR?=
 =?utf-8?B?TENQbHBiNHZWVmRldHNYRGF1M2d2RVZGR09oZGxLbW9PRGVTT0FiNnp5Y09R?=
 =?utf-8?B?Rm44TDJ4TzVBeWwyZjg1K3ZTQ0JZaUNJU2lBWHNUL1NKaGdZVTlFaGtTRm1s?=
 =?utf-8?B?MkVycjZrOFk2NG9tVzgwNXh1NHFRNFNzN2xrTDlmeGNwYncyTUl6VjZvdW0r?=
 =?utf-8?B?VVhXSHBSMjNYblVKV09KY2hpamN3MTdpQWhyLzVPVGJnT0tqemNNZnNsQ1h2?=
 =?utf-8?B?MVRSaDFoemxjejJxY09vVU5ZOWpnK1M0NUVZZktmV1NWbGordEtsVXVFTTZk?=
 =?utf-8?B?dEhSUUhnV3I2Z2xMQm5EVDBHN3JpRk1vK2ZRUXZYZmhtdFVBUWkxSVNqbkdC?=
 =?utf-8?B?cHplQXBxWUNOd2s3YUU2VzZDSWtuakErelVRN3dMY2taL2JPR2ZoSERVZ2lq?=
 =?utf-8?B?aWhpeWtUWVNjOEVMdVg0UG1oNlY2QkRiMkRnY2wrSG1LMGtxYWJMZVNpRGV0?=
 =?utf-8?B?bUJFdlpyQUlaT0I5WnJ1S3NMWTFTTHlzYk9hTE51WkVTcTR2VGtDK2R1aFh2?=
 =?utf-8?B?Ly9TSGxTeXoyWVNvbHF6L2xIdGcxTGc1Sjl2VS9Pd3pWU3RaOFU3N1NMK2FM?=
 =?utf-8?B?dlg2K0xoMG1TNGlqQkZCMjl3eFVFT3lveUVhaFFwaHk1c0FZSk0vdlRYa2w3?=
 =?utf-8?B?SGFFZ2FYWHlTQWp2emw3Y245MVhlSU1LbWw5Rld1WnFCNE9SQ0ZFT1pwZ05v?=
 =?utf-8?B?b21TZ0UwWmR4OThnWHVmVWY5YzdHbGR6VjR5NzdHQ3o1bzUrcmtJenlaMFFZ?=
 =?utf-8?B?RU9tbi9teHM5SGMrcDIvYURRWW5YR1hQbEhOVTdLQWFYWnlQVHBiSFA3VmhZ?=
 =?utf-8?B?cHJLYytNbWNlZkJjejFldDJjWkV4TnZCREd6bnBNeUVrNzFXckVpRytPTkN3?=
 =?utf-8?B?U0NVd2cxR1plNExuN2NSUFVCY0ordndZYmVjL0FMMGFVNGlBcEhIeHJPOWky?=
 =?utf-8?B?cmlBcnhNZEs3cjg4M21tRG9SM0trVTMwcDJRYUx1ZTNLUzJSUVQwd3U2c09K?=
 =?utf-8?B?SUJSVHBscEh1d0c1Ui91YzN3NEpKSktQeXEwWE1SZkxxMmZ1OFhKRExOdGQ0?=
 =?utf-8?B?OWFTb0hqSWZ5eGZlb0U5eUhXYUFHTDFsUGhrYS8wZlBER29WUEl2VXhENzhH?=
 =?utf-8?B?MzY4RkpVbzJvbzllMEYyNUdMaFppSUhsL3h5VEtmRXdyRjNnOC9ETmE4YllZ?=
 =?utf-8?B?b2RnWG9YMkx3Kzd4WXk3VkpuSVN3VERxMnJZZHVtYnFKZHo3NkJPVUxONzVm?=
 =?utf-8?Q?ytz01kR9qD+x3mYmudxeWt9fF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22da57be-e3a6-43ab-ded5-08daa0a30379
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 16:12:02.6653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AlWatDbevJLmXTFPtnExHyoQGkctHyq0D1QdpcxUpqZVxzlVy8d5uKk5SkP2GNAWv44nvM8qf/HeCuV+nCV0ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4511
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 9/26/22 4:27 AM, ruanjinjie wrote:
> Add missing __init/__exit annotations to module init/exit funcs
> 
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>

Acked-by: John Allen <john.allen@amd.com>

> ---
>   drivers/crypto/ccp/ccp-crypto-main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
> index 5976530c00a8..332181027305 100644
> --- a/drivers/crypto/ccp/ccp-crypto-main.c
> +++ b/drivers/crypto/ccp/ccp-crypto-main.c
> @@ -400,7 +400,7 @@ static void ccp_unregister_algs(void)
>   	}
>   }
>   
> -static int ccp_crypto_init(void)
> +static int __init ccp_crypto_init(void)
>   {
>   	int ret;
>   
> @@ -421,7 +421,7 @@ static int ccp_crypto_init(void)
>   	return ret;
>   }
>   
> -static void ccp_crypto_exit(void)
> +static void __exit ccp_crypto_exit(void)
>   {
>   	ccp_unregister_algs();
>   }