Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 23:39:30 +0200
From:   Aurelien Jarno <aurelien@aurel32.net>
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     heiko@sntech.de, davem@davemloft.net, herbert@gondor.apana.org.au,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org
Subject: Re: [PATCH RFT 4/5] crypto: rockchip: support the new crypto IP for
 rk3568/rk3588
Message-ID: <YzNtkiR/dD0aEZrv@aurel32.net>
Mail-Followup-To: Corentin Labbe <clabbe@baylibre.com>, heiko@sntech.de,
        davem@davemloft.net, herbert@gondor.apana.org.au,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org
References: <20220927080048.3151911-1-clabbe@baylibre.com>
 <20220927080048.3151911-5-clabbe@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220927080048.3151911-5-clabbe@baylibre.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk

On 2022-09-27 08:00, Corentin Labbe wrote:
> Rockchip rk3568 and rk3588 have a common crypto offloader IP.
> This driver adds support for it.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  drivers/crypto/rockchip/Kconfig               |  28 +
>  drivers/crypto/rockchip/Makefile              |   5 +
>  drivers/crypto/rockchip/rk3588_crypto.c       | 646 ++++++++++++++++++
>  drivers/crypto/rockchip/rk3588_crypto.h       | 221 ++++++
>  drivers/crypto/rockchip/rk3588_crypto_ahash.c | 346 ++++++++++
>  .../crypto/rockchip/rk3588_crypto_skcipher.c  | 340 +++++++++
>  6 files changed, 1586 insertions(+)
>  create mode 100644 drivers/crypto/rockchip/rk3588_crypto.c
>  create mode 100644 drivers/crypto/rockchip/rk3588_crypto.h
>  create mode 100644 drivers/crypto/rockchip/rk3588_crypto_ahash.c
>  create mode 100644 drivers/crypto/rockchip/rk3588_crypto_skcipher.c
> 
> diff --git a/drivers/crypto/rockchip/Kconfig b/drivers/crypto/rockchip/Kconfig
> index 1010d897d9ef..84ca1081fd0c 100644
> --- a/drivers/crypto/rockchip/Kconfig
> +++ b/drivers/crypto/rockchip/Kconfig
> @@ -26,3 +26,31 @@ config CRYPTO_DEV_ROCKCHIP_DEBUG
>  	  Say y to enable Rockchip crypto debug stats.
>  	  This will create /sys/kernel/debug/rk3288_crypto/stats for displaying
>  	  the number of requests per algorithm and other internal stats.
> +
> +config CRYPTO_DEV_ROCKCHIP2
> +	tristate "Rockchip's cryptographic offloader V2"
> +	depends on OF && ARCH_ROCKCHIP
> +	depends on PM
> +	select CRYPTO_ECB
> +	select CRYPTO_CBC
> +	select CRYPTO_AES
> +	select CRYPTO_MD5
> +	select CRYPTO_SHA1
> +	select CRYPTO_SHA256
> +	select CRYPTO_SM3

That should be CRYPTO_SM3_GENERIC

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net