Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3195627rwb; Thu, 29 Sep 2022 23:17:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4gMZf1cOqH44hEl5XSt/r1XoVpW04nQKxe+mCN/lJry9GYbm80AS/P/n4tuPyPPRAWeb5z X-Received: by 2002:a17:90b:3ec9:b0:203:27a3:166f with SMTP id rm9-20020a17090b3ec900b0020327a3166fmr20211752pjb.109.1664518626170; Thu, 29 Sep 2022 23:17:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664518626; cv=none; d=google.com; s=arc-20160816; b=f1sPQRJXttBoF6Hvp8n4cYoibXkRO8IqY1+joDiPahgc+jyN//XPaKg2962cz+hC3r 6rzv79jcttycLsppSHBGMECHUlgfiY0qVa6YmThLHIjQ8Cc2QoY3Vlfh/RwwhzLKK9Mt ISE5tBDmYJqq6ow644vGgWZ9nzRnWZZDbHRIXJWDXCCZGXrsDKz8tWjB0kJpDFuL4Fr9 KkvTJD7yHtj3Jw38x8cRblhoLCS3lJRcj1MrYCZXC3cGRmCywVQkY2z7qtDbJFsDIvaF hUZPhAVdgeTFx6ir7v3e/ztnCWQtABm7izUrGb68xEk15Hbum4mhrPPfOmjf1xfVUzvc tp6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=WEQ3eRS4upxYly6TqbC+Q/MKU94fTbSRAKmYhJG0bsU=; b=RhYXqVAl/DRYGoSyshE+JhQjn3q9bsSmAT16JYXMZ3KVXX7Hy4ajse4xZJD3lB35kn QM+EUSInRrdAvUC2u/nrH2uH08zogwHrs3DiGV9PdmsClRVIdmuwEjMKLi9voWtW4uQf CC232fBfFdb5Wn4Se61sCZJGHbRzA7pbNstEuZCetXBj4wur3PeQtKT94OU2vaEyoBSc ORm7p48JkIylpBRYIScusXmLAC162im4L717xn7dcs6aDiqpWDLlmoTXuio/WQW31eH2 tNFtJmcwtP656Hk611tN/akniMgWgB08hIrdkw5kVzF6PZZFSHQgrZM9gpWqNsSo5+HY u6Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k10-20020a170902c40a00b00175659beafcsi1978091plk.189.2022.09.29.23.16.53; Thu, 29 Sep 2022 23:17:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbiI3GQE (ORCPT + 99 others); Fri, 30 Sep 2022 02:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbiI3GP0 (ORCPT ); Fri, 30 Sep 2022 02:15:26 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7814A109502; Thu, 29 Sep 2022 23:15:18 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oe9Ib-00A54y-1i; Fri, 30 Sep 2022 16:15:02 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 30 Sep 2022 14:15:00 +0800 Date: Fri, 30 Sep 2022 14:15:00 +0800 From: Herbert Xu To: YueHaibing Cc: neal_liu@aspeedtech.com, davem@davemloft.net, joel@jms.id.au, andrew@aj.id.au, johnny_huang@aspeedtech.com, dphadke@linux.microsoft.com, linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] crypto: aspeed - Fix check for platform_get_irq() errors Message-ID: References: <20220920032118.6440-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920032118.6440-1-yuehaibing@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 20, 2022 at 11:21:18AM +0800, YueHaibing wrote: > The platform_get_irq() function returns negative on error and > positive non-zero values on success. It never returns zero, but if it > did then treat that as a success. > > Also remove redundant dev_err() print as platform_get_irq() already > prints an error. > > Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver") > Signed-off-by: YueHaibing > --- > drivers/crypto/aspeed/aspeed-hace.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt