Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab0d9840-07e3-ec49-a9b3-c4b65d7d61bc@intel.com>
Date:   Fri, 30 Sep 2022 15:09:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH] crypto: tcrypt - fix return value for multiple subtests
Content-Language: en-US
To:     Robert Elliott <elliott@hpe.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>, <jarod@redhat.com>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220930214014.37194-1-elliott@hpe.com>
From:   Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
In-Reply-To: <20220930214014.37194-1-elliott@hpe.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWR1VVJOZWdHei9iWkIzMDZNbW5VNUJZYkoyZ2U2VlI1djczSnRPYTFnRzdM?=
 =?utf-8?B?SURQWnRkZ2lselpxRHNaMG9FWDVPdTF2RDdGdlV6UGZuWGo2dTRTaThpOTZH?=
 =?utf-8?B?Z1hscWNBU3dFR3pqREpXMnRreldOUnVxU2x3UGlXbDJCWGlydmp4L2RPMW5B?=
 =?utf-8?B?dVBJc0N0cXZHbHVodHhFeithYXpjdUtyZ0toeTdFa0ZaMnBNM2JESXJDYk1C?=
 =?utf-8?B?NkZZZm42VE9aTkIyaDR5ZUcrUVpieHRUMjhnK25tOFNmc1JlUTd6RE5sRzda?=
 =?utf-8?B?OHllc2pKalJ1WUdUQ3ZyVVgwaVA3aW0wZ0pCMDBMamVrWTBjWjE4RzZHK1dK?=
 =?utf-8?B?V3RoOXNoaDdlU0RXeVhCUTRvcDA4RWJUWk5yVHB2Z3VaOG5SUmtCaXZtMUJD?=
 =?utf-8?B?dzl6VVRhY1RPSGNqYVZmdWNHV0kweHI0Sy9rL2NIckFlYnpYaEN1bVd4NlNu?=
 =?utf-8?B?WG4wc0Jac3pnc3FrR04zWUk0bjFTdTNWV3dvekg0WUt6VmRjeXZxK3FWT1hp?=
 =?utf-8?B?WlNGc1ZpRWxkWDdvNTBmSkNTMDdlQzB5SG5LNFprZllkQ0xFLzhXdEoydTg5?=
 =?utf-8?B?aUltR0xlbUFIK3M3cDFoOWh3cnY4WEdTbjkvbmIybjlJVVEzeHJqR29qRElu?=
 =?utf-8?B?SkJrS3c1WnVoQVpwKzNGZGY4S1dLRkVKTjJSUkdGckphemp4cmdtbnA0eDNv?=
 =?utf-8?B?UHkxNjN1M0pnQU9LME1UOTVjVndlcWtJRU1INUEwTFdOR3BmcURTWkMwMzht?=
 =?utf-8?B?aS9ZTkhNUjJDWlErU09PU1NhdmVUcTdMRHdXclJJU1RNWG80NGNYWE0wTkU5?=
 =?utf-8?B?OVNMdG1XSzVCc0JKT1pTMjZoTEF6Z2hSMFJ6eWlDS2VmbVoxelF1ekd4aElW?=
 =?utf-8?B?N0tzejVqNDg2bTF0b2pSSkdPaEYrOHp2eEFHRytWM2ZmaE91MVF2c1V2ZXRk?=
 =?utf-8?B?Q0E4MGFJb0NUKzZYRzZqWWpZanBmS2ZiNmJnTnlGcDdPem9xWSsxM2RXek5y?=
 =?utf-8?B?UGZhazZtWlJiNjMvQ2RWM0FXazV4MUlZTCtOZEpta2hqQXBQSk9nRzl0Kysx?=
 =?utf-8?B?QWdKZHdwSDI4Y1RtMHEzZFVrWnhvcmtVaXlGbnpNK1BQWjArTDFiTnhTdTR5?=
 =?utf-8?B?ZjlXdlZvYVk5Y2NFS2paU3RwMEluclArbkQ1YUN0VkUxVlRWdytYMnJ6bGZj?=
 =?utf-8?B?Rno2NmhHdzJXNXBEa0dJTVpXR2dZTk1kQU1lYVRvVmZKb2h6SVZQanpYS051?=
 =?utf-8?B?SjVvRzU1MDJLQ3dwak01TWE4UWdSQzlrYUlSdWlneFB0SGsxVWl1azNGSzY1?=
 =?utf-8?B?MjhnTmdYcDVwNkYvMVlGZWJkbUtKUDl2aHY4UkR4OVdGditlNURJMTRFZ2xV?=
 =?utf-8?B?ck5GS25OeUVnNTZlZW1kY2hzWnRaQ21CM0t5V2l3RnlKUkJTRTJRUUtVdzZO?=
 =?utf-8?B?UGdMRHVvdGFkcjJ6SkRuZzc4cVFFZUhyOVZWUTE4enV2M3BxK0V5bm9neTdT?=
 =?utf-8?B?YzZ3ZERmZVNJL3JkcmJUVFdRTEY2OTZiUHRsQUhBeXZEUUtxOWRSRWdYdkow?=
 =?utf-8?B?Z2k4aHF0UzVrcW80N2RaNEh2S2Q1akJLM0VUTmM2VWtlRWJ2S0tQWGxjV01x?=
 =?utf-8?B?cmJSbGR5RWRIQVAwVXh6QkFqM2czUi9FRU4xN2FtUGQ1Q2NzOGxETHBma3p4?=
 =?utf-8?B?eXRHY2UzWmp2Z0xUbEYzVkxTYzhtVnlXa3M3ajhnMXg5VWlScTRBdkZSdmIy?=
 =?utf-8?B?Q3Fjekk0dTM1NTlJU2g4QndnQXVRS1VnMVpWRk5KUzlCZm5BY3phT2xpVGJr?=
 =?utf-8?B?TlFQV2RNNTNTNHZ1dWFoRkxVM0xTeDhsa29ybmcveUVSWWljTktTMVR4Q201?=
 =?utf-8?B?RC9IQ0xaOFVlalhvK3UyaU5kbEw0bE8xVW96aVhtWXhMNXhUSFE5cldUdXlu?=
 =?utf-8?B?MFR1VitpRFE2K3lCL2pNMTN5RVB2aldmb0ZsYUZ4M0JHSEJCN205YUl0WDl3?=
 =?utf-8?B?VEMrZGN3YXc5NHFyelRiekdaSDl6Si9JVjFHM1g3ZU1DNUhlYlN5cEp2VjQ3?=
 =?utf-8?B?TEE4QnJZMGt1enJWMms1VWw3a1puVTJGUFNDOS95QVcxOXZjSythME1aMUxY?=
 =?utf-8?B?cWkwUXFoN0xwUFF1L2NPZ29VYXhlYnYrOFNsS25jNzZVY1A3RHhBVjFveldu?=
 =?utf-8?Q?3iKei26UMQh5uvSMaDO2mIM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2828dd75-c648-445d-edb7-08daa3307656
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 22:09:36.6762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CKR9iwEj87JwhHtGWP5H1iymcHE/ECxQJFcLUB9GqAJQfW1dLsi4m7ZhZLgSMRaScTrPkBUoeb2jQy0I1Bk5kMYdPSjE3Ubgy9vu9x3h8lX89zLimN6sA744KVbP3olw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5972
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 9/30/2022 2:40 PM, Robert Elliott wrote:
> When a test mode invokes multiple tests (e.g., mode 0 invokes modes
> 1 through 199, and mode 3 tests three block cipher modes with des),
> don't keep accumulating the return values with ret += tcrypt_test(),
> which results in a bogus value if more than one report a nonzero
> value (e.g., two reporting -2 (-ENOENT) end up reporting -4 (-EINTR)).
> Instead, keep track of the minimum return value reported by any
> subtest.

I am assuming this is for the case when fips_enabled is true?

I agree that returning the cumulative sum or errors isn't particularly 
useful, but how is returning the minimum error value useful? Wouldn't it 
be more useful to return the first error return?

Ani