Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Rob Herring <robh@kernel.org>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        ChiaWei Wang <chiawei_wang@aspeedtech.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/4] dt-bindings: bus: add documentation for Aspeed
 AHBC
Thread-Topic: [PATCH v2 4/4] dt-bindings: bus: add documentation for Aspeed
 AHBC
Thread-Index: AQHY16FydoFvy/tRik2dFUNH8arC163/yrUAgADxsdA=
Date:   Thu, 6 Oct 2022 05:45:42 +0000
Message-ID: <HK0PR06MB32020E4C2124FDD9C68F811A805C9@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20221004032841.3714928-1-neal_liu@aspeedtech.com>
 <20221004032841.3714928-5-neal_liu@aspeedtech.com>
 <20221005131840.GA3256371-robh@kernel.org>
In-Reply-To: <20221005131840.GA3256371-robh@kernel.org>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yc/82TXUBafv0HuGYPLByz/E2+BKlm3RrBbEIPXznkSKyf9VOjxmPTfYUn/J?=
 =?us-ascii?Q?2u5etxvm64byB9OE2+WBCYnxts5isOx9eXRD5AUXaO9iUglfDCaW0Yont2Th?=
 =?us-ascii?Q?d9x/C6iIPu0A0zkidItXy6gFeYSYDNrJIEuzMHs4mWcE5I8lT5etjpN7moyr?=
 =?us-ascii?Q?JVfU7/LvEBdJKBekq8ej7J+Xxiv3elNXlU+9cs6ZaLSgw0A1jOnGnUxv3Gkv?=
 =?us-ascii?Q?MvidO0uhNZkzma561SVuQdy4/GDPUWdpGirwyFFDZNcwjZPPOEtJT7qgQgmn?=
 =?us-ascii?Q?wgrhf9CkhQaSo/4BWJJ5OLxwI444TSpWxuHubUilGgJLUZx8pqRclXZt2lFY?=
 =?us-ascii?Q?8xenAQMQ1NkhTr8F/l06blQdMs0zFDGFxAF5/Qt9dovpHjLiuzxVaXgmhYKP?=
 =?us-ascii?Q?6amJtYBzro2EcBzoZFtUIqNF/HvHBgl+rktkDDfeWoY3EuY7XSjMeWwPr72W?=
 =?us-ascii?Q?IU8T9oDZD0DL4pbJKlpah1RsVpOXM2UOtJv7w/5zOY6NMHT+62H2ly4hezZ6?=
 =?us-ascii?Q?9G0e7zj4pImyD8clfgbg7c88u3AUM6/OHZIJ7BXwBpSkpWpggFR2iwby4Sa9?=
 =?us-ascii?Q?WTWRr7HukLp1QEsmpWu5uM8b0nCnqIxbiCdYZbT7cB3jJtulJ1kweK8CnvO8?=
 =?us-ascii?Q?ubMkInPqgyNP5PwKv3l8oSEnmnIS91BUJ1462wvDwtUVcSbzfPthyIGMcQjB?=
 =?us-ascii?Q?Jt4vxQHCN9RLAgSdsaaA5rLGekk3NXWsJUn7X7JERQd6SXpLCysi9Ohnh4Sv?=
 =?us-ascii?Q?lcShK6onNcngZR5fbpU5LUgum31slNEUTNy1SaorOWvsBtYtHRZqurzZ2SYe?=
 =?us-ascii?Q?l4+UvrsRw8LehfvTQDNvdZ2YrT5WaqLrd+H+0MVKCuq0PCDEX14KIsB7oTQN?=
 =?us-ascii?Q?oVY06hC10QyCMZkIbbGCnpE1yYK+bqKh2VjFPWrfA50ANr+PVCcb4LcXTlre?=
 =?us-ascii?Q?WvbLT+wnMQ8BUekxFGDOnI0adYKHdTpghIBpo0tNW/6mluO0Uh7Xvo7NUTZm?=
 =?us-ascii?Q?eyazab3swVwOfSg1tJrdBfkPN26oHgfM4EVjAVrx1xg5ryNc7VFXOqood4/A?=
 =?us-ascii?Q?qxvhuAG88+FSxhBdRAGR90AXePDe/qtvbEiBL4qaN0DFPLd7f61SJscG4pED?=
 =?us-ascii?Q?6w5fyjTp7mM7jRF/DdplU0HO5ohPh4VjLYMqRrvVbSkyCRmH1p6FAhNAxZCQ?=
 =?us-ascii?Q?VpGoBG5vtJJ1jj0RcOM6KXcI+RaTfiuDhLAX3FczoMTzzCrLnwxQTKwkCjuU?=
 =?us-ascii?Q?cHHKMi/7IFasAd3+83DbaRVajOF5MMsIlmVkAKLMopwR+7FB5yij4zMuD2ma?=
 =?us-ascii?Q?1m2AwhwL03weXzA3NS8srrDw1JGVNz8bepA39SAT7jX3cFbNduwzb05IL0eH?=
 =?us-ascii?Q?uJc8+D8CpiwpW2lKFRq8GI8BzIH/scARgx8xVCC9+druTusYj6KmUbpy2yxb?=
 =?us-ascii?Q?CovuBexmb+txa5+wvRxBV+50jJP3nQlBiKcE14yNAF8XsG9mnTrKxNimxHWT?=
 =?us-ascii?Q?ZT91MAjZ0f3OKz/qTGQygxeaFEUJEfBZWANbioAxFkWOgTOu3kiydA8rcv/e?=
 =?us-ascii?Q?UNcPuzcoTdpDkaav8lKEiiWwDWCL1AWl+e3ngguG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e07d835-d7b4-4cec-0f4d-08daa75e01a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 05:45:42.2549
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MRqRBuSHLCS8B9ffWxmZiGyP29X6CqZUaMT929fDnMby6gCK5Sg6QmuCkY7hYNXPy/6oJeJReYSzlagRKz9TDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5323
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> > Add device tree binding documentation for the Aspeed Advanced
> > High-Performance Bus (AHB) Controller.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  .../bindings/bus/aspeed,ast2600-ahbc.yaml     | 46
> +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > b/Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > new file mode 100644
> > index 000000000000..c42a350d30a1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ASPEED Advanced High-Performance Bus Controller (AHBC) Device
> > +Tree Bindings
> > +
> > +maintainers:
> > +  - Neal Liu <neal_liu@aspeedtech.com>
> > +  - Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> > +
> > +description: |
> > +  Advanced High-performance Bus Controller (AHBC) supports plenty of
> > +mechanisms
> > +  including a priority arbiter, an address decoder and a data
> > +multiplexer
> > +  to control the overall operations of Advanced High-performance
> > +  Bus (AHB). AHB is the main system bus for ARM CPU to communicate
> > +with the
> > +  related peripherals.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - aspeed,ast2600-ahbc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    bus {
> > +        compatible =3D "simple-bus";
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <1>;
> > +        ranges;
> > +
> > +        ahbc: bus@1e600000 {
> > +            compatible =3D "aspeed,ast2600-ahbc";
> > +            reg =3D <0x1e600000 0x100>;
>=20
> Devices on the AHB bus should be child nodes here. Unless this is just fo=
r
> device master interface to memory, but that's not what the description sa=
ys.

Sorry, I don't understand. "ahbc" device is already a child node here under=
 AHB bus.
"ahbc" is a controller to control the overall operations of AHB, which is d=
escribed in the description.
Could you explain more details?
Thanks.