Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Oct 2022 17:30:52 +0200
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
        ebiggers@kernel.org, keescook@chromium.org,
        "Nikunj A. Dadhania" <nikunj@amd.com>
Subject: Re: [PATCH] crypto: gcm - Provide minimal library implementation
Message-ID: <Y0BGLKzJ1tzuYgxf@zx2c4.com>
References: <20221007152105.3057788-1-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221007152105.3057788-1-ardb@kernel.org>
Precedence: bulk

I haven't looked at this in depth yet, but one thing jumped out:

On Fri, Oct 07, 2022 at 05:21:05PM +0200, Ard Biesheuvel wrote:
> Implement a minimal library version of GCM based on the existing library
>  include/crypto/gcm.h |  61 ++
>  lib/crypto/gcm.c     | 714 ++++++++++++++++++++
> +void gcm_encrypt(const struct gcm_ctx *ctx, u8 *dst, const u8 *src,
> +		 int crypt_len, const u8 *assoc, int assoc_len,
> +		 const u8 iv[GCM_AES_IV_SIZE], u8 *authtag);

This should probably all be aes_gcm, aes-gcm.[ch] LIB_AES_GCM and so
forth, since GCM is something that works with different block ciphers.

Jason