Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3441776rwi; Wed, 12 Oct 2022 01:56:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM70zkTxuKsvUoKDr0v7MsBoLuQfaCSISybK9+8lEjczCMpesNP7iZm/dJQE04LUdNJU4TwB X-Received: by 2002:a05:6402:28cd:b0:459:19c3:43d0 with SMTP id ef13-20020a05640228cd00b0045919c343d0mr26738051edb.197.1665565007386; Wed, 12 Oct 2022 01:56:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665565007; cv=none; d=google.com; s=arc-20160816; b=Eu/Y4PX7fauruYmtCF5ecpDCgFAdtiwNdcMnzxQMKPNN2xjmjeEyVU4KlRk25JOGDv ZzKfi3uAOA4j64kTIJ5PIASw277PiqR+q8N68SZYQDUiodL0znnPRqwzTXKne+tgbRj3 HxepEnEf/Li+cMtiP3sQnErXoeGvgeBi5pe5AdBbIGQLXZTCXrNkVnzuSI6lApbbUvBV 46GQAGzCzMG4OCodweI8/H925PApBCh1InBzOnc5o/j73KMxVr1195vY/oZvkRQW4ZbG 2jGBEQgqNuvqoGz7SWgolGI5iQJOhFY2tICbGZPxYauiryA8bmhQhsaVB/1NsbLGCJCz xf9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XNr6C1+YS187TNZH8/AqwiyqGWdQ2CIfFaZnKm/9Jzs=; b=lhV7Zea27KwPG+Gjp1+Mew3/TkG5cei49UqTyLbk3wYDMhAONCE+wBt5y4H95DK7hm y19vV8MFuqBdK8B8nzDpK1hobiGk0xcbBnvb2HBRlyKG1wY/a7zQE2r7vir7h3pZjobz 49GX8Oi6K97RmR5y0alPU9Q6t0vIVIf263ChgrrhNwD/wdq8tXz8NJAUNxu30s5D/tf+ JC6GoYRcO/S79wisCra4rJWfM9WmPnwvNJbzsDjFY5cRhPEBRWAJn9ptqN9MAqMHsNdL xL5sVD3JbXaj7VPV1DNVYv0fLk/RApda462NUf0rewXnjgotYbykvXmH5A6G7lIUpocN elEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DRENFGiB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp14-20020a170906c14e00b0073dcb2ec4d2si16436506ejc.889.2022.10.12.01.56.23; Wed, 12 Oct 2022 01:56:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DRENFGiB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbiJLIzh (ORCPT + 99 others); Wed, 12 Oct 2022 04:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbiJLIzO (ORCPT ); Wed, 12 Oct 2022 04:55:14 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E78BDFA; Wed, 12 Oct 2022 01:54:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BF611CE1B48; Wed, 12 Oct 2022 08:53:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8148FC433C1; Wed, 12 Oct 2022 08:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665564821; bh=gtoItcPGfyZKLxXvw4iJ2D84Gny/uKXcQVuRYmSNaLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRENFGiB3gIe8FqXclcfZTAv/VwA/B8keHOqetejQn/fyfec9G9BeyI0m8MC3eBif TySjyg36JIJafWuDv6KXmb3JiEu4rMZXES0lg2/i2UzEWsTsQB2fTz+Oc6n8iSzlQw QX9zCkTTXSpRz1Cp07L3A5/W2XZxdAod7IrFOWQYD67ucnRNkrhe8ljPVDFn0y737M e584mW+W1sLqdPQYhzkTzUvxlkeA5ZVSHgh02tPMFFmEUDdH/erQMhlGZzS7N4DkQL V7dR712auLBtfIP2MGQ3dG8V4wTJG1Pbfc6t0wYRQeFfB1ZTvTHep/dkM/JlAtnMdB vENl3t8GwcYSg== Date: Wed, 12 Oct 2022 11:53:37 +0300 From: Jarkko Sakkinen To: Pankaj Gupta Cc: a.fatoum@pengutronix.de, gilad@benyossef.com, Jason@zx2c4.com, jejb@linux.ibm.com, zohar@linux.ibm.com, dhowells@redhat.com, sumit.garg@linaro.org, david@sigma-star.at, michael@walle.cc, john.ernberg@actia.se, jmorris@namei.org, serge@hallyn.com, herbert@gondor.apana.org.au, davem@davemloft.net, j.luebbe@pengutronix.de, ebiggers@kernel.org, richard@nod.at, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, sahil.malhotra@nxp.com, kshitiz.varshney@nxp.com, horia.geanta@nxp.com, V.Sethi@nxp.com Subject: Re: [PATCH v0 1/8] hw-bound-key: introducing the generic structure Message-ID: References: <20221006130837.17587-1-pankaj.gupta@nxp.com> <20221006130837.17587-2-pankaj.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006130837.17587-2-pankaj.gupta@nxp.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Oct 06, 2022 at 06:38:30PM +0530, Pankaj Gupta wrote: > +#define set_hbk_info(hbk_info, hw_flags, key_len) do {\ > + hbk_info->flags = hw_flags;\ > + hbk_info->key_sz = key_len;\ > +} while (0) Also this: 1. Undocumented. 2. No idea why you want to use a macro instead of inline function. BR, Jarkko