Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Oct 2022 10:00:06 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Robert Elliott <elliott@hpe.com>
Cc:     davem@davemloft.net, tim.c.chen@linux.intel.com,
        ap420073@gmail.com, ardb@kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/19] crypto: x86/crc - limit FPU preemption
Message-ID: <Y0dxJrRx/Neo4r1Z@gondor.apana.org.au>
References: <20221006223151.22159-1-elliott@hpe.com>
 <20221012215931.3896-1-elliott@hpe.com>
 <20221012215931.3896-6-elliott@hpe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221012215931.3896-6-elliott@hpe.com>
Precedence: bulk

On Wed, Oct 12, 2022 at 04:59:17PM -0500, Robert Elliott wrote:
>
> @@ -170,9 +179,17 @@ static int __crc32c_pcl_intel_finup(u32 *crcp, const u8 *data, unsigned int len,
>  				u8 *out)
>  {
>  	if (len >= CRC32C_PCL_BREAKEVEN && crypto_simd_usable()) {
> -		kernel_fpu_begin();
> -		*(__le32 *)out = ~cpu_to_le32(crc_pcl(data, len, *crcp));
> -		kernel_fpu_end();
> +		do {
> +			unsigned int chunk = min(len, FPU_BYTES);
> +
> +			kernel_fpu_begin();
> +			*crcp = crc_pcl(data, chunk, *crcp);

How about storing the intermediate result in a local variable
instead of overwriting *crcp?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt