Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp515645rwi; Thu, 13 Oct 2022 01:04:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM590vYDDpueYSZLtKaE63NU1sFS76tbsjognoXmgyKU1mL9L+yNlDK10yIQjbje2Bye7Wcm X-Received: by 2002:a05:6402:440d:b0:450:de54:3fcf with SMTP id y13-20020a056402440d00b00450de543fcfmr31007772eda.312.1665648245947; Thu, 13 Oct 2022 01:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665648245; cv=none; d=google.com; s=arc-20160816; b=FDKdvsox4FBEJj3Gjt8lwvvufUULyC/HFMzksfDn4m8swSoFVEIUI6lcV1UUE0favv 4wF4cGsvD3MS1UaVO4a7nbK9d3BSgRf26UHwI0JQG1QjMlFOSmtukB9IMh1Ojo9fUcvl lMv5Pyx/3+vLpommgA9dOa+KSGglxkDnrRV92TOoKgxZVgeVaGS+Hkke67jigsRz1qXv GHmhAca5mHvny9AIL2adiP5+xbXUeGN0v3PJevDrOM8GD1GpspkE5wMCcTUu9+eaiiLd A/QUlacGDJ5s8t4OvS+I4I7WQW2hXXJwD3TpPCGVa8GqJQj4WUetO/Xj5bJZXmACwycN UbKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=hgKJ1j+Yz+Jgy2fdlP00rsqD+dHGL3xBwd6A12VimNY=; b=YTrv/7ObdwMMR64nO7++zudq1urOlgAGC0UapooQpc3UGnDI1RyDNQVrSiplRpQVpC gL40syJk9PJc04jtPOdyKCzL1CkfqjTXrt/2GMVQMdih//Y1iNB+hYiv4jQoqBRCLT50 z71W8zcvkFqtzbPp+LxWKUTb9nIpP257JETXeClrroCe5nIqFbP1SrlgGTpBZadk6jp0 pKo+NKe6Ul8dJoMXzDfcR+SBFeyWGimf9FFJIY21wh2MMxC77Qd1tAZIQYZkZla1vC53 t0bnKrb6LjKWkp/CzvqUsRNmYQ5FR6P3a/csM57Mwun5FyXWFLO07wk3XsqcdZbcXqOx oNYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s21-20020a508d15000000b00459ff7667b4si17515862eds.203.2022.10.13.01.03.32; Thu, 13 Oct 2022 01:04:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbiJMHwM (ORCPT + 99 others); Thu, 13 Oct 2022 03:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiJMHwM (ORCPT ); Thu, 13 Oct 2022 03:52:12 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15A26F88E6; Thu, 13 Oct 2022 00:52:11 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oit0e-00EEgl-49; Thu, 13 Oct 2022 18:52:05 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 13 Oct 2022 15:52:04 +0800 Date: Thu, 13 Oct 2022 15:52:03 +0800 From: Herbert Xu To: Eric Biggers Cc: Robert Elliott , davem@davemloft.net, tim.c.chen@linux.intel.com, ap420073@gmail.com, ardb@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 19/19] crypto: x86/sha - register only the best function Message-ID: References: <20221006223151.22159-1-elliott@hpe.com> <20221012215931.3896-1-elliott@hpe.com> <20221012215931.3896-20-elliott@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Oct 12, 2022 at 11:07:43PM -0700, Eric Biggers wrote: > > I thought that it's done the way it is so that it's easy to run the self-tests > for all the different variants. Yes, we should keep it that way so that it's easy to test the different code paths for correctness and/or speed. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt