Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp648063rwi; Thu, 13 Oct 2022 03:23:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5r3pff8mbANWHW2ZPX/162/z++22t1jflEhiDOpl6ops1yvL5kMKsEZaeXOc44YoPze1bB X-Received: by 2002:a17:907:c15:b0:78d:af58:4274 with SMTP id ga21-20020a1709070c1500b0078daf584274mr16852193ejc.150.1665656591555; Thu, 13 Oct 2022 03:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665656591; cv=none; d=google.com; s=arc-20160816; b=YOi/a/3INB9NHg9/yu5UdTyDVOxMjnUy6LgZd0LktpFUe2somHGTvi0L4nflbL4Kyv K57nRJh/Bo0aIae5NnkNKYMIu4aE9H69wY5vgXlUhAjdmE2+dcfKAllTpQqYL4TmPZGb b3SmXOhfBWl3NsLzPeO2dDyxn1GaZC+ctC6HHJNJLV31YxF+XQJg5jSeKW5tf3SD4fa3 8Mcs8smapyJDmVfMTh9xGY2lEkXcdqN6S+xjKhdW0ZRwuHQ+Capixg1BLJy3QyYR3YMJ f/+zeR/y6kRXp0kuCyx5zoMaxCwrMpdTbttsFSgOtuZRQ2bM5FfHUBaTJfyCS2M9dbJ+ xnAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cf/mi8PiR7AOB7uAV/J+8RsCEujUPjdzXkLzGlxBC8Q=; b=lD7lfa/kK9H8VnxIOQmsZvweMxN0yBPoHTg9glkgBppqFXffLgNhRaddpZDepYMktW +fdwfh6eJCRgexRpLZ72QIbz96SGYMGeNmZV+Nzgk7LfKin43nfbZVJKqATbZ8wjmfyc 1/49Au9nIldhrzk4Mgp/qdz3xKO/KbK+CT8uwXQ60p3YEG1P0JNnyXrzt858vksUHwQD K/PCOwOFmvxIZkiFbrVMsqXKnZ0ahtIPOLlLUx9Y03rUj1EEqqRH0/G4Xf7jlfWk/R9T +fgAl/vHAsmsniO3TIMXUanpHU8QOmBjFaInqbIHmkwyvaGVMCqA3yIemL4m1o3R4XIt a4mA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a170906825100b0078d8f2658e3si2700589ejx.833.2022.10.13.03.22.38; Thu, 13 Oct 2022 03:23:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbiJMKRE (ORCPT + 99 others); Thu, 13 Oct 2022 06:17:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbiJMKRD (ORCPT ); Thu, 13 Oct 2022 06:17:03 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED085F6C22; Thu, 13 Oct 2022 03:17:00 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oivGV-00028B-QF; Thu, 13 Oct 2022 12:16:35 +0200 Date: Thu, 13 Oct 2022 12:16:35 +0200 From: Florian Westphal To: Rolf Eike Beer Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, "Jason A. Donenfeld" , Andrew Morton , Florian Westphal , Herbert Xu , Thomas Graf , kasan-dev@googlegroups.com, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible Message-ID: <20221013101635.GB11818@breakpoint.cc> References: <20221010230613.1076905-1-Jason@zx2c4.com> <20221010230613.1076905-6-Jason@zx2c4.com> <3026360.ZldQQBzMgz@eto.sf-tec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3026360.ZldQQBzMgz@eto.sf-tec.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Rolf Eike Beer wrote: > Florian, can you comment and maybe fix it? Can't comment, do not remember -- this was 5 years ago. > Or you wanted to move the variable before the loop and keep the random state > between the loops and only reseed when all '1' bits have been consumed. Probably. No clue, best to NOT change it to not block Jasons series and then just simplify this and remove all the useless shifts.