Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5398520rwi; Mon, 17 Oct 2022 21:07:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5uJjHCstku0bOZ71FlYn5HnKwor0qPovdLlAvLCwJgU59EYFlruBRB77nHoWLp4sw0GIfW X-Received: by 2002:a05:6a00:2305:b0:565:60b0:40d9 with SMTP id h5-20020a056a00230500b0056560b040d9mr1140948pfh.77.1666066026670; Mon, 17 Oct 2022 21:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666066026; cv=none; d=google.com; s=arc-20160816; b=VUDfuALGv7Tq8uAtKSiX06d51vPaaltoPF87x9ZUXbWTjv3A5dB2gkU8YxJi5Yy6o8 qZ873vUaLBQbAeLO1+CJUJT2gr94yeh3O+oO2ErIgjj1Pw3P9HsfXZVisy4oWn4Tny6O whIqafq/k65mJkUK/7WfpyHsMYvPnfgUTdTbcI02E+CBAszS/DjRHFvgOjTN7XOdfOxz /KQkFJpyESpN3Dbp9VJ7yhIdc1yDkldDy9erV/8ow48nJkFxLVR05y1gjt9PLGrFWL8X jQ/OXkSCzPmVfDBugP8KsbgVXiyJxqQ8SE45rZAHQSktEFEXl60U213fUmUM8LwGWKA2 ysrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=9eVkLzma6tT0rjs/mMzuSniDNbTMmbQJAt6cTAXTBRs=; b=dlHmuQF24VAZmcg4dIiJW6a4u6ikWCiWBl3rg0ZMnMdcjE0FM/bKrZRs6iU3uXlOVs kj4C/OYdreC5UQCYxx4UZy7VMVyb+6RfAvHszBZ5/LCgl30AuvaLhqXI906RYMgcC/we WXnVAgYMVEGHkfxnJjHzaNT9ePriYe6XdLqMU+MkA/nMBbyTveUxwCsw0Nq3NEc4uDMF IuMd25RWP9tUdgXoaFjd9H68EZSenv8L+92yI95gaDwuINXwXDF5KC/w/g1yKNEM4nkN NT0D6jYDjVpnQ9Q8sa8E6znAlqrqyfP8P3FzZUuyt26lEzdnwrSyMgWBaWj3/T6pTxCk MJeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a056a0008cd00b005383ec972b3si15697289pfu.72.2022.10.17.21.06.40; Mon, 17 Oct 2022 21:07:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbiJREEm (ORCPT + 99 others); Tue, 18 Oct 2022 00:04:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbiJREEh (ORCPT ); Tue, 18 Oct 2022 00:04:37 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA07412751; Mon, 17 Oct 2022 21:04:32 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1okdp1-00Foo3-6i; Tue, 18 Oct 2022 15:03:20 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 18 Oct 2022 12:03:19 +0800 Date: Tue, 18 Oct 2022 12:03:19 +0800 From: Herbert Xu To: Eric Biggers Cc: Nathan Huckleberry , Bruno Goncalves , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: x86/polyval - Fix crashes when keys are not 16-byte aligned Message-ID: References: <20221017222620.715153-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Oct 17, 2022 at 05:12:16PM -0700, Eric Biggers wrote: > > arm64 defines ARCH_DMA_MINALIGN to 128, so I don't think the same issue applies > there. Also the instructions used don't assume aligned addresses. Note that arm64 may lower ARCH_KMALLOC_MINALIGN to 8 soon. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt