Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp9627rwi; Tue, 18 Oct 2022 13:22:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5WhvwuKipZqElczaypbhuOgmFH2C8JLjBPQyt0G+XZ4WT0KtQEPhEwSh+Mt8zwcKpG7bOZ X-Received: by 2002:a05:6402:40d0:b0:45c:d00a:82bd with SMTP id z16-20020a05640240d000b0045cd00a82bdmr4139695edb.288.1666124534887; Tue, 18 Oct 2022 13:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666124534; cv=none; d=google.com; s=arc-20160816; b=n+1TFI/qK7nlGWnCaXmIe62wj8LRD3W+SJzTjtUxDTu+AyqWUtVsdTkL7v2/fr67ls OfVztVH7btD1KPRXETAetLynS8O8mp3wrnxuaPqFRc9G0Fm38/AbNqnRmm9rz+aFr8DR UhGnwlBZbxW07DHUDoAVF7iQJ50aKgoFOUrU0hOiOw0yzweMAPoQq28n96yYu4b4ANJz MlOjHhgWVbpD23ErpMOg8JtE0KWBVdxVlLiW+UGpY3B6vykSzWTy8l1zaHLz9TpRa0pa 00HvdMW4wwfn5RT2zOFZ4RSe6lDEwO0RZ6xFWMY10YUKmDkkrakkkMIlBpobFpgN0fXr 3cYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=evRBq0+AilEgJWq9ibFNPVIJgd/AU5Ef/s3FkXbx+Mo=; b=Rugsp/+34CZbCn8ZGnbx4WDRfR1WdGixmvWFdcfLHlaX/WbzNr9eAQs69QioiFfjO/ kxBPumO8RWLoBRTWloa4ogrcTaY4nE1r29iQH5E0TB0DBL3QJWRCgEmmavsbx9HD27vq oXWmCouxUmg+j/DLrPxU6kzRK3o44L8OkhExs2p8Y1TbYGEwiF0xiSqWI7WsZoqxJx+4 TYxW3kyWsji5ChewPaWJzn/ZuWGHoarFZaOzy6uazjWjqPDnJpUcfl2DD1FcKeSSUOo6 vK/9TJ+AHAw+nrPYALSPNDLK6+i/Zg1WK60dj0xoraiRntClAoMFd2dH6l/I6bSOaMc5 tp5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=pWU3y7qs; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa44-20020a17090786ac00b0078a10c159b4si12692547ejc.290.2022.10.18.13.21.23; Tue, 18 Oct 2022 13:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=pWU3y7qs; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbiJRULL (ORCPT + 99 others); Tue, 18 Oct 2022 16:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbiJRULK (ORCPT ); Tue, 18 Oct 2022 16:11:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BEECE10 for ; Tue, 18 Oct 2022 13:11:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1FAE616DB for ; Tue, 18 Oct 2022 20:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB161C433C1 for ; Tue, 18 Oct 2022 20:11:06 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="pWU3y7qs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1666123863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=evRBq0+AilEgJWq9ibFNPVIJgd/AU5Ef/s3FkXbx+Mo=; b=pWU3y7qs0i2XN0KxrsLbANOjWbp7LV4zU7qguzs5jXIsiIS/1D5BvoMxiQeTOZdGhQdXfl WPTdCUM2v2KhFawsc8dNn22U5xQaop7d/+U4wlKkR44GBoZ/SyY488K2PV43ksA9peaTQV bMr7oNm8ckuH5GCLNm/ZrSv4l7++82s= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 204d60b5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 18 Oct 2022 20:11:03 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id 63so15890688vse.2 for ; Tue, 18 Oct 2022 13:11:03 -0700 (PDT) X-Gm-Message-State: ACrzQf0URpF7WO0Lh6FI67qye/ZnFovcxc3s3eeEBE33RY5C8ejS65c5 5ujWibF1GczeGWsiVcgqP1K++D8qzBzESJul1lI= X-Received: by 2002:a67:c297:0:b0:3a7:5f0c:54c4 with SMTP id k23-20020a67c297000000b003a75f0c54c4mr2737138vsj.76.1666123861774; Tue, 18 Oct 2022 13:11:01 -0700 (PDT) MIME-Version: 1.0 References: <20221018200422.179372-1-ardb@kernel.org> In-Reply-To: <20221018200422.179372-1-ardb@kernel.org> From: "Jason A. Donenfeld" Date: Tue, 18 Oct 2022 14:10:50 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/3] crypto: Add GCM-AES implementation to lib/crypto To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, keescook@chromium.org, ebiggers@kernel.org, herbert@gondor.apana.org.au, nikunj@amd.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Oct 18, 2022 at 2:04 PM Ard Biesheuvel wrote: > > Provide a generic library implementation of GCM-AES which can be used Every place else in the world, this is called AES-GCM. Can we stick with the convention?