Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 18:50:18 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Markus Stockhausen <markus.stockhausen@gmx.de>
Cc:     linux-crypto@vger.kernel.org, markus.stockhausen@gmx.de
Subject: Re: [PATCH 3/6] crypto/realtek: hash algorithms
Message-ID: <Y1J5amO8CWp23Rk7@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221013184026.63826-4-markus.stockhausen@gmx.de>
Precedence: bulk

Markus Stockhausen <markus.stockhausen@gmx.de> wrote:
>
> +static int rtcr_ahash_import(struct ahash_request *areq, const void *in)
> +{
> +       const void *fexp = (const void *)fallback_export_state((void *)in);
> +       struct ahash_request *freq = fallback_request_ctx(areq);
> +       struct rtcr_ahash_req *hreq = ahash_request_ctx(areq);
> +       const struct rtcr_ahash_req *hexp = in;
> +
> +       hreq->state = hexp->state;
> +       if (hreq->state & RTCR_REQ_FB_ACT)
> +               hreq->state |= RTCR_REQ_FB_RDY;
> +
> +       if (rtcr_check_fallback(areq))
> +               return crypto_ahash_import(freq, fexp);
> +
> +       memcpy(hreq, hexp, sizeof(struct rtcr_ahash_req));
> +
> +       return 0;
> +}

What happens when you import a fallback export but rtcr_check_fallback
returns false?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt